mysociety/alaveteli

View on GitHub

Showing 507 of 1,317 total issues

Method alert_comment_on_request has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def self.alert_comment_on_request

    # We only check comments made in the last month - this means if the
    # cron jobs broke for more than a month events would be lost, but no
    # matter. I suspect the performance gain will be needed (with an index on updated_at)
Severity: Minor
Found in app/mailers/request_mailer.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
      fixture_set_names = Array(fixture_set_names).map(&:to_s)
      class_names = ClassCache.new class_names, config

      # FIXME: Apparently JK uses this.
Severity: Minor
Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File admin_general_controller_spec.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')

describe AdminGeneralController do

  describe "GET #index" do
Severity: Minor
Found in spec/controllers/admin_general_controller_spec.rb - About 3 hrs to fix

    File download_request_spec.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
    require File.expand_path(File.dirname(__FILE__) + '/alaveteli_dsl')
    
    describe 'when making a zipfile available' do
    
    
    Severity: Minor
    Found in spec/integration/download_request_spec.rb - About 3 hrs to fix

      Function parseOptions has 89 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function parseOptions(opts) {
      
                  $.extend(true, options, opts);
      
                  // $.extend merges arrays, rather than replacing them.  When less
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

        Method new has 89 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def new
            # All new requests are of normal_sort
            if !params[:outgoing_message].nil?
              params[:outgoing_message][:what_doing] = 'normal_sort'
            end
        Severity: Major
        Found in app/controllers/request_controller.rb - About 3 hrs to fix

          File reports_controller_spec.rb has 313 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'spec_helper'
          
          describe ReportsController do
          
            describe 'POST #create' do
          Severity: Minor
          Found in spec/controllers/reports_controller_spec.rb - About 3 hrs to fix

            Method describe_state has 87 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def describe_state
                info_request = InfoRequest.not_embargoed.find(params[:id].to_i)
                set_last_request(info_request)
            
                # If this is an external request, go to the request page - we don't allow
            Severity: Major
            Found in app/controllers/request_controller.rb - About 3 hrs to fix

              File request_controller_spec.rb has 309 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
              require File.expand_path(File.dirname(__FILE__) + '/alaveteli_dsl')
              
              describe RequestController, "when classifying an information request" do
              
              
              Severity: Minor
              Found in spec/integration/request_controller_spec.rb - About 3 hrs to fix

                Method initialize has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def initialize(user)
                    # Define abilities for the passed in user here. For example:
                    #
                    #   user ||= User.new # guest user (not logged in)
                    #   if user.is_admin?
                Severity: Major
                Found in app/models/ability.rb - About 3 hrs to fix

                  Method xapian_index has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def xapian_index(terms = true, values = true, texts = true)
                        # if we have a conditional function for indexing, call it and destroy object if failed
                        if self.class.xapian_options.include?(:if)
                          if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                          if not if_value
                  Severity: Major
                  Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

                    File draft_info_request_batches_controller_spec.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require 'spec_helper'
                    
                    shared_examples_for "creating a request" do
                      it "creates a new DraftInfoRequestBatch" do
                        expect { subject }.

                      Method render_new_compose has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def render_new_compose(batch)
                          params[:info_request] = { } if !params[:info_request]
                      
                          # Reconstruct the params
                          unless batch
                      Severity: Minor
                      Found in app/controllers/request_controller.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method destroy_and_rebuild_index has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
                          #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
                          prepare_environment
                      
                          update_existing = !(terms == true && values == true && texts == true)
                      Severity: Minor
                      Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method normalize_string_to_utf8 has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def normalize_string_to_utf8(s, suggested_character_encoding=nil)
                      
                        # Make a list of encodings to try:
                        to_try = []
                      
                      
                      Severity: Minor
                      Found in lib/normalize_string.rb - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function drawBar has 81 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              function drawBar(x, y, b, barLeft, barRight, fillStyleCallback, axisx, axisy, c, horizontal, lineWidth) {
                                  var left, right, bottom, top,
                                      drawLeft, drawRight, drawTop, drawBottom,
                                      tmp;
                      
                      
                      Severity: Major
                      Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                        Function insertLegend has 81 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                function insertLegend() {
                        
                                    placeholder.find(".legend").remove();
                        
                                    if (!options.legend.show)
                        Severity: Major
                        Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix

                          File mail_backend.rb has 300 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          require 'mail'
                          require 'mapi/msg'
                          require 'mapi/convert'
                          
                          module Mail
                          Severity: Minor
                          Found in lib/mail_handler/backends/mail_backend.rb - About 3 hrs to fix

                            Method main has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def main(in_test_mode)
                              Dir.chdir($alaveteli_dir) do
                                raw_message = $stdin.read
                                begin
                                  message = MailHandler.mail_from_raw_email(raw_message)
                            Severity: Minor
                            Found in script/handle-mail-replies.rb - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method authenticate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def authenticate
                                if AlaveteliConfiguration::skip_admin_auth
                                  session[:using_admin] = 1
                                  return
                                else
                            Severity: Minor
                            Found in app/controllers/admin_controller.rb - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language