mysociety/alaveteli

View on GitHub

Showing 423 of 436 total issues

Avoid too many return statements within this method.
Open

      return true if subject.end_with? "is out of the office"
Severity: Major
Found in lib/mail_handler/reply_handler.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return true if subject == "out of office"
    Severity: Major
    Found in lib/mail_handler/reply_handler.rb - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def prepare_outgoing_message(message)
          return if cannot?(:read, message)
      
          sent_at = message.last_sent_at.to_formatted_s(:filename)
          name = "outgoing_#{message.id}.txt"
      Severity: Minor
      Found in app/services/info_request_batch_zip.rb and 1 other location - About 30 mins to fix
      app/services/info_request_batch_zip.rb on lines 93..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def prepare_incoming_message(message)
          return if cannot?(:read, message)
      
          sent_at = message.sent_at.to_formatted_s(:filename)
          name = "incoming_#{message.id}.txt"
      Severity: Minor
      Found in app/services/info_request_batch_zip.rb and 1 other location - About 30 mins to fix
      app/services/info_request_batch_zip.rb on lines 83..90

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            score_mappings: {
              name_is_all_lowercase?: 1,
              name_is_one_word?: 1,
              name_includes_non_alpha_characters?: 1,
              name_is_garbled?: 1,
      Severity: Minor
      Found in app/controllers/concerns/user_spam_check.rb and 1 other location - About 25 mins to fix
      lib/user_spam_scorer.rb on lines 2..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        DEFAULT_SCORE_MAPPINGS = {
          name_is_all_lowercase?: 1,
          name_is_one_word?: 1,
          name_includes_non_alpha_characters?: 3,
          name_is_garbled?: 5,
      Severity: Minor
      Found in lib/user_spam_scorer.rb and 1 other location - About 25 mins to fix
      app/controllers/concerns/user_spam_check.rb on lines 36..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def overdue_notification(notification)
          @info_request = notification.info_request_event.info_request
          @url = signin_url(r: respond_to_last_path(@info_request))
      
          set_reply_to_headers(@info_request.user)
      Severity: Minor
      Found in app/mailers/notification_mailer.rb and 1 other location - About 25 mins to fix
      app/mailers/notification_mailer.rb on lines 166..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def very_overdue_notification(notification)
          @info_request = notification.info_request_event.info_request
          @url = signin_url(r: respond_to_last_path(@info_request))
      
          set_reply_to_headers(@info_request.user)
      Severity: Minor
      Found in app/mailers/notification_mailer.rb and 1 other location - About 25 mins to fix
      app/mailers/notification_mailer.rb on lines 151..163

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method find_all_unknown_mime_types has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.find_all_unknown_mime_types
          IncomingMessage.find_each do |incoming_message|
            incoming_message.get_attachments_for_display.each do |attachment|
              if attachment.content_type.nil?
                raise "internal error incoming_message " + incoming_message.id.to_s
      Severity: Minor
      Found in app/models/incoming_message.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method user_link_for_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def user_link_for_request(request)
          if request.is_external?
            user_name = request.external_user_name || _("Anonymous user")
            if !request.external_url.nil?
              link_to user_name, request.external_url
      Severity: Minor
      Found in app/helpers/link_to_helper.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method line has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def line(opts = {})
          _line = read_attribute(:line)
      
          if opts[:redact]
            _line = strip_syslog_prefix(_line)
      Severity: Minor
      Found in app/models/mail_server_log.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_present_file_extensions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_present_file_extensions
          ret = {}
          get_attachments_for_display.each do |attachment|
            ext = AlaveteliFileTypes.mimetype_to_extension(attachment.content_type)
            if ext.nil? && !attachment.filename.nil?
      Severity: Minor
      Found in app/models/incoming_message.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method is_followupable? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def is_followupable?(incoming_message)
          if is_external?
            @followup_bad_reason = "external"
            false
          elsif !OutgoingMailer.is_followupable?(self, incoming_message)
      Severity: Minor
      Found in app/models/info_request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _convert_part_body_to_text has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def _convert_part_body_to_text(part)
          if part.nil?
            text = "[ Email has no body, please see attachments ]"
          else
            # whatever kind of attachment it is, get the UTF-8 encoded text
      Severity: Minor
      Found in app/models/incoming_message.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pending_states has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def pending_states(opts)
              # Which pending states can we transition into
              if opts.fetch(:in_internal_review, false)
                states = %w[internal_review gone_postal]
              else
      Severity: Minor
      Found in app/models/info_request/state/calculator.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method default_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def default_config
        tmp_dir = File.join(File.dirname(__FILE__), '../tmp')
      
        GEM_VERSIONS.inject({}) do |m, (r, v)|
          uri = URI(
      Severity: Minor
      Found in script/update-rubocop-config.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method internal_admin_body has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.internal_admin_body
          matching_pbs = AlaveteliLocalization.
            with_locale(AlaveteliLocalization.default_locale) do
            default_scoped.where(url_name: 'internal_admin_authority')
          end
      Severity: Minor
      Found in app/models/public_body.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method user_name_slug has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def user_name_slug
          if is_external?
            if external_user_name.nil?
              fake_slug = "anonymous"
            else
      Severity: Minor
      Found in app/models/info_request.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method translated_fields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def translated_fields
          fields = @template.tag.div id: 'div-locales' do
            @template.concat(locale_tabs)
      
            locales = @template.tag.div class: 'tab-content' do
      Severity: Minor
      Found in app/helpers/admin/translated_record_form.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method short_or_long_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def short_or_long_name
          if short_name.nil? || short_name.empty?
            name.nil? ? "" : name
          else
            short_name
      Severity: Minor
      Found in app/models/concerns/public_body_derived_fields.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language