mysociety/alaveteli

View on GitHub

Showing 1,295 of 1,299 total issues

Class User has 66 methods (exceeds 20 allowed). Consider refactoring.
Open

class User < ActiveRecord::Base
  include AlaveteliFeatures::Helpers
  include AlaveteliPro::PhaseCounts
  include User::Authenication

Severity: Major
Found in app/models/user.rb - About 1 day to fix

    File routes.rb has 555 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    include AlaveteliFeatures::Constraints
    
    # Allow easy extension from themes. Note these will have the highest priority.
    $alaveteli_route_extensions.each do |f|
      load File.join('config', f)
    Severity: Major
    Found in config/routes.rb - About 1 day to fix

      Method table_rows has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
      Open

          def table_rows
            now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
            now = now.to_s(:db)
      
            # allow a standard key to be used for doing defaults in YAML
      Severity: Minor
      Found in lib/fixture_set_table_rows_patch.rb - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File admin_public_body_categories_controller_spec.rb has 521 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'spec_helper'
      
      describe AdminPublicBodyCategoriesController do
      
        describe 'GET index' do
      Severity: Major
      Found in spec/controllers/admin_public_body_categories_controller_spec.rb - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var submitAddForm = function submitAddForm(e) {
            e.preventDefault();
            var $this = $(this);
            DraftBatchSummary.startNewXHR();
            DraftBatchSummary.currentXHR = $.ajax({
        app/assets/javascripts/alaveteli_pro/draft_batch_summary/body.js on lines 27..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 192.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var submitRemoveForm = function submitRemoveForm(e) {
            e.preventDefault();
            var $this = $(this);
            DraftBatchSummary.startNewXHR();
            DraftBatchSummary.currentXHR = $.ajax({
        app/assets/javascripts/alaveteli_pro/batch_authority_search/result.js on lines 30..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 192.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method alert_tracks has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.alert_tracks
            done_something = false
            now = Time.zone.now
            one_week_ago = now - 7.days
            User.where(["last_daily_track_email < ?", now - 1.day ]).find_each do |user|
        Severity: Minor
        Found in app/mailers/track_mailer.rb - About 7 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_language_name has 191 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.get_language_name(locale)
            language_names = {
              'ab'    => 'аҧсуа',
              'aa'    => 'Afaraf',
              'af'    => 'Afrikaans',
        Severity: Major
        Found in lib/languages.rb - About 7 hrs to fix

          File user.rb has 484 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          class User < ActiveRecord::Base
            include AlaveteliFeatures::Helpers
            include AlaveteliPro::PhaseCounts
            include User::Authenication
          
          
          Severity: Minor
          Found in app/models/user.rb - About 7 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              describe '.log_very_overdue_events' do
            
                let(:info_request){ FactoryGirl.create(:info_request) }
                let(:use_notifications_request) do
                  FactoryGirl.create(:use_notifications_request)
            Severity: Major
            Found in spec/models/info_request_spec.rb and 1 other location - About 7 hrs to fix
            spec/models/info_request_spec.rb on lines 3910..4000

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 245.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              describe '.log_overdue_events' do
            
                let(:info_request) { FactoryGirl.create(:info_request) }
                let(:use_notifications_request) do
                  FactoryGirl.create(:use_notifications_request)
            Severity: Major
            Found in spec/models/info_request_spec.rb and 1 other location - About 7 hrs to fix
            spec/models/info_request_spec.rb on lines 4009..4101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 245.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function drawSeriesLines has 187 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function drawSeriesLines(series) {
                        function plotLine(datapoints, xoffset, yoffset, axisx, axisy) {
                            var points = datapoints.points,
                                ps = datapoints.pointsize,
                                prevx = null, prevy = null;
            Severity: Major
            Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

              File admin_public_body_headings_controller_spec.rb has 467 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'spec_helper'
              
              describe AdminPublicBodyHeadingsController do
              
                describe 'GET new' do
              Severity: Minor
              Found in spec/controllers/admin_public_body_headings_controller_spec.rb - About 7 hrs to fix

                File user_controller.rb has 466 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'set'
                
                class UserController < ApplicationController
                  layout :select_layout
                  # NOTE: Rails 4 syntax: change before_filter to before_action
                Severity: Minor
                Found in app/controllers/user_controller.rb - About 7 hrs to fix

                  Function drawGrid has 177 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          function drawGrid() {
                              var i, axes, bw, bc;
                  
                              ctx.save();
                              ctx.translate(plotOffset.left, plotOffset.top);
                  Severity: Major
                  Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

                    Method xapian_index has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def xapian_index(terms = true, values = true, texts = true)
                          # if we have a conditional function for indexing, call it and destroy object if failed
                          if self.class.xapian_options.include?(:if)
                            if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                            if not if_value
                    Severity: Minor
                    Found in lib/acts_as_xapian/acts_as_xapian.rb - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File mail_server_log_spec.rb has 451 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                    
                    describe MailServerLog do
                      describe ".load_file" do
                        before :each do
                    Severity: Minor
                    Found in spec/models/mail_server_log_spec.rb - About 6 hrs to fix

                      Method initialize has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def initialize(user)
                          # Define abilities for the passed in user here. For example:
                          #
                          #   user ||= User.new # guest user (not logged in)
                          #   if user.is_admin?
                      Severity: Minor
                      Found in app/models/ability.rb - About 6 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          context 'translation_attrs is a Hash' do
                      
                            it 'does not persist translations' do
                              body = FactoryGirl.create(:public_body)
                              body.translations_attributes = { :es => { :locale => 'es',
                      Severity: Major
                      Found in spec/models/public_body_spec.rb and 1 other location - About 6 hrs to fix
                      spec/models/public_body_heading_spec.rb on lines 72..142

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 219.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          context 'translation_attrs is a Hash' do
                      
                            it 'does not persist translations' do
                              heading = FactoryGirl.create(:public_body_heading)
                              heading.translations_attributes = { :es => { :locale => 'es',
                      Severity: Major
                      Found in spec/models/public_body_heading_spec.rb and 1 other location - About 6 hrs to fix
                      spec/models/public_body_spec.rb on lines 525..595

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 219.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language