mysociety/alaveteli

View on GitHub

Showing 628 of 630 total issues

Method initialize has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(user)
    # Define abilities for the passed in user here. For example:
    #
    #   user ||= User.new # guest user (not logged in)
    #   if user.is_admin?
Severity: Minor
Found in app/models/ability.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if (y1 >= y2 && y1 > axisy.max) {
                        if (y2 > axisy.max)
                            continue;
                        x1 = (axisy.max - y1) / (y2 - y1) * (x2 - x1) + x1;
                        y1 = axisy.max;
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 2199..2210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if (x1 <= x2 && x1 < axisx.min) {
                        if (x2 < axisx.min)
                            continue;
                        y1 = (axisx.min - x1) / (x2 - x1) * (y2 - y1) + y1;
                        x1 = axisx.min;
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 2185..2196

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function processData has 167 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        function processData() {
            var topSentry = Number.POSITIVE_INFINITY,
                bottomSentry = Number.NEGATIVE_INFINITY,
                fakeInfinity = Number.MAX_VALUE,
                i, j, k, m, length,
Severity: Major
Found in app/assets/javascripts/jquery.flot.js - About 6 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (x1 >= x2 && x1 > axisx.max) {
                            if (x2 > axisx.max)
                                continue;
                            y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                            x1 = axisx.max;
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
    app/assets/javascripts/jquery.flot.js on lines 2213..2224

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 167.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (x1 >= x2 && x1 > axisx.max) {
                            if (x2 > axisx.max)
                                continue;
                            y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                            x1 = axisx.max;
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
    app/assets/javascripts/jquery.flot.js on lines 2296..2307

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 167.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                for (i = 0; i < axisCount; ++i) {
    
                    axisOptions = options.yaxes[i];
                    if (axisOptions && !axisOptions.tickColor) {
                        axisOptions.tickColor = axisOptions.color;
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
    app/assets/javascripts/jquery.flot.js on lines 749..765

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                for (i = 0; i < axisCount; ++i) {
    
                    axisOptions = options.xaxes[i];
                    if (axisOptions && !axisOptions.tickColor) {
                        axisOptions.tickColor = axisOptions.color;
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
    app/assets/javascripts/jquery.flot.js on lines 768..784

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Class InfoRequestEvent has 46 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class InfoRequestEvent < ActiveRecord::Base
      include AdminColumn
      extend XapianQueries
    
      EVENT_TYPES = [
    Severity: Minor
    Found in app/models/info_request_event.rb - About 6 hrs to fix

      Function d3TimeSeries has 158 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function d3TimeSeries(selector, data, title, metric_name) {
      
        // Add the title
        var wrapper_element = document.querySelectorAll(selector)[0];
      
      
      Severity: Major
      Found in app/assets/javascripts/time_series.js - About 6 hrs to fix

        Class OutgoingMessage has 44 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class OutgoingMessage < ActiveRecord::Base
          include AdminColumn
          include MessageProminence
          include Rails.application.routes.url_helpers
          include LinkToHelper
        Severity: Minor
        Found in app/models/outgoing_message.rb - About 6 hrs to fix

          Method import_csv_from_file has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.import_csv_from_file(csv_filename, tag, tag_behaviour, dry_run, editor, available_locales = [])
              errors = []
              notes = []
              begin
                ActiveRecord::Base.transaction do
          Severity: Minor
          Found in app/models/public_body.rb - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File user_controller.rb has 413 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'set'
          
          class UserController < ApplicationController
            include UserSpamCheck
          
          
          Severity: Minor
          Found in app/controllers/user_controller.rb - About 5 hrs to fix

            Class RequestController has 43 methods (exceeds 20 allowed). Consider refactoring.
            Open

            class RequestController < ApplicationController
              before_action :check_read_only, :only => [ :new, :describe_state, :upload_response ]
              before_action :check_batch_requests_and_user_allowed, :only => [ :select_authorities, :new_batch ]
              before_action :set_render_recaptcha, :only => [ :new ]
              before_action :redirect_numeric_id_to_url_title, :only => [:show]
            Severity: Minor
            Found in app/controllers/request_controller.rb - About 5 hrs to fix

              File info_request_event.rb has 407 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              class InfoRequestEvent < ActiveRecord::Base
                include AdminColumn
                extend XapianQueries
              
                EVENT_TYPES = [
              Severity: Minor
              Found in app/models/info_request_event.rb - About 5 hrs to fix

                File incoming_message.rb has 403 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'rexml/document'
                require 'zip'
                require 'iconv' unless String.method_defined?(:encode)
                
                class IncomingMessage < ActiveRecord::Base
                Severity: Minor
                Found in app/models/incoming_message.rb - About 5 hrs to fix

                  Function setup has 141 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          setup: function() {
                              var self      = this;
                              var settings  = self.settings;
                              var eventNS   = self.eventNS;
                              var $window   = $(window);
                  Severity: Major
                  Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 5 hrs to fix

                    File request_mailer.rb has 396 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    class RequestMailer < ApplicationMailer
                      include AlaveteliFeatures::Helpers
                    
                      before_action :set_footer_template,
                                    :only => [
                    Severity: Minor
                    Found in app/mailers/request_mailer.rb - About 5 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (drawUpper) {
                                  if (err.upperCap == '-'){
                                      if (err.err=='x') drawPath(ctx, [[upper,y - radius],[upper,y + radius]] );
                                      else drawPath(ctx, [[x - radius,upper],[x + radius,upper]] );
                                  } else if ($.isFunction(err.upperCap)){
                      Severity: Major
                      Found in app/assets/javascripts/jquery.flot.errorbars.js and 1 other location - About 5 hrs to fix
                      app/assets/javascripts/jquery.flot.errorbars.js on lines 311..319

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 143.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        BatchAuthoritySearch.bindXHR = function bindXHR() {
                          BatchAuthoritySearch.currentXHR.done(function(data) {
                            $el.trigger(Events.loadingSuccess, {html: data});
                          });
                          BatchAuthoritySearch.currentXHR.fail(function(xhr, textStatus) {
                      app/assets/javascripts/alaveteli_pro/draft_batch_summary/initialise.js on lines 33..43

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 143.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language