mysociety/alaveteli

View on GitHub

Showing 210 of 632 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if (x1 >= x2 && x1 > axisx.max) {
                        if (x2 > axisx.max)
                            continue;
                        y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                        x1 = axisx.max;
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 2213..2224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 167.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if (x1 >= x2 && x1 > axisx.max) {
                        if (x2 > axisx.max)
                            continue;
                        y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                        x1 = axisx.max;
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 2296..2307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 167.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for (i = 0; i < axisCount; ++i) {

                axisOptions = options.xaxes[i];
                if (axisOptions && !axisOptions.tickColor) {
                    axisOptions.tickColor = axisOptions.color;
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 768..784

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for (i = 0; i < axisCount; ++i) {

                axisOptions = options.yaxes[i];
                if (axisOptions && !axisOptions.tickColor) {
                    axisOptions.tickColor = axisOptions.color;
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 749..765

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function d3TimeSeries has 158 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function d3TimeSeries(selector, data, title, metric_name) {

  // Add the title
  var wrapper_element = document.querySelectorAll(selector)[0];

Severity: Major
Found in app/assets/javascripts/time_series.js - About 6 hrs to fix

    Function setup has 141 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            setup: function() {
                var self      = this;
                var settings  = self.settings;
                var eventNS   = self.eventNS;
                var $window   = $(window);
    Severity: Major
    Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 5 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        DraftBatchSummary.bindXHR = function bindXHR() {
          DraftBatchSummary.currentXHR.done(function(data) {
            $el.trigger(Events.loadingSuccess, {html: data});
          });
          DraftBatchSummary.currentXHR.fail(function(xhr, textStatus) {
      app/assets/javascripts/alaveteli_pro/batch_authority_search/initialise.js on lines 31..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (drawUpper) {
                  if (err.upperCap == '-'){
                      if (err.err=='x') drawPath(ctx, [[upper,y - radius],[upper,y + radius]] );
                      else drawPath(ctx, [[x - radius,upper],[x + radius,upper]] );
                  } else if ($.isFunction(err.upperCap)){
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.errorbars.js and 1 other location - About 5 hrs to fix
      app/assets/javascripts/jquery.flot.errorbars.js on lines 311..319

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        BatchAuthoritySearch.bindXHR = function bindXHR() {
          BatchAuthoritySearch.currentXHR.done(function(data) {
            $el.trigger(Events.loadingSuccess, {html: data});
          });
          BatchAuthoritySearch.currentXHR.fail(function(xhr, textStatus) {
      app/assets/javascripts/alaveteli_pro/draft_batch_summary/initialise.js on lines 33..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (drawLower) {
                  if (err.lowerCap == '-'){
                      if (err.err=='x') drawPath(ctx, [[lower,y - radius],[lower,y + radius]] );
                      else drawPath(ctx, [[x - radius,lower],[x + radius,lower]] );
                  } else if ($.isFunction(err.lowerCap)){
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.errorbars.js and 1 other location - About 5 hrs to fix
      app/assets/javascripts/jquery.flot.errorbars.js on lines 301..309

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (i = 0; i < yaxes.length; ++i) {
                      axis = yaxes[i];
                      if (axis && axis.used) {
                          key = "y" + axis.n;
                          if (pos[key] == null && axis.n == 1)
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 5 hrs to fix
      app/assets/javascripts/jquery.flot.js on lines 896..908

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (i = 0; i < xaxes.length; ++i) {
                      axis = xaxes[i];
                      if (axis && axis.used) {
                          key = "x" + axis.n;
                          if (pos[key] == null && axis.n == 1)
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 5 hrs to fix
      app/assets/javascripts/jquery.flot.js on lines 910..922

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function selectize has 118 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $.fn.selectize = function(settings_user) {
              var defaults             = $.fn.selectize.defaults;
              var settings             = $.extend({}, defaults, settings_user);
              var attr_data            = settings.dataAttr;
              var field_label          = settings.labelField;
      Severity: Major
      Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 4 hrs to fix

        Function init has 110 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function init(plot) {
                // Taken from flot-axislabels.
                // This is kind of a hack. There are no hooks in Flot between
                // the creation and measuring of the ticks (setTicks, measureTickLabels
                // in setupGrid() ) and the drawing of the ticks and plot box
        Severity: Major
        Found in app/assets/javascripts/jquery.flot.tickrotor.js - About 4 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                            if (rotateTicks > 90) {
                                // See if any labels are too long and require increased left
                                // padding.
                                x = Math.round(plot.getPlotOffset().left + xaxis.p2c(tick.v))
                                    - Math.ceil(Math.cos(radsAboveHoriz) * tick.height)
          Severity: Major
          Found in app/assets/javascripts/jquery.flot.tickrotor.js and 1 other location - About 4 hrs to fix
          app/assets/javascripts/jquery.flot.tickrotor.js on lines 123..132

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                            } else {
                                // See if any labels are too long and require increased right
                                // padding.
                                x = Math.round(plot.getPlotOffset().left + xaxis.p2c(tick.v))
                                    + Math.ceil(Math.cos(radsAboveHoriz) * tick.height)
          Severity: Major
          Found in app/assets/javascripts/jquery.flot.tickrotor.js and 1 other location - About 4 hrs to fix
          app/assets/javascripts/jquery.flot.tickrotor.js on lines 114..123

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 122.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method world_foi_websites has 107 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def self.world_foi_websites
              world_foi_websites = [
                { :name => "WhatDoTheyKnow",
                  :country_name => "United Kingdom",
                  :country_iso_code => "GB",
          Severity: Major
          Found in lib/world_foi_websites.rb - About 4 hrs to fix

            Method search has 100 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def search
                # TODO: Why is this so complicated with arrays and stuff? Look at the route
                # in config/routes.rb for comments.
            
                # 404 if the request is a format we don't support (e.g:.json)
            Severity: Major
            Found in app/controllers/general_controller.rb - About 4 hrs to fix

              Function refreshOptions has 99 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      refreshOptions: function(triggerDropdown) {
                          var i, j, k, n, groups, groups_order, option, option_html, optgroup, optgroups, html, html_children, has_create_option;
                          var $active, $active_before, $create;
                  
                          if (typeof triggerDropdown === 'undefined') {
              Severity: Major
              Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 3 hrs to fix

                Function plotLineArea has 96 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            function plotLineArea(datapoints, axisx, axisy) {
                                var points = datapoints.points,
                                    ps = datapoints.pointsize,
                                    bottom = Math.min(Math.max(0, axisy.min), axisy.max),
                                    i = 0, top, areaOpen = false,
                Severity: Major
                Found in app/assets/javascripts/jquery.flot.js - About 3 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language