mysociety/alaveteli

View on GitHub

File routes.rb has 547 lines of code (exceeds 250 allowed). Consider refactoring.
Open

include AlaveteliFeatures::Constraints

# Allow easy extension from themes. Note these will have the highest priority.
$alaveteli_route_extensions.each do |f|
  load File.join('config', f)
Severity: Major
Found in config/routes.rb - About 1 day to fix

    File subscriptions_controller_spec.rb has 547 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require File.expand_path(File.dirname(__FILE__) + '/../../spec_helper')
    require 'stripe_mock'
    
    describe AlaveteliPro::SubscriptionsController do
      let(:stripe_helper) { StripeMock.create_test_helper }
    Severity: Major
    Found in spec/controllers/alaveteli_pro/subscriptions_controller_spec.rb - About 1 day to fix

      File admin_public_body_categories_controller_spec.rb has 521 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'spec_helper'
      
      describe AdminPublicBodyCategoriesController do
      
        describe 'GET index' do
      Severity: Major
      Found in spec/controllers/admin_public_body_categories_controller_spec.rb - About 1 day to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var submitAddForm = function submitAddForm(e) {
            e.preventDefault();
            var $this = $(this);
            DraftBatchSummary.startNewXHR();
            DraftBatchSummary.currentXHR = $.ajax({
        app/assets/javascripts/alaveteli_pro/draft_batch_summary/body.js on lines 27..47

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 192.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var submitRemoveForm = function submitRemoveForm(e) {
            e.preventDefault();
            var $this = $(this);
            DraftBatchSummary.startNewXHR();
            DraftBatchSummary.currentXHR = $.ajax({
        app/assets/javascripts/alaveteli_pro/batch_authority_search/result.js on lines 30..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 192.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method get_language_name has 191 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.get_language_name(locale)
            language_names = {
              'ab'    => 'аҧсуа',
              'aa'    => 'Afaraf',
              'af'    => 'Afrikaans',
        Severity: Major
        Found in lib/languages.rb - About 7 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            describe '.log_overdue_events' do
          
              let(:info_request) { FactoryGirl.create(:info_request) }
              let(:use_notifications_request) do
                FactoryGirl.create(:use_notifications_request)
          Severity: Major
          Found in spec/models/info_request_spec.rb and 1 other location - About 7 hrs to fix
          spec/models/info_request_spec.rb on lines 4009..4101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 245.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            describe '.log_very_overdue_events' do
          
              let(:info_request){ FactoryGirl.create(:info_request) }
              let(:use_notifications_request) do
                FactoryGirl.create(:use_notifications_request)
          Severity: Major
          Found in spec/models/info_request_spec.rb and 1 other location - About 7 hrs to fix
          spec/models/info_request_spec.rb on lines 3910..4000

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 245.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function drawSeriesLines has 187 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function drawSeriesLines(series) {
                      function plotLine(datapoints, xoffset, yoffset, axisx, axisy) {
                          var points = datapoints.points,
                              ps = datapoints.pointsize,
                              prevx = null, prevy = null;
          Severity: Major
          Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

            Function drawGrid has 177 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function drawGrid() {
                        var i, axes, bw, bc;
            
                        ctx.save();
                        ctx.translate(plotOffset.left, plotOffset.top);
            Severity: Major
            Found in app/assets/javascripts/jquery.flot.js - About 7 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  context 'translation_attrs is a Hash' do
              
                    it 'does not persist translations' do
                      heading = FactoryGirl.create(:public_body_heading)
                      heading.translations_attributes = { :es => { :locale => 'es',
              Severity: Major
              Found in spec/models/public_body_heading_spec.rb and 1 other location - About 6 hrs to fix
              spec/models/public_body_spec.rb on lines 449..519

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 219.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  context 'translation_attrs is a Hash' do
              
                    it 'does not persist translations' do
                      body = FactoryGirl.create(:public_body)
                      body.translations_attributes = { :es => { :locale => 'es',
              Severity: Major
              Found in spec/models/public_body_spec.rb and 1 other location - About 6 hrs to fix
              spec/models/public_body_heading_spec.rb on lines 72..142

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 219.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (y1 >= y2 && y1 > axisy.max) {
                                      if (y2 > axisy.max)
                                          continue;
                                      x1 = (axisy.max - y1) / (y2 - y1) * (x2 - x1) + x1;
                                      y1 = axisy.max;
              Severity: Major
              Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
              app/assets/javascripts/jquery.flot.js on lines 2199..2210

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 169.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (x1 <= x2 && x1 < axisx.min) {
                                      if (x2 < axisx.min)
                                          continue;
                                      y1 = (axisx.min - x1) / (x2 - x1) * (y2 - y1) + y1;
                                      x1 = axisx.min;
              Severity: Major
              Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
              app/assets/javascripts/jquery.flot.js on lines 2185..2196

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 169.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function processData has 167 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      function processData() {
                          var topSentry = Number.POSITIVE_INFINITY,
                              bottomSentry = Number.NEGATIVE_INFINITY,
                              fakeInfinity = Number.MAX_VALUE,
                              i, j, k, m, length,
              Severity: Major
              Found in app/assets/javascripts/jquery.flot.js - About 6 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if (x1 >= x2 && x1 > axisx.max) {
                                        if (x2 > axisx.max)
                                            continue;
                                        y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                                        x1 = axisx.max;
                Severity: Major
                Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
                app/assets/javascripts/jquery.flot.js on lines 2296..2307

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 167.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if (x1 >= x2 && x1 > axisx.max) {
                                        if (x2 > axisx.max)
                                            continue;
                                        y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                                        x1 = axisx.max;
                Severity: Major
                Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
                app/assets/javascripts/jquery.flot.js on lines 2213..2224

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 167.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    context 'a CensorRule with an associated InfoRequest' do
                
                      let(:censor_rule) { FactoryGirl.create(:info_request_censor_rule) }
                
                      it 'finds the correct censor rule to edit' do
                Severity: Major
                Found in spec/controllers/admin_censor_rule_controller_spec.rb and 2 other locations - About 6 hrs to fix
                spec/controllers/admin_censor_rule_controller_spec.rb on lines 774..843
                spec/controllers/admin_censor_rule_controller_spec.rb on lines 850..921

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 211.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    context 'a CensorRule with an associated User' do
                
                      let(:censor_rule) { FactoryGirl.create(:user_censor_rule) }
                
                      it 'finds the correct censor rule to edit' do
                Severity: Major
                Found in spec/controllers/admin_censor_rule_controller_spec.rb and 2 other locations - About 6 hrs to fix
                spec/controllers/admin_censor_rule_controller_spec.rb on lines 696..767
                spec/controllers/admin_censor_rule_controller_spec.rb on lines 850..921

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 211.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    context 'a CensorRule with an associated PublicBody' do
                
                      let(:censor_rule) { FactoryGirl.create(:public_body_censor_rule) }
                
                      it 'finds the correct censor rule to edit' do
                Severity: Major
                Found in spec/controllers/admin_censor_rule_controller_spec.rb and 2 other locations - About 6 hrs to fix
                spec/controllers/admin_censor_rule_controller_spec.rb on lines 696..767
                spec/controllers/admin_censor_rule_controller_spec.rb on lines 774..843

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 211.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status