mysociety/alaveteli

View on GitHub

Showing 826 of 1,294 total issues

File request_mailer.rb has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class RequestMailer < ApplicationMailer
  include AlaveteliFeatures::Helpers

  # Used when an FOI officer uploads a response from their web browser - this is
  # the "fake" email used to store in the same format in the database as if they
Severity: Minor
Found in app/mailers/request_mailer.rb - About 5 hrs to fix

    Class ApplicationController has 40 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class ApplicationController < ActionController::Base
      class PermissionDenied < StandardError
      end
      class RouteNotFound < StandardError
      end
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 5 hrs to fix

      File request_summary_spec.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'spec_helper'
      
      RSpec.describe AlaveteliPro::RequestSummary, type: :model do
        let(:public_bodies) { FactoryGirl.create_list(:public_body, 3) }
        let(:public_body_names) do
      Severity: Minor
      Found in spec/models/alaveteli_pro/request_summary_spec.rb - About 5 hrs to fix

        Method list has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
        Open

          def list
            long_cache
            # TODO: move some of these tag SQL queries into has_tag_string.rb
        
            like_query = params[:public_body_query]
        Severity: Minor
        Found in app/controllers/public_body_controller.rb - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method up has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
        Open

          def up
            default_locale = AlaveteliLocalization.default_locale
        
            fields = {:title => :text,
                      :description => :text}
        Severity: Minor
        Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method initialize_query has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize_query(options)
              #raise options.to_yaml
        
              self.runtime += Benchmark::realtime {
                offset = options[:offset] || 0; offset = offset.to_i
        Severity: Minor
        Found in lib/acts_as_xapian/acts_as_xapian.rb - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File transitions_spec.rb has 374 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'spec_helper'
        
        describe InfoRequest::State::Transitions do
          let(:info_request) { FactoryGirl.create(:info_request) }
        
        
        Severity: Minor
        Found in spec/models/info_request/state/transitions_spec.rb - About 5 hrs to fix

          File public_body_controller_spec.rb has 373 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
          
          require 'nokogiri'
          
          describe PublicBodyController, "when showing a body" do
          Severity: Minor
          Found in spec/controllers/public_body_controller_spec.rb - About 4 hrs to fix

            Method search has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
            Open

              def search
                # TODO: Why is this so complicated with arrays and stuff? Look at the route
                # in config/routes.rb for comments.
            
                # 404 if the request is a format we don't support (e.g:.json)
            Severity: Minor
            Found in app/controllers/general_controller.rb - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method permanently_failed_addresses has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
            Open

                def self.permanently_failed_addresses(message)
                  if MailHandler.empty_return_path?(message)
                    # Some sort of auto-response
            
                    # Check for Exim’s X-Failed-Recipients header
            Severity: Minor
            Found in lib/mail_handler/reply_handler.rb - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method new has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
            Open

              def new
                # All new requests are of normal_sort
                if !params[:outgoing_message].nil?
                  params[:outgoing_message][:what_doing] = 'normal_sort'
                end
            Severity: Minor
            Found in app/controllers/request_controller.rb - About 4 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File followups_controller_spec.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
            
            describe FollowupsController do
              render_views
            
            
            Severity: Minor
            Found in spec/controllers/followups_controller_spec.rb - About 4 hrs to fix

              File outgoing_message.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              class OutgoingMessage < ActiveRecord::Base
                include AdminColumn
                include MessageProminence
                include Rails.application.routes.url_helpers
                include LinkToHelper
              Severity: Minor
              Found in app/models/outgoing_message.rb - About 4 hrs to fix

                File xapian_spec.rb has 343 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                
                describe User, " when indexing users with Xapian" do
                
                  before(:each) do
                Severity: Minor
                Found in spec/models/xapian_spec.rb - About 4 hrs to fix

                  File jquery.flot.axislabels.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /*
                  Axis Labels Plugin for flot.
                  http://github.com/markrcote/flot-axislabels
                  
                  Original code is Copyright (c) 2010 Xuan Luo.
                  Severity: Minor
                  Found in app/assets/javascripts/jquery.flot.axislabels.js - About 4 hrs to fix

                    File general_controller_spec.rb has 341 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                    require 'fakeweb'
                    
                    describe GeneralController do
                    
                    
                    Severity: Minor
                    Found in spec/controllers/general_controller_spec.rb - About 4 hrs to fix

                      Class InfoRequest has 33 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      class InfoRequest
                        module State
                          module Transitions
                            # Returns a label for the given state, suitable for using in a form to
                            # update the status of a request.
                      Severity: Minor
                      Found in app/models/info_request/state/transitions.rb - About 4 hrs to fix

                        File track_controller_spec.rb has 340 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                        
                        describe TrackController do
                          let(:mock_cookie) { '0300fd3e1177127cebff' }
                        
                        
                        Severity: Minor
                        Found in spec/controllers/track_controller_spec.rb - About 4 hrs to fix

                          File embargo_spec.rb has 335 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          require 'spec_helper'
                          
                          describe AlaveteliPro::Embargo, :type => :model do
                            let(:embargo) { FactoryGirl.create(:embargo) }
                          
                          
                          Severity: Minor
                          Found in spec/models/alaveteli_pro/embargo_spec.rb - About 4 hrs to fix

                            Class UserController has 32 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            class UserController < ApplicationController
                              layout :select_layout
                              # NOTE: Rails 4 syntax: change before_filter to before_action
                              before_filter :normalize_url_name, :only => :show
                              before_filter :work_out_post_redirect, :only => [ :signup ]
                            Severity: Minor
                            Found in app/controllers/user_controller.rb - About 4 hrs to fix
                              Severity
                              Category
                              Status
                              Source