mysociety/alaveteli

View on GitHub

Showing 1,298 of 1,313 total issues

File user_controller.rb has 448 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'set'

class UserController < ApplicationController
  include UserSpamCheck

Severity: Minor
Found in app/controllers/user_controller.rb - About 6 hrs to fix

    Method initialize has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(user)
        # Define abilities for the passed in user here. For example:
        #
        #   user ||= User.new # guest user (not logged in)
        #   if user.is_admin?
    Severity: Minor
    Found in app/models/ability.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        context 'translation_attrs is a Hash' do
    
          it 'does not persist translations' do
            body = FactoryBot.create(:public_body)
            body.translations_attributes = { :es => { :locale => 'es',
    Severity: Major
    Found in spec/models/public_body_spec.rb and 1 other location - About 6 hrs to fix
    spec/models/public_body_heading_spec.rb on lines 74..144

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 219.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        context 'translation_attrs is a Hash' do
    
          it 'does not persist translations' do
            heading = FactoryBot.create(:public_body_heading)
            heading.translations_attributes = { :es => { :locale => 'es',
    Severity: Major
    Found in spec/models/public_body_heading_spec.rb and 1 other location - About 6 hrs to fix
    spec/models/public_body_spec.rb on lines 567..637

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 219.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (y1 >= y2 && y1 > axisy.max) {
                            if (y2 > axisy.max)
                                continue;
                            x1 = (axisy.max - y1) / (y2 - y1) * (x2 - x1) + x1;
                            y1 = axisy.max;
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
    app/assets/javascripts/jquery.flot.js on lines 2199..2210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 169.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (x1 <= x2 && x1 < axisx.min) {
                            if (x2 < axisx.min)
                                continue;
                            y1 = (axisx.min - x1) / (x2 - x1) * (y2 - y1) + y1;
                            x1 = axisx.min;
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
    app/assets/javascripts/jquery.flot.js on lines 2185..2196

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 169.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function processData has 167 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function processData() {
                var topSentry = Number.POSITIVE_INFINITY,
                    bottomSentry = Number.NEGATIVE_INFINITY,
                    fakeInfinity = Number.MAX_VALUE,
                    i, j, k, m, length,
    Severity: Major
    Found in app/assets/javascripts/jquery.flot.js - About 6 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (x1 >= x2 && x1 > axisx.max) {
                              if (x2 > axisx.max)
                                  continue;
                              y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                              x1 = axisx.max;
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
      app/assets/javascripts/jquery.flot.js on lines 2296..2307

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 167.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (x1 >= x2 && x1 > axisx.max) {
                              if (x2 > axisx.max)
                                  continue;
                              y1 = (axisx.max - x1) / (x2 - x1) * (y2 - y1) + y1;
                              x1 = axisx.max;
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
      app/assets/javascripts/jquery.flot.js on lines 2213..2224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 167.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          context 'a CensorRule with an associated InfoRequest' do
      
            let(:censor_rule) { FactoryBot.create(:info_request_censor_rule) }
      
            it 'finds the correct censor rule to edit' do
      Severity: Major
      Found in spec/controllers/admin_censor_rule_controller_spec.rb and 2 other locations - About 6 hrs to fix
      spec/controllers/admin_censor_rule_controller_spec.rb on lines 774..843
      spec/controllers/admin_censor_rule_controller_spec.rb on lines 850..921

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 211.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          context 'a CensorRule with an associated PublicBody' do
      
            let(:censor_rule) { FactoryBot.create(:public_body_censor_rule) }
      
            it 'finds the correct censor rule to edit' do
      Severity: Major
      Found in spec/controllers/admin_censor_rule_controller_spec.rb and 2 other locations - About 6 hrs to fix
      spec/controllers/admin_censor_rule_controller_spec.rb on lines 696..767
      spec/controllers/admin_censor_rule_controller_spec.rb on lines 774..843

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 211.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          context 'a CensorRule with an associated User' do
      
            let(:censor_rule) { FactoryBot.create(:user_censor_rule) }
      
            it 'finds the correct censor rule to edit' do
      Severity: Major
      Found in spec/controllers/admin_censor_rule_controller_spec.rb and 2 other locations - About 6 hrs to fix
      spec/controllers/admin_censor_rule_controller_spec.rb on lines 696..767
      spec/controllers/admin_censor_rule_controller_spec.rb on lines 850..921

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 211.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (i = 0; i < axisCount; ++i) {
      
                      axisOptions = options.xaxes[i];
                      if (axisOptions && !axisOptions.tickColor) {
                          axisOptions.tickColor = axisOptions.color;
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
      app/assets/javascripts/jquery.flot.js on lines 768..784

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (i = 0; i < axisCount; ++i) {
      
                      axisOptions = options.yaxes[i];
                      if (axisOptions && !axisOptions.tickColor) {
                          axisOptions.tickColor = axisOptions.color;
      Severity: Major
      Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 6 hrs to fix
      app/assets/javascripts/jquery.flot.js on lines 749..765

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 162.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Class InfoRequestEvent has 46 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class InfoRequestEvent < ActiveRecord::Base
        include AdminColumn
        extend XapianQueries
      
        EVENT_TYPES = [
      Severity: Minor
      Found in app/models/info_request_event.rb - About 6 hrs to fix

        Class IncomingMessage has 46 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class IncomingMessage < ActiveRecord::Base
          include AdminColumn
          include MessageProminence
        
          MAX_ATTACHMENT_TEXT_CLIPPED = 1000000 # 1Mb ish
        Severity: Minor
        Found in app/models/incoming_message.rb - About 6 hrs to fix

          Function d3TimeSeries has 158 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function d3TimeSeries(selector, data, title, metric_name) {
          
            // Add the title
            var wrapper_element = document.querySelectorAll(selector)[0];
          
          
          Severity: Major
          Found in app/assets/javascripts/time_series.js - About 6 hrs to fix

            File incoming_message.rb has 427 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'rexml/document'
            require 'zip'
            require 'iconv' unless String.method_defined?(:encode)
            
            class IncomingMessage < ActiveRecord::Base
            Severity: Minor
            Found in app/models/incoming_message.rb - About 6 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                describe '#overdue_notification' do
                  let(:public_body) do
                    FactoryBot.build(:public_body, name: 'Test public body')
                  end
                  let(:info_request) do
              Severity: Major
              Found in spec/mailers/notification_mailer_spec.rb and 1 other location - About 6 hrs to fix
              spec/mailers/notification_mailer_spec.rb on lines 731..798

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 199.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                describe '#very_overdue_notification' do
                  let(:public_body) do
                    FactoryBot.build(:public_body, name: 'Test public body')
                  end
                  let(:info_request) do
              Severity: Major
              Found in spec/mailers/notification_mailer_spec.rb and 1 other location - About 6 hrs to fix
              spec/mailers/notification_mailer_spec.rb on lines 661..727

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 199.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language