mysociety/alaveteli

View on GitHub

Showing 411 of 425 total issues

Class UserController has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

class UserController < ApplicationController
  include UserSpamCheck

  skip_before_action :html_response, only: [
    :show, :wall, :get_draft_profile_photo, :get_profile_photo
Severity: Minor
Found in app/controllers/user_controller.rb - About 3 hrs to fix

    Method alert_comment_on_request has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.alert_comment_on_request
    
        # We only check comments made in the last month - this means if the
        # cron jobs broke for more than a month events would be lost, but no
        # matter. I suspect the performance gain will be needed (with an index on updated_at)
    Severity: Minor
    Found in app/mailers/request_mailer.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
          fixture_set_names = Array(fixture_set_names).map(&:to_s)
          class_names = ClassCache.new class_names, config
    
          # FIXME: Apparently JK uses this.
    Severity: Minor
    Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function stripeForm has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function stripeForm(form, options) {
      var that = Object.assign({
        stripe: Stripe(AlaveteliPro.stripe_publishable_key),
        form: form,
        submit: document.getElementById('js-stripe-submit'),
    Severity: Major
    Found in app/assets/javascripts/alaveteli_pro/stripe.js - About 3 hrs to fix

      File mail_backend.rb has 316 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'mail'
      require 'mapi/msg'
      require 'mapi/convert'
      
      module Mail
      Severity: Minor
      Found in lib/mail_handler/backends/mail_backend.rb - About 3 hrs to fix

        Method xapian_index has 85 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def xapian_index(terms = true, values = true, texts = true)
              # if we have a conditional function for indexing, call it and destroy object if failed
              if self.class.xapian_options.include?(:if)
                if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                if not if_value
        Severity: Major
        Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

          Method render_new_compose has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
          Open

            def render_new_compose(batch)
              params[:info_request] = { } if !params[:info_request]
          
              # Reconstruct the params
              unless batch
          Severity: Minor
          Found in app/controllers/request_controller.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method destroy_and_rebuild_index has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
              #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
              prepare_environment
          
              update_existing = !(terms == true && values == true && texts == true)
          Severity: Minor
          Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method alert_overdue_requests has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.alert_overdue_requests
              info_requests = InfoRequest.where("described_state = 'waiting_response'
                          AND awaiting_description = ?
                          AND user_id is not null
                          AND use_notifications = ?
          Severity: Minor
          Found in app/mailers/request_mailer.rb - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setUpCorrespondenceCollapsing has 75 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var setUpCorrespondenceCollapsing = function(){
            $('.js-collapsable').each(function(){
              var $collapsable = $(this);
              var $triggers = $(this).find('.js-collapsable-trigger');
              var $correspondenceHeader = $(this).find('.correspondence__header');
          Severity: Major
          Found in app/assets/javascripts/correspondence-collapse.js - About 3 hrs to fix

            Method index has 73 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def index
                # Tasks to do
                @requires_admin_requests = InfoRequest.
                  find_in_state('requires_admin').
                    not_embargoed
            Severity: Major
            Found in app/controllers/admin_general_controller.rb - About 2 hrs to fix

              Method get_attachment_text_one_file has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
              Open

                def get_attachment_text_one_file(content_type, body, charset = 'utf-8')
                  # note re. charset: TMail always tries to convert email bodies
                  # to UTF8 by default, so normally it should already be that.
                  text = ''
                  # TODO: - tell all these command line tools to return utf-8
              Severity: Minor
              Found in lib/mail_handler/mail_handler.rb - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Class RequestFilter has 25 methods (exceeds 20 allowed). Consider refactoring.
              Open

                class RequestFilter
              
                  extend ActiveModel::Naming
                  include ActiveModel::Conversion
              
              
              Severity: Minor
              Found in app/models/alaveteli_pro/request_filter.rb - About 2 hrs to fix

                Method add_correspondence has 70 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def add_correspondence
                    json = ActiveSupport::JSON.decode(params[:correspondence_json])
                    attachments = params[:attachments]
                
                    direction = json["direction"]
                Severity: Major
                Found in app/controllers/api_controller.rb - About 2 hrs to fix

                  File wizard.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  (function($) {
                    var RefusalWizard = function(target, options) {
                      this.$el = $(target);
                  
                      var defaults = {
                  Severity: Minor
                  Found in app/assets/javascripts/wizard.js - About 2 hrs to fix

                    Method import_csv has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def import_csv
                        @notes = ""
                        @errors = ""
                        if request.post?
                          dry_run_only = params['commit'] != 'Upload'
                    Severity: Minor
                    Found in app/controllers/admin_public_body_controller.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method get_status_from_params has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def get_status_from_params(params)
                        query = ""
                        if params[:latest_status]
                          statuses = []
                          if params[:latest_status].class == String
                    Severity: Minor
                    Found in lib/xapian_queries.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Consider simplifying this complex logical expression.
                    Open

                        if feature_enabled? :alaveteli_pro
                          # Accessing alaveteli professional
                          if user && (user.is_pro_admin? || user.is_pro?)
                            can :access, :alaveteli_pro
                          end
                    Severity: Critical
                    Found in app/models/ability.rb - About 2 hrs to fix

                      Method alert_overdue_requests has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def self.alert_overdue_requests
                          info_requests = InfoRequest.where("described_state = 'waiting_response'
                                      AND awaiting_description = ?
                                      AND user_id is not null
                                      AND use_notifications = ?
                      Severity: Major
                      Found in app/mailers/request_mailer.rb - About 2 hrs to fix

                        Method authenticate has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                        Open

                          def authenticate
                            if AlaveteliConfiguration::skip_admin_auth
                              session[:using_admin] = 1
                              return
                            else
                        Severity: Minor
                        Found in app/controllers/admin_controller.rb - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language