mysociety/alaveteli

View on GitHub

Showing 436 of 438 total issues

Method describe_state has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def describe_state
    info_request = InfoRequest.not_embargoed.find(params[:id].to_i)
    set_last_request(info_request)

    # If this is an external request, go to the request page - we don't allow
Severity: Major
Found in app/controllers/request_controller.rb - About 3 hrs to fix

    Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
          fixture_set_names = Array(fixture_set_names).map(&:to_s)
          class_names = ClassCache.new class_names, config
    
          # FIXME: Apparently JK uses this.
    Severity: Minor
    Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method alert_comment_on_request has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.alert_comment_on_request
    
        # We only check comments made in the last month - this means if the
        # cron jobs broke for more than a month events would be lost, but no
        # matter. I suspect the performance gain will be needed (with an index on updated_at)
    Severity: Minor
    Found in app/mailers/request_mailer.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def new
        # All new requests are of normal_sort
        if !params[:outgoing_message].nil?
          params[:outgoing_message][:what_doing] = 'normal_sort'
        end
    Severity: Major
    Found in app/controllers/request_controller.rb - About 3 hrs to fix

      Class UserController has 29 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class UserController < ApplicationController
        include UserSpamCheck
      
        layout :select_layout
        before_action :normalize_url_name, :only => :show
      Severity: Minor
      Found in app/controllers/user_controller.rb - About 3 hrs to fix

        Method initialize has 85 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(user)
            # Define abilities for the passed in user here. For example:
            #
            #   user ||= User.new # guest user (not logged in)
            #   if user.is_admin?
        Severity: Major
        Found in app/models/ability.rb - About 3 hrs to fix

          Method xapian_index has 85 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def xapian_index(terms = true, values = true, texts = true)
                # if we have a conditional function for indexing, call it and destroy object if failed
                if self.class.xapian_options.include?(:if)
                  if_value = xapian_value(self.class.xapian_options[:if], :boolean)
                  if not if_value
          Severity: Major
          Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

            File mail_backend.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'mail'
            require 'mapi/msg'
            require 'mapi/convert'
            
            module Mail
            Severity: Minor
            Found in lib/mail_handler/backends/mail_backend.rb - About 3 hrs to fix

              Method render_new_compose has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

                def render_new_compose(batch)
                  params[:info_request] = { } if !params[:info_request]
              
                  # Reconstruct the params
                  unless batch
              Severity: Minor
              Found in app/controllers/request_controller.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method destroy_and_rebuild_index has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
                  #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
                  prepare_environment
              
                  update_existing = !(terms == true && values == true && texts == true)
              Severity: Minor
              Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method normalize_string_to_utf8 has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
              Open

              def normalize_string_to_utf8(s, suggested_character_encoding=nil)
              
                # Make a list of encodings to try:
                to_try = []
              
              
              Severity: Minor
              Found in lib/normalize_string.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method authenticate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                def authenticate
                  if AlaveteliConfiguration::skip_admin_auth
                    session[:using_admin] = 1
                    return
                  else
              Severity: Minor
              Found in app/controllers/admin_controller.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method main has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

              def main(in_test_mode)
                Dir.chdir($alaveteli_dir) do
                  raw_message = $stdin.read
                  begin
                    message = MailHandler.mail_from_raw_email(raw_message)
              Severity: Minor
              Found in script/handle-mail-replies.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method alert_overdue_requests has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.alert_overdue_requests
                  info_requests = InfoRequest.where("described_state = 'waiting_response'
                              AND awaiting_description = ?
                              AND user_id is not null
                              AND use_notifications = ?
              Severity: Minor
              Found in app/mailers/request_mailer.rb - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function setUpCorrespondenceCollapsing has 75 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              var setUpCorrespondenceCollapsing = function(){
                $('.js-collapsable').each(function(){
                  var $collapsable = $(this);
                  var $triggers = $(this).find('.js-collapsable-trigger');
                  var $correspondenceHeader = $(this).find('.correspondence__header');
              Severity: Major
              Found in app/assets/javascripts/correspondence-collapse.js - About 3 hrs to fix

                Method up has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def up
                    default_locale = AlaveteliLocalization.default_locale
                
                    fields = {:title => :text,
                              :description => :text}
                Severity: Major
                Found in db/migrate/20140716131107_create_category_translation_tables.rb - About 2 hrs to fix

                  Method get_attachment_text_one_file has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def get_attachment_text_one_file(content_type, body, charset = 'utf-8')
                      # note re. charset: TMail always tries to convert email bodies
                      # to UTF8 by default, so normally it should already be that.
                      text = ''
                      # TODO: - tell all these command line tools to return utf-8
                  Severity: Minor
                  Found in lib/mail_handler/mail_handler.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method index has 72 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def index
                      # Tasks to do
                      @requires_admin_requests = InfoRequest.
                        find_in_state('requires_admin').
                          not_embargoed
                  Severity: Major
                  Found in app/controllers/admin_general_controller.rb - About 2 hrs to fix

                    Class RequestFilter has 25 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                      class RequestFilter
                    
                        extend ActiveModel::Naming
                        include ActiveModel::Conversion
                    
                    
                    Severity: Minor
                    Found in app/models/alaveteli_pro/request_filter.rb - About 2 hrs to fix

                      Method add_correspondence has 70 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        def add_correspondence
                          json = ActiveSupport::JSON.decode(params[:correspondence_json])
                          attachments = params[:attachments]
                      
                          direction = json["direction"]
                      Severity: Major
                      Found in app/controllers/api_controller.rb - About 2 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language