mysociety/alaveteli

View on GitHub

Showing 847 of 1,316 total issues

Method clean_po has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    def clean_po(input)
      lines = input.split("\n")

      lines.each_with_index do |line, index|
        match = /^msgid "(.*)"/.match(line)
Severity: Minor
Found in lib/alaveteli_gettext/fuzzy_cleaner.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File password_changes_controller_spec.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')

describe PasswordChangesController do

  describe 'GET new' do
Severity: Minor
Found in spec/controllers/password_changes_controller_spec.rb - About 3 hrs to fix

    File admin_user_controller_spec.rb has 323 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
    
    describe AdminUserController do
    
      describe 'GET index' do
    Severity: Minor
    Found in spec/controllers/admin_user_controller_spec.rb - About 3 hrs to fix

      Method create_fixtures has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.create_fixtures(fixtures_directory, fixture_set_names, class_names = {}, config = ActiveRecord::Base)
            fixture_set_names = Array(fixture_set_names).map(&:to_s)
            class_names = ClassCache.new class_names, config
      
            # FIXME: Apparently JK uses this.
      Severity: Minor
      Found in lib/no_constraint_disabling.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method alert_comment_on_request has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.alert_comment_on_request
      
          # We only check comments made in the last month - this means if the
          # cron jobs broke for more than a month events would be lost, but no
          # matter. I suspect the performance gain will be needed (with an index on updated_at)
      Severity: Minor
      Found in app/mailers/request_mailer.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File download_request_spec.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
      require File.expand_path(File.dirname(__FILE__) + '/alaveteli_dsl')
      
      describe 'when making a zipfile available' do
      
      
      Severity: Minor
      Found in spec/integration/download_request_spec.rb - About 3 hrs to fix

        File admin_general_controller_spec.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
        
        describe AdminGeneralController do
        
          describe "GET #index" do
        Severity: Minor
        Found in spec/controllers/admin_general_controller_spec.rb - About 3 hrs to fix

          File reports_controller_spec.rb has 313 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'spec_helper'
          
          describe ReportsController do
          
            describe 'POST #create' do
          Severity: Minor
          Found in spec/controllers/reports_controller_spec.rb - About 3 hrs to fix

            File request_controller_spec.rb has 309 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
            require File.expand_path(File.dirname(__FILE__) + '/alaveteli_dsl')
            
            describe RequestController, "when classifying an information request" do
            
            
            Severity: Minor
            Found in spec/integration/request_controller_spec.rb - About 3 hrs to fix

              File draft_info_request_batches_controller_spec.rb has 303 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'spec_helper'
              
              shared_examples_for "creating a request" do
                it "creates a new DraftInfoRequestBatch" do
                  expect { subject }.

                Method normalize_string_to_utf8 has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                Open

                def normalize_string_to_utf8(s, suggested_character_encoding=nil)
                
                  # Make a list of encodings to try:
                  to_try = []
                
                
                Severity: Minor
                Found in lib/normalize_string.rb - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method destroy_and_rebuild_index has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                Open

                  def self.destroy_and_rebuild_index(model_classes, verbose = false, terms = true, values = true, texts = true, safe_rebuild = true)
                    #raise "when rebuilding all, please call as first and only thing done in process / task" if not ActsAsXapian.writable_db.nil?
                    prepare_environment
                
                    update_existing = !(terms == true && values == true && texts == true)
                Severity: Minor
                Found in lib/acts_as_xapian/acts_as_xapian.rb - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method render_new_compose has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                Open

                  def render_new_compose(batch)
                    params[:info_request] = { } if !params[:info_request]
                
                    # Reconstruct the params
                    unless batch
                Severity: Minor
                Found in app/controllers/request_controller.rb - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File mail_backend.rb has 300 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'mail'
                require 'mapi/msg'
                require 'mapi/convert'
                
                module Mail
                Severity: Minor
                Found in lib/mail_handler/backends/mail_backend.rb - About 3 hrs to fix

                  Method main has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def main(in_test_mode)
                    Dir.chdir($alaveteli_dir) do
                      raw_message = $stdin.read
                      begin
                        message = MailHandler.mail_from_raw_email(raw_message)
                  Severity: Minor
                  Found in script/handle-mail-replies.rb - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method authenticate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def authenticate
                      if AlaveteliConfiguration::skip_admin_auth
                        session[:using_admin] = 1
                        return
                      else
                  Severity: Minor
                  Found in app/controllers/admin_controller.rb - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method alert_overdue_requests has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def self.alert_overdue_requests
                      info_requests = InfoRequest.where("described_state = 'waiting_response'
                                  AND awaiting_description = ?
                                  AND user_id is not null
                                  AND use_notifications = ?
                  Severity: Minor
                  Found in app/mailers/request_mailer.rb - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method get_attachment_text_one_file has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def get_attachment_text_one_file(content_type, body, charset = 'utf-8')
                      # note re. charset: TMail always tries to convert email bodies
                      # to UTF8 by default, so normally it should already be that.
                      text = ''
                      # TODO: - tell all these command line tools to return utf-8
                  Severity: Minor
                  Found in lib/mail_handler/mail_handler.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Class RequestFilter has 25 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                    class RequestFilter
                  
                      extend ActiveModel::Naming
                      include ActiveModel::Conversion
                  
                  
                  Severity: Minor
                  Found in app/models/alaveteli_pro/request_filter.rb - About 2 hrs to fix

                    Method get_status_from_params has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def get_status_from_params(params)
                        query = ""
                        if params[:latest_status]
                          statuses = []
                          if params[:latest_status].class == String
                    Severity: Minor
                    Found in lib/xapian_queries.rb - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language