mysociety/alaveteli

View on GitHub

Showing 1,294 of 1,294 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for (i = 0; i < yaxes.length; ++i) {
                axis = yaxes[i];
                if (axis && axis.used) {
                    key = "y" + axis.n;
                    if (pos[key] == null && axis.n == 1)
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 5 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 896..908

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for (i = 0; i < xaxes.length; ++i) {
                axis = xaxes[i];
                if (axis && axis.used) {
                    key = "x" + axis.n;
                    if (pos[key] == null && axis.n == 1)
Severity: Major
Found in app/assets/javascripts/jquery.flot.js and 1 other location - About 5 hrs to fix
app/assets/javascripts/jquery.flot.js on lines 910..922

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    context 'when block_spam_subject? is true' do

      before do
        allow(@controller).to receive(:block_spam_subject?).and_return(true)
      end
Severity: Major
Found in spec/controllers/request_controller_spec.rb and 1 other location - About 5 hrs to fix
spec/controllers/request_controller_spec.rb on lines 1518..1563

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 168.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    context 'when block_restricted_country_ips? is true' do

      before do
        allow(@controller).
          to receive(:block_restricted_country_ips?).and_return(true)
Severity: Major
Found in spec/controllers/request_controller_spec.rb and 1 other location - About 5 hrs to fix
spec/controllers/request_controller_spec.rb on lines 1428..1472

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 168.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File transitions_spec.rb has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'spec_helper'

describe InfoRequest::State::Transitions do
  let(:info_request) { FactoryGirl.create(:info_request) }

Severity: Minor
Found in spec/models/info_request/state/transitions_spec.rb - About 5 hrs to fix

    File public_body_controller_spec.rb has 373 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
    
    require 'nokogiri'
    
    describe PublicBodyController, "when showing a body" do
    Severity: Minor
    Found in spec/controllers/public_body_controller_spec.rb - About 4 hrs to fix

      Method search has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

        def search
          # TODO: Why is this so complicated with arrays and stuff? Look at the route
          # in config/routes.rb for comments.
      
          # 404 if the request is a format we don't support (e.g:.json)
      Severity: Minor
      Found in app/controllers/general_controller.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method permanently_failed_addresses has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.permanently_failed_addresses(message)
            if MailHandler.empty_return_path?(message)
              # Some sort of auto-response
      
              # Check for Exim’s X-Failed-Recipients header
      Severity: Minor
      Found in lib/mail_handler/reply_handler.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function selectize has 118 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $.fn.selectize = function(settings_user) {
              var defaults             = $.fn.selectize.defaults;
              var settings             = $.extend({}, defaults, settings_user);
              var attr_data            = settings.dataAttr;
              var field_label          = settings.labelField;
      Severity: Major
      Found in app/assets/javascripts/alaveteli_pro/selectize.js - About 4 hrs to fix

        Method new has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
        Open

          def new
            # All new requests are of normal_sort
            if !params[:outgoing_message].nil?
              params[:outgoing_message][:what_doing] = 'normal_sort'
            end
        Severity: Minor
        Found in app/controllers/request_controller.rb - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method list has 114 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def list
            long_cache
            # TODO: move some of these tag SQL queries into has_tag_string.rb
        
            like_query = params[:public_body_query]
        Severity: Major
        Found in app/controllers/public_body_controller.rb - About 4 hrs to fix

          File followups_controller_spec.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
          
          describe FollowupsController do
            render_views
          
          
          Severity: Minor
          Found in spec/controllers/followups_controller_spec.rb - About 4 hrs to fix

            File outgoing_message.rb has 356 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            class OutgoingMessage < ActiveRecord::Base
              include AdminColumn
              include MessageProminence
              include Rails.application.routes.url_helpers
              include LinkToHelper
            Severity: Minor
            Found in app/models/outgoing_message.rb - About 4 hrs to fix

              Function init has 110 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function init(plot) {
                      // Taken from flot-axislabels.
                      // This is kind of a hack. There are no hooks in Flot between
                      // the creation and measuring of the ticks (setTicks, measureTickLabels
                      // in setupGrid() ) and the drawing of the ticks and plot box
              Severity: Major
              Found in app/assets/javascripts/jquery.flot.tickrotor.js - About 4 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                  if (rotateTicks > 90) {
                                      // See if any labels are too long and require increased left
                                      // padding.
                                      x = Math.round(plot.getPlotOffset().left + xaxis.p2c(tick.v))
                                          - Math.ceil(Math.cos(radsAboveHoriz) * tick.height)
                Severity: Major
                Found in app/assets/javascripts/jquery.flot.tickrotor.js and 1 other location - About 4 hrs to fix
                app/assets/javascripts/jquery.flot.tickrotor.js on lines 123..132

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 122.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                  } else {
                                      // See if any labels are too long and require increased right
                                      // padding.
                                      x = Math.round(plot.getPlotOffset().left + xaxis.p2c(tick.v))
                                          + Math.ceil(Math.cos(radsAboveHoriz) * tick.height)
                Severity: Major
                Found in app/assets/javascripts/jquery.flot.tickrotor.js and 1 other location - About 4 hrs to fix
                app/assets/javascripts/jquery.flot.tickrotor.js on lines 114..123

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 122.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method world_foi_websites has 107 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def self.world_foi_websites
                    world_foi_websites = [
                      { :name => "WhatDoTheyKnow",
                        :country_name => "United Kingdom",
                        :country_iso_code => "GB",
                Severity: Major
                Found in lib/world_foi_websites.rb - About 4 hrs to fix

                  File xapian_spec.rb has 343 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                  
                  describe User, " when indexing users with Xapian" do
                  
                    before(:each) do
                  Severity: Minor
                  Found in spec/models/xapian_spec.rb - About 4 hrs to fix

                    File jquery.flot.axislabels.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /*
                    Axis Labels Plugin for flot.
                    http://github.com/markrcote/flot-axislabels
                    
                    Original code is Copyright (c) 2010 Xuan Luo.
                    Severity: Minor
                    Found in app/assets/javascripts/jquery.flot.axislabels.js - About 4 hrs to fix

                      File general_controller_spec.rb has 341 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
                      require 'fakeweb'
                      
                      describe GeneralController do
                      
                      
                      Severity: Minor
                      Found in spec/controllers/general_controller_spec.rb - About 4 hrs to fix
                        Severity
                        Category
                        Status
                        Source