mysociety/alaveteli

View on GitHub
lib/fixture_set_table_rows_patch.rb

Summary

Maintainability
C
1 day
Test Coverage

Method table_rows has a Cognitive Complexity of 59 (exceeds 5 allowed). Consider refactoring.
Open

    def table_rows
      now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
      now = now.to_s(:db)

      # allow a standard key to be used for doing defaults in YAML
Severity: Minor
Found in lib/fixture_set_table_rows_patch.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method table_rows has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def table_rows
      now = ActiveRecord::Base.default_timezone == :utc ? Time.now.utc : Time.now
      now = now.to_s(:db)

      # allow a standard key to be used for doing defaults in YAML
Severity: Minor
Found in lib/fixture_set_table_rows_patch.rb - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status