mysociety/alaveteli

View on GitHub
spec/models/alaveteli_pro/request_summary_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

File request_summary_spec.rb has 386 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'spec_helper'

RSpec.describe AlaveteliPro::RequestSummary, type: :model do
  let(:public_bodies) { FactoryGirl.create_list(:public_body, 3) }
  let(:public_body_names) do
Severity: Minor
Found in spec/models/alaveteli_pro/request_summary_spec.rb - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it "creates a summary from an info_request_batch" do
            TestAfterCommit.with_commits(true) do
              batch = FactoryGirl.create(
                :info_request_batch,
                public_bodies: public_bodies
    Severity: Major
    Found in spec/models/alaveteli_pro/request_summary_spec.rb and 1 other location - About 2 hrs to fix
    spec/models/alaveteli_pro/request_summary_spec.rb on lines 192..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          it "creates a summary from an draft_info_request_batch" do
            TestAfterCommit.with_commits(true) do
              draft = FactoryGirl.create(
                :draft_info_request_batch,
                public_bodies: public_bodies
    Severity: Major
    Found in spec/models/alaveteli_pro/request_summary_spec.rb and 1 other location - About 2 hrs to fix
    spec/models/alaveteli_pro/request_summary_spec.rb on lines 168..188

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          context "when the request is a draft request" do
            let(:draft) { FactoryGirl.create(:draft_info_request) }
            let(:summary) do
              AlaveteliPro::RequestSummary.create_or_update_from(draft)
            end
    Severity: Minor
    Found in spec/models/alaveteli_pro/request_summary_spec.rb and 1 other location - About 35 mins to fix
    spec/models/alaveteli_pro/request_summary_spec.rb on lines 315..327

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          context "when the request is an InfoRequest" do
            let(:request) { FactoryGirl.create(:info_request) }
            let(:summary) do
              AlaveteliPro::RequestSummary.create_or_update_from(request)
            end
    Severity: Minor
    Found in spec/models/alaveteli_pro/request_summary_spec.rb and 1 other location - About 35 mins to fix
    spec/models/alaveteli_pro/request_summary_spec.rb on lines 234..244

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status