mysociety/alaveteli

View on GitHub
spec/models/info_request/state/calculator_spec.rb

Summary

Maintainability
A
2 hrs
Test Coverage

File calculator_spec.rb has 261 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'spec_helper'

describe InfoRequest::State::Calculator do
  let(:info_request) { FactoryGirl.create(:info_request) }
  let(:calculator) { described_class.new(info_request) }
Severity: Minor
Found in spec/models/info_request/state/calculator_spec.rb - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          let(:expected_when_not_asked_to_update) do
            {
              pending:  {
                "waiting_response"      => "I'm still <strong>waiting</strong> for my information <small>(maybe you got an acknowledgement)</small>",
                "waiting_clarification" => "I've been asked to <strong>clarify</strong> my request",
    Severity: Minor
    Found in spec/models/info_request/state/calculator_spec.rb and 1 other location - About 15 mins to fix
    spec/models/info_request/state/calculator_spec.rb on lines 140..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          let(:expected) do
            {
              pending:  {
                "waiting_response"      => "<strong>No response</strong> has been received <small>(maybe there's just an acknowledgement)</small>",
                "waiting_clarification" => "<strong>Clarification</strong> has been requested",
    Severity: Minor
    Found in spec/models/info_request/state/calculator_spec.rb and 1 other location - About 15 mins to fix
    spec/models/info_request/state/calculator_spec.rb on lines 96..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status