mysociety/alaveteli

View on GitHub
spec/views/request/_after_actions.html.erb_spec.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  context 'if @show_other_user_update_status_action is false' do
    before do
      assign :show_other_user_update_status_action, false
    end

Severity: Major
Found in spec/views/request/_after_actions.html.erb_spec.rb and 3 other locations - About 30 mins to fix
spec/views/request/_after_actions.html.erb_spec.rb on lines 17..25
spec/views/request/_after_actions.html.erb_spec.rb on lines 30..38
spec/views/request/_after_actions.html.erb_spec.rb on lines 43..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  context 'if @show_owner_update_status_action is true' do
    before do
      assign :show_owner_update_status_action, false
    end

Severity: Major
Found in spec/views/request/_after_actions.html.erb_spec.rb and 3 other locations - About 30 mins to fix
spec/views/request/_after_actions.html.erb_spec.rb on lines 30..38
spec/views/request/_after_actions.html.erb_spec.rb on lines 43..51
spec/views/request/_after_actions.html.erb_spec.rb on lines 56..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  context 'if @show_owner_update_status_action is false' do
    before do
      assign :show_owner_update_status_action, false
    end

Severity: Major
Found in spec/views/request/_after_actions.html.erb_spec.rb and 3 other locations - About 30 mins to fix
spec/views/request/_after_actions.html.erb_spec.rb on lines 17..25
spec/views/request/_after_actions.html.erb_spec.rb on lines 43..51
spec/views/request/_after_actions.html.erb_spec.rb on lines 56..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  context 'if @show_other_user_update_status_action is true' do
    before do
      assign :show_other_user_update_status_action, false
    end

Severity: Major
Found in spec/views/request/_after_actions.html.erb_spec.rb and 3 other locations - About 30 mins to fix
spec/views/request/_after_actions.html.erb_spec.rb on lines 17..25
spec/views/request/_after_actions.html.erb_spec.rb on lines 30..38
spec/views/request/_after_actions.html.erb_spec.rb on lines 56..64

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it "should display a link to annotate the request" do
    with_feature_enabled(:annotations) do
      render :partial => 'request/after_actions'
      expect(response.body).to have_css('ul.anyone_actions') do |div|
          expect(div).to have_css('a', :text => 'Add an annotation (to help the requester or others)')
Severity: Minor
Found in spec/views/request/_after_actions.html.erb_spec.rb and 1 other location - About 20 mins to fix
spec/views/request/_after_actions.html.erb_spec.rb on lines 103..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it "should not display a link to annotate the request if comments are disabled globally" do
    with_feature_disabled(:annotations) do
      render :partial => 'request/after_actions'
      expect(response.body).to have_css('ul.anyone_actions') do |div|
        expect(div).not_to have_css('a', :text => 'Add an annotation (to help the requester or others)')
Severity: Minor
Found in spec/views/request/_after_actions.html.erb_spec.rb and 1 other location - About 20 mins to fix
spec/views/request/_after_actions.html.erb_spec.rb on lines 84..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status