Showing 32 of 32 total issues
File double_metaphone.rb
has 445 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'phonetic/algorithm'
require 'phonetic/double_metaphone/code'
module Phonetic
# The Double Metaphone phonetic encoding algorithm is the second generation
Class DoubleMetaphone
has 36 methods (exceeds 20 allowed). Consider refactoring. Open
class DoubleMetaphone < Algorithm
START_OF_WORD_MAP = {
# skip these when at start of word
/^([GKP]N|WR|PS)/ => ['', '', 1],
# initial 'X' is pronounced 'Z' e.g. 'Xavier'
Method encode_word
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_word(word, options = { size: 4 })
code_size = options[:size] || 4
w = word.upcase.gsub(/[^A-Z]/, '')
return if w.empty?
two = w[0, 2]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_j
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_j(w, i, len, code)
r = 1
last = len - 1
# obvious spanish, 'jose', 'san jacinto'
if w[i, 4] == 'JOSE' || w[0, 4] =~ /SAN\s/
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_word
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.encode_word(word, options = { size: 4 })
code_size = options[:size] || 4
w = word.upcase.gsub(/[^A-Z]/, '')
return if w.empty?
two = w[0, 2]
Method encode_word
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.encode_word(word, options = { size: 4 })
code_size = options[:size] || 4
w = word.strip.upcase
code = Code.new
i = 0
Method encode_word
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_word(word, options = {})
w = word.strip.upcase.gsub(/[^A-Z]+/, '')
i = 0
code = Code.new
while i < w.size
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_c
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.encode_c(w, i, len, code)
r = 1
case
# various germanic
when c_germanic?(w, i)
Method encode_gh
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_gh(w, i, code)
if i > 0 && !vowel?(w[i - 1])
code.add 'K', 'K'
# Parker's rule (with some further refinements)
elsif !(i > 1 && w[i - 2] =~ /[BHD]/ || # e.g., 'hugh'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_s
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_s(w, i, len, code)
r = 1
last = len - 1
case
# special cases 'island', 'isle', 'carlisle', 'carlysle'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_s
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.encode_s(w, i, len, code)
r = 1
last = len - 1
case
# special cases 'island', 'isle', 'carlisle', 'carlysle'
Method encode_sc
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_sc(w, i, code)
# Schlesinger's rule
if w[i + 2] == 'H'
# dutch origin, e.g. 'school', 'schooner'
if w[i + 3, 2] =~ /OO|UY|E[DM]/
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_g
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_g(w, i, len, code)
r = 2
case
when w[i + 1] == 'H'
encode_gh(w, i, code)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_t
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_t(w, i, len, code)
r = 1
if w[i, 4] =~ /^(TION|TIA|TCH)/
code.add 'X', 'X'
r += 2
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_c
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_c(w, n)
metaph = ''
if n == 0 || w[n - 1] != 'S' || !front_vowel?(w[n + 1])
case
when w[n + 1, 2] == 'IA'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_z
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_z(w, i, len, code)
r = 1
# chinese pinyin e.g. 'zhao'
if w[i + 1] == 'H'
code.add 'J', 'J'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method encode_g
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def self.encode_g(w, n)
metaph = ''
silent = (w[n + 1] == 'H' && !vowel?(w[n + 2]))
silent = true if n > 0 && w[n + 1] == 'N'
silent = true if n > 0 && w[n - 1] == 'D' && front_vowel?(w[n + 1])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
CODE = {
B: 1, P: 1, F: 1, V: 1,
C: 2, S: 2, K: 2, G: 2, J: 2, Q: 2, X: 2, Z: 2,
D: 3, T: 3,
L: 4,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 38.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
CODE = {
B: 1, P: 1,
F: 2, V: 2,
C: 3, K: 3, S: 3,
G: 4, J: 4,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 38.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Consider simplifying this complex logical expression. Open
if i == last && i > 0 && vowel?(w[i - 1]) ||
i > 0 && w[i - 1, 5] =~ /[EO]WSK[IY]/ ||
w[0, 3] == 'SCH'
code.add '', 'F'
elsif w[i, 4] =~ /WICZ|WITZ/