naoufal/react-native-touch-id

View on GitHub

Showing 8 of 18 total issues

Function getError has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getError = (code) => {
  switch (code) {
  case codes.iOSCodes.LAErrorAuthenticationFailed:
  case codes.androidModuleCodes.AUTHENTICATION_FAILED:
    return errors.AUTHENTICATION_FAILED;
Severity: Minor
Found in errors.js - About 1 hr to fix

    Method onCreateView has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
        public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
            final View v = inflater.inflate(R.layout.fingerprint_dialog, container, false);
    
            final TextView mFingerprintDescription = (TextView) v.findViewById(R.id.fingerprint_description);
    Severity: Minor
    Found in android/src/main/java/com/rnfingerprint/FingerprintDialog.java - About 1 hr to fix

      Method authenticate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          @TargetApi(Build.VERSION_CODES.M)
          @ReactMethod
          public void authenticate(final String reason, final ReadableMap authConfig, final Callback reactErrorCallback, final Callback reactSuccessCallback) {
              final Activity activity = getCurrentActivity();
              if (inProgress || !isAppActive || activity == null) {
      Severity: Minor
      Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 1 hr to fix

        Function authenticate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          authenticate(reason, config) {
            var DEFAULT_CONFIG = {
              title: 'Authentication Required',
              imageColor: '#1306ff',
              imageErrorColor: '#ff0000',
        Severity: Minor
        Found in TouchID.android.js - About 1 hr to fix

          Method setAuthConfig has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public void setAuthConfig(final ReadableMap config) {
                  if (config == null) {
                      return;
                  }
          
          
          Severity: Minor
          Found in android/src/main/java/com/rnfingerprint/FingerprintDialog.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method isFingerprintAuthAvailable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private int isFingerprintAuthAvailable() {
                  if (android.os.Build.VERSION.SDK_INT < 23) {
                      return FingerprintAuthConstants.NOT_SUPPORTED;
                  }
          
          
          Severity: Minor
          Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return FingerprintAuthConstants.NOT_ENROLLED;
          Severity: Major
          Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return FingerprintAuthConstants.IS_SUPPORTED;
            Severity: Major
            Found in android/src/main/java/com/rnfingerprint/FingerprintAuthModule.java - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language