neos/neos-development-collection

View on GitHub

Showing 1,374 of 1,374 total issues

File moxie.js has 6662 lines of code (exceeds 250 allowed). Consider refactoring.
Open

;var MXI_DEBUG = true;
/**
 * mOxie - multi-runtime File API & XMLHttpRequest L2 Polyfill
 * v1.5.7
 *
Severity: Major
Found in Neos.Media.Browser/Resources/Public/Libraries/plupload/moxie.js - About 2 wks to fix

    File jquery-ui-1.10.3.custom.js has 3462 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*! jQuery UI - v1.10.3 - 2013-06-15
    * http://jqueryui.com
    * Includes: jquery.ui.core.js, jquery.ui.widget.js, jquery.ui.mouse.js, jquery.ui.position.js, jquery.ui.draggable.js, jquery.ui.droppable.js, jquery.ui.tooltip.js, jquery.ui.effect.js, jquery.ui.effect-highlight.js
    * Copyright 2013 jQuery Foundation and other contributors Licensed MIT */
    
    

      Function Uploader has 829 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      plupload.Uploader = function(options) {
          /**
          Fires when the current RunTime has been initialized.
      
          @event Init
      Severity: Major
      Found in Neos.Media.Browser/Resources/Public/Libraries/plupload/plupload.dev.js - About 4 days to fix

        File plupload.dev.js has 1129 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /**
         * Plupload - multi-runtime File Uploader
         * v2.3.6
         *
         * Copyright 2013, Moxiecode Systems AB
        Severity: Major
        Found in Neos.Media.Browser/Resources/Public/Libraries/plupload/plupload.dev.js - About 2 days to fix

          File Node.php has 1025 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          namespace Neos\ContentRepository\Domain\Model;
          
          /*
           * This file is part of the Neos.ContentRepository package.
          Severity: Major
          Found in Neos.ContentRepository/Classes/Domain/Model/Node.php - About 2 days to fix

            Function exports has 510 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function (grunt) {
                var path = require('path'),
                    packagePath = path.join(__dirname, '../'),
                    libraryPath = path.join(packagePath, 'Resources/Public/Library/');
            
            
            Severity: Major
            Found in Neos.Neos/Scripts/Gruntfile.js - About 2 days to fix

              File NodeDataRepository.php has 947 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              namespace Neos\ContentRepository\Domain\Repository;
              
              /*
               * This file is part of the Neos.ContentRepository package.

                Node has 119 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Node implements NodeInterface, CacheAwareInterface, TraversableNodeInterface
                {
                    /**
                     * The NodeData entity this version is for.
                     *
                Severity: Major
                Found in Neos.ContentRepository/Classes/Domain/Model/Node.php - About 2 days to fix

                  File NodeCommandControllerPlugin.php has 888 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  namespace Neos\ContentRepository\Command;
                  
                  /*
                   * This file is part of the Neos.ContentRepository package.
                  Severity: Major
                  Found in Neos.ContentRepository/Classes/Command/NodeCommandControllerPlugin.php - About 2 days to fix

                    File ImageEditor.js has 854 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    define(
                    [
                        'emberjs',
                        'Library/jquery-with-dependencies',
                        'Content/Inspector/Editors/FileUpload',

                      File jquery.ui.plupload.js has 805 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /**
                       * jquery.ui.plupload.js
                       *
                       * Copyright 2013, Moxiecode Systems AB
                       * Released under GPL License.

                        File AbstractNodeTree.js has 804 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /**
                         * Abstract node tree
                         */
                        define(
                            [

                          Function Image has 379 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              function Image() {
                          
                                  RuntimeClient.call(this);
                          
                                  Basic.extend(this, {
                          Severity: Major
                          Found in Neos.Media.Browser/Resources/Public/Libraries/plupload/moxie.js - About 1 day to fix

                            Function XMLHttpRequest has 368 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                function XMLHttpRequest() {
                                    var self = this,
                                        // this (together with _p() @see below) is here to gracefully upgrade to setter/getter syntax where possible
                                        props = {
                                            /**
                            Severity: Major
                            Found in Neos.Media.Browser/Resources/Public/Libraries/plupload/moxie.js - About 1 day to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function moveAfter(NodeInterface $referenceNode, string $newName = null): void
                                  {
                                      if ($referenceNode === $this) {
                                          return;
                                      }
                              Severity: Major
                              Found in Neos.ContentRepository/Classes/Domain/Model/Node.php and 1 other location - About 1 day to fix
                              Neos.ContentRepository/Classes/Domain/Model/Node.php on lines 589..624

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 314.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  public function moveBefore(NodeInterface $referenceNode, string $newName = null): void
                                  {
                                      if ($referenceNode === $this) {
                                          return;
                                      }
                              Severity: Major
                              Found in Neos.ContentRepository/Classes/Domain/Model/Node.php and 1 other location - About 1 day to fix
                              Neos.ContentRepository/Classes/Domain/Model/Node.php on lines 637..672

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 314.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function ExifParser has 348 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  function ExifParser(data) {
                                      var __super__, tags, tagDescs, offsets, idx, Tiff;
                                      
                                      BinaryReader.call(this, data);
                              
                              
                              Severity: Major
                              Found in Neos.Media.Browser/Resources/Public/Libraries/plupload/moxie.js - About 1 day to fix

                                Function render has a Cognitive Complexity of 86 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function render()
                                    {
                                        $changes = parent::render();
                                
                                        $html = '';
                                Severity: Minor
                                Found in Neos.Diff/Classes/Renderer/Html/HtmlSideBySideRenderer.php - About 1 day to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function execute has a Cognitive Complexity of 83 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function execute(NodeData $node)
                                    {
                                        foreach ($node->getNodeType()->getProperties() as $propertyName => $propertyConfiguration) {
                                            if (isset($propertyConfiguration['type']) && ($propertyConfiguration['type'] === ImageInterface::class || preg_match('/array\<.*\>/', $propertyConfiguration['type']))) {
                                                if (!isset($nodeProperties)) {

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                                    formatResult: function(item, container, query, escapeMarkup) {
                                                        var markup = [];
                                                        Utility.Select2.util.markMatch(item.text, query.term, markup, escapeMarkup);
                                                        var $itemContent = $('<span>' + markup.join('') + '</span>');
                                
                                
                                Neos.Neos/Resources/Public/JavaScript/Content/Inspector/Editors/ReferencesEditor.js on lines 46..61

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 277.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language