nfroidure/midifile

View on GitHub

Showing 109 of 109 total issues

Function getEvents has a Cognitive Complexity of 84 (exceeds 5 allowed). Consider refactoring.
Open

MIDIFile.prototype.getEvents = function(type, subtype) {
  var events;
  var event;
  var playTime = 0;
  var filteredEvents = [];
Severity: Minor
Found in src/MIDIFile.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (
      !(
        'M' === String.fromCharCode(this.datas.getUint8(0)) &&
        'T' === String.fromCharCode(this.datas.getUint8(1)) &&
        'h' === String.fromCharCode(this.datas.getUint8(2)) &&
Severity: Major
Found in src/MIDIFileHeader.js and 1 other location - About 3 hrs to fix
src/MIDIFileTrack.js on lines 45..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (
      !(
        'M' === String.fromCharCode(this.datas.getUint8(0)) &&
        'T' === String.fromCharCode(this.datas.getUint8(1)) &&
        'r' === String.fromCharCode(this.datas.getUint8(2)) &&
Severity: Major
Found in src/MIDIFileTrack.js and 1 other location - About 3 hrs to fix
src/MIDIFileHeader.js on lines 37..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getEvents has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MIDIFile.prototype.getEvents = function(type, subtype) {
  var events;
  var event;
  var playTime = 0;
  var filteredEvents = [];
Severity: Major
Found in src/MIDIFile.js - About 3 hrs to fix

    Function MIDIFileTrack has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function MIDIFileTrack(buffer, start) {
      let a;
      let trackLength;
    
      // no buffer, creating him
    Severity: Major
    Found in src/MIDIFileTrack.js - About 3 hrs to fix

      File MIDIFile.js has 282 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';
      
      // MIDIFile : Read (and soon edit) a MIDI file in a given ArrayBuffer
      
      // Dependencies
      Severity: Minor
      Found in src/MIDIFile.js - About 2 hrs to fix

        Function getLyrics has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        MIDIFile.prototype.getLyrics = function() {
          var events = this.getEvents(MIDIEvents.EVENT_META);
          var texts = [];
          var lyrics = [];
          var event;
        Severity: Minor
        Found in src/MIDIFile.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getLyrics has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MIDIFile.prototype.getLyrics = function() {
          var events = this.getEvents(MIDIEvents.EVENT_META);
          var texts = [];
          var lyrics = [];
          var event;
        Severity: Minor
        Found in src/MIDIFile.js - About 1 hr to fix

          Function MIDIFileTrack has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          function MIDIFileTrack(buffer, start) {
            let a;
            let trackLength;
          
            // no buffer, creating him
          Severity: Minor
          Found in src/MIDIFileTrack.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function MIDIFile has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function MIDIFile(buffer, strictMode) {
            var track;
            var curIndex;
            var i;
            var j;
          Severity: Minor
          Found in src/MIDIFile.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (event.type === MIDIEvents.EVENT_META) {
                    // tempo change events
                    if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
                      tickResolution = this.header.getTickResolution(event.tempo);
                    }
          Severity: Major
          Found in src/MIDIFile.js and 1 other location - About 1 hr to fix
          src/MIDIFile.js on lines 101..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (event.type === MIDIEvents.EVENT_META) {
                    // tempo change events
                    if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
                      tickResolution = this.header.getTickResolution(event.tempo);
                    }
          Severity: Major
          Found in src/MIDIFile.js and 1 other location - About 1 hr to fix
          src/MIDIFile.js on lines 159..164

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function MIDIFileHeader has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function MIDIFileHeader(buffer) {
            let a;
            // No buffer creating him
            if (!buffer) {
              a = new Uint8Array(MIDIFileHeader.HEADER_LENGTH);
          Severity: Minor
          Found in src/MIDIFileHeader.js - About 1 hr to fix

            Function getContent has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            MIDIFile.prototype.getContent = function() {
              var bufferLength;
              var destination;
              var origin;
              var i;
            Severity: Minor
            Found in src/MIDIFile.js - About 1 hr to fix

              Function MIDIFile has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function MIDIFile(buffer, strictMode) {
                var track;
                var curIndex;
                var i;
                var j;
              Severity: Minor
              Found in src/MIDIFile.js - About 1 hr to fix

                Function setTrackContent has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                MIDIFileTrack.prototype.setTrackContent = function(dataView) {
                  let origin;
                  let destination;
                  let i;
                  let j;
                Severity: Minor
                Found in src/MIDIFileTrack.js - About 1 hr to fix

                  Function MIDIFileHeader has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function MIDIFileHeader(buffer) {
                    let a;
                    // No buffer creating him
                    if (!buffer) {
                      a = new Uint8Array(MIDIFileHeader.HEADER_LENGTH);
                  Severity: Minor
                  Found in src/MIDIFileHeader.js - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                            if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
                              tickResolution = this.header.getTickResolution(event.tempo);
                            }
                  Severity: Major
                  Found in src/MIDIFile.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                              if (i !== smallestDelta && trackParsers[i].curEvent) {
                                trackParsers[i].curEvent.delta -=
                                  trackParsers[smallestDelta].curEvent.delta;
                              }
                    Severity: Major
                    Found in src/MIDIFile.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                if (
                                  -1 === smallestDelta ||
                                  trackParsers[i].curEvent.delta <
                                    trackParsers[smallestDelta].curEvent.delta
                                ) {
                      Severity: Major
                      Found in src/MIDIFile.js - About 45 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language