Sign upLogin

nfroidure/midifile

View on GitHub
Star
src/MIDIFile.js

Summary

Maintainability
F
4 days
Test Coverage

Function getEvents has a Cognitive Complexity of 84 (exceeds 5 allowed). Consider refactoring.
Open

MIDIFile.prototype.getEvents = function(type, subtype) {
  var events;
  var event;
  var playTime = 0;
  var filteredEvents = [];
Severity: Minor
Found in src/MIDIFile.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getEvents has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MIDIFile.prototype.getEvents = function(type, subtype) {
  var events;
  var event;
  var playTime = 0;
  var filteredEvents = [];
Severity: Major
Found in src/MIDIFile.js - About 3 hrs to fix

    File MIDIFile.js has 282 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

// MIDIFile : Read (and soon edit) a MIDI file in a given ArrayBuffer

// Dependencies
    Severity: Minor
    Found in src/MIDIFile.js - About 2 hrs to fix

      Function getLyrics has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

      MIDIFile.prototype.getLyrics = function() {
  var events = this.getEvents(MIDIEvents.EVENT_META);
  var texts = [];
  var lyrics = [];
  var event;
      Severity: Minor
      Found in src/MIDIFile.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getLyrics has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MIDIFile.prototype.getLyrics = function() {
  var events = this.getEvents(MIDIEvents.EVENT_META);
  var texts = [];
  var lyrics = [];
  var event;
      Severity: Minor
      Found in src/MIDIFile.js - About 1 hr to fix

        Function MIDIFile has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function MIDIFile(buffer, strictMode) {
  var track;
  var curIndex;
  var i;
  var j;
        Severity: Minor
        Found in src/MIDIFile.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getContent has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MIDIFile.prototype.getContent = function() {
  var bufferLength;
  var destination;
  var origin;
  var i;
        Severity: Minor
        Found in src/MIDIFile.js - About 1 hr to fix

          Function MIDIFile has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function MIDIFile(buffer, strictMode) {
  var track;
  var curIndex;
  var i;
  var j;
          Severity: Minor
          Found in src/MIDIFile.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                      if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
            tickResolution = this.header.getTickResolution(event.tempo);
          }
            Severity: Major
            Found in src/MIDIFile.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                        if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
            tickResolution = this.header.getTickResolution(event.tempo);
          }
              Severity: Major
              Found in src/MIDIFile.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          if (
            -1 === smallestDelta ||
            trackParsers[i].curEvent.delta <
              trackParsers[smallestDelta].curEvent.delta
          ) {
                Severity: Major
                Found in src/MIDIFile.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if (i !== smallestDelta && trackParsers[i].curEvent) {
            trackParsers[i].curEvent.delta -=
              trackParsers[smallestDelta].curEvent.delta;
          }
                  Severity: Major
                  Found in src/MIDIFile.js - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (event.type === MIDIEvents.EVENT_META) {
          // tempo change events
          if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
            tickResolution = this.header.getTickResolution(event.tempo);
          }
                    Severity: Major
                    Found in src/MIDIFile.js and 1 other location - About 1 hr to fix
                    src/MIDIFile.js on lines 159..164

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 65.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (event.type === MIDIEvents.EVENT_META) {
          // tempo change events
          if (event.subtype === MIDIEvents.EVENT_META_SET_TEMPO) {
            tickResolution = this.header.getTickResolution(event.tempo);
          }
                    Severity: Major
                    Found in src/MIDIFile.js and 1 other location - About 1 hr to fix
                    src/MIDIFile.js on lines 101..106

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 65.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Replace '·size·of·25bytes.' with "·size·of·25bytes."
                    Open

                              ' size of 25bytes.'
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·events.length with (i·=·0),·(j·=·events.length)
                    Open

                      for (i = 0, j = events.length; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'Invalid·track·index·('·+·index·+·')' with "Invalid·track·index·("·+·index·+·")"
                    Open

                        throw Error('Invalid track index (' + index + ')');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace './MIDIFileHeader' with "./MIDIFileHeader"
                    Open

                    var MIDIFileHeader = require('./MIDIFileHeader');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·this.tracks.length with (i·=·0),·(j·=·this.tracks.length)
                    Open

                        for (i = 0, j = this.tracks.length; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'A·track·must·contain·at·least·one·event,·none·given.' with "A·track·must·contain·at·least·one·event,·none·given."
                    Open

                        throw Error('A track must contain at least one event, none given.');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'Invalid·track·index·('·+·index·+·')' with "Invalid·track·index·("·+·index·+·")"
                    Open

                        throw Error('Invalid track index (' + index + ')');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·this.tracks.length with (i·=·0),·(j·=·this.tracks.length)
                    Open

                        for (i = 0, j = this.tracks.length; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace (i·=·0,·j·=·trackParsers.length with ((i·=·0),·(j·=·trackParsers.length)
                    Open

                          for (i = 0, j = trackParsers.length; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'L' with "L"
                    Open

                            } else if ('L' === String.fromCharCode(event.data[1])) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'A·buffer·of·a·valid·MIDI·file·must·have,·at·least,·a' with "A·buffer·of·a·valid·MIDI·file·must·have,·at·least,·a"
                    Open

                            'A buffer of a valid MIDI file must have, at least, a' +
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·this.tracks.length with (i·=·0),·(j·=·this.tracks.length)
                    Open

                      for (i = 0, j = this.tracks.length; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'use·strict' with "use·strict"
                    Open

                    'use strict';
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'utf-8' with "utf-8"
                    Open

                    var UTF8 = require('utf-8');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'Invalid·track·index·('·+·index·+·')' with "Invalid·track·index·("·+·index·+·")"
                    Open

                        throw Error('Invalid track index (' + index + ')');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·this.header.getTracksCount() with (i·=·0),·(j·=·this.header.getTracksCount())
                    Open

                        for (i = 0, j = this.header.getTracksCount(); i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace '.' with "."
                    Open

                              "Couldn't find datas corresponding to the track #" + i + '.'
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace '' with ""
                    Open

                            .join('');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·trackParsers.length with (i·=·0),·(j·=·trackParsers.length)
                    Open

                            for (i = 0, j = trackParsers.length; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'Unsupported·buffer·type,·need·ArrayBuffer·or·Uint8Array' with "Unsupported·buffer·type,·need·ArrayBuffer·or·Uint8Array"
                    Open

                      throw new Error('Unsupported buffer type, need ArrayBuffer or Uint8Array');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace '@' with "@"
                    Open

                          if ('@' === String.fromCharCode(event.data[0])) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'Invalid·track·index·('·+·index·+·')' with "Invalid·track·index·("·+·index·+·")"
                    Open

                        throw Error('Invalid track index (' + index + ')');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'It·seems·that·the·buffer·contains·too·much·datas.' with "It·seems·that·the·buffer·contains·too·much·datas."
                    Open

                          throw new Error('It seems that the buffer contains too much datas.');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace i·=·0,·j·=·MIDIFileHeader.HEADER_LENGTH with (i·=·0),·(j·=·MIDIFileHeader.HEADER_LENGTH)
                    Open

                      for (i = 0, j = MIDIFileHeader.HEADER_LENGTH; i < j; i++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace m·=·0,·n·=·this.tracks[k].datas.byteLength with (m·=·0),·(n·=·this.tracks[k].datas.byteLength)
                    Open

                        for (m = 0, n = this.tracks[k].datas.byteLength; m < n; m++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'words' with "words"
                    Open

                            0 === String.fromCharCode.apply(String, event.data).indexOf('words')
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace './MIDIFileTrack' with "./MIDIFileTrack"
                    Open

                    var MIDIFileTrack = require('./MIDIFileTrack');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'midievents' with "midievents"
                    Open

                    var MIDIEvents = require('midievents');
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'T' with "T"
                    Open

                            if ('T' === String.fromCharCode(event.data[1])) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace 'I' with "I"
                    Open

                            } else if ('I' === String.fromCharCode(event.data[1])) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    Replace k·=·0,·l·=·this.tracks.length with (k·=·0),·(l·=·this.tracks.length)
                    Open

                      for (k = 0, l = this.tracks.length; k < l; k++) {
                    Severity: Minor
                    Found in src/MIDIFile.js by eslint

                    For more information visit Source: http://eslint.org/docs/rules/

                    There are no issues that match your filters.

                    Category
                    Status