Sign upLogin

nfroidure/midifile

View on GitHub
Star
src/MIDIFileTrack.js

Summary

Maintainability
C
1 day
Test Coverage

Function MIDIFileTrack has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function MIDIFileTrack(buffer, start) {
  let a;
  let trackLength;

  // no buffer, creating him
Severity: Major
Found in src/MIDIFileTrack.js - About 3 hrs to fix

    Function MIDIFileTrack has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    function MIDIFileTrack(buffer, start) {
  let a;
  let trackLength;

  // no buffer, creating him
    Severity: Minor
    Found in src/MIDIFileTrack.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setTrackContent has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MIDIFileTrack.prototype.setTrackContent = function(dataView) {
  let origin;
  let destination;
  let i;
  let j;
    Severity: Minor
    Found in src/MIDIFileTrack.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (
      !(
        'M' === String.fromCharCode(this.datas.getUint8(0)) &&
        'T' === String.fromCharCode(this.datas.getUint8(1)) &&
        'r' === String.fromCharCode(this.datas.getUint8(2)) &&
      Severity: Major
      Found in src/MIDIFileTrack.js and 1 other location - About 3 hrs to fix
      src/MIDIFileHeader.js on lines 37..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 112.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Delete ··
      Open

                this.datas.getUint8(MIDIFileTrack.HDR_LENGTH + (trackLength - 3)) &&
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace '·No·track·end·event·found·at·the·expected·index' with "·No·track·end·event·found·at·the·expected·index"
      Open

                ' No track end event found at the expected index' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace ').' with ")."
      Open

                ').'
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'T' with "T"
      Open

              'T' === String.fromCharCode(this.datas.getUint8(1)) &&
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace ')·:' with ")·:"
      Open

                ') :' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'Invalid·MIDIFileTrack·(0x' with "Invalid·MIDIFileTrack·(0x"
      Open

              'Invalid MIDIFileTrack (0x' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace ')·:' with ")·:"
      Open

                ') :' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Delete ⏎········
      Open

            !(
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Delete ⏎······
      Open

                this.datas.getUint8(MIDIFileTrack.HDR_LENGTH + (trackLength - 1))
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace i·=·0,·j·=·origin.length with (i·=·0),·(j·=·origin.length)
      Open

        for (i = 0, j = origin.length; i < j; i++) {
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace '·MTrk·prefix·not·found' with "·MTrk·prefix·not·found"
      Open

                ' MTrk prefix not found'
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace ⏎········'M' with "M"
      Open

            !(
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace '·The·track·size·exceed·the·buffer·length.' with "·The·track·size·exceed·the·buffer·length."
      Open

                ' The track size exceed the buffer length.'
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace '·Buffer·length·must·size·at·least·12bytes' with "·Buffer·length·must·size·at·least·12bytes"
      Open

                ' Buffer length must size at least 12bytes'
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'r' with "r"
      Open

              'r' === String.fromCharCode(this.datas.getUint8(2)) &&
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace ')·:' with ")·:"
      Open

                ') :' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'Invalid·MIDIFileTrack·(0x' with "Invalid·MIDIFileTrack·(0x"
      Open

              'Invalid MIDIFileTrack (0x' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'Invalid·buffer·received.' with "Invalid·buffer·received."
      Open

            throw new Error('Invalid buffer received.');
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'Invalid·track·length,·must·size·at·least·4bytes' with "Invalid·track·length,·must·size·at·least·4bytes"
      Open

          throw new Error('Invalid track length, must size at least 4bytes');
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'Invalid·MIDIFileTrack·(0x' with "Invalid·MIDIFileTrack·(0x"
      Open

              'Invalid MIDIFileTrack (0x' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace '·(' with "·("
      Open

                ' (' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'Invalid·MIDIFileTrack·(0x' with "Invalid·MIDIFileTrack·(0x"
      Open

              'Invalid MIDIFileTrack (0x' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace ')·:' with ")·:"
      Open

                ') :' +
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'use·strict' with "use·strict"
      Open

      'use strict';
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      Replace 'k'·===·String.fromCharCode(this.datas.getUint8(3))⏎······ with "k"·===·String.fromCharCode(this.datas.getUint8(3))
      Open

              'k' === String.fromCharCode(this.datas.getUint8(3))
      Severity: Minor
      Found in src/MIDIFileTrack.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status