Sign upLogin

nheyek/SDP-2018

View on GitHub
Star

Showing 124 of 124 total issues

Player has 47 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Player implements SpecialQuestObservable {

    private static final String TAG = Player.class.getSimpleName();

    private static Player instance = null;
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/studyup/player/Player.java - About 6 hrs to fix

    File DisplayQuestionActivity.java has 349 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package ch.epfl.sweng.studyup.questions;

import android.app.AlarmManager;
import android.app.Notification;
import android.app.PendingIntent;
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/studyup/questions/DisplayQuestionActivity.java - About 4 hrs to fix

      File Player.java has 335 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      package ch.epfl.sweng.studyup.player;

import android.app.Activity;
import android.util.Log;
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/studyup/player/Player.java - About 4 hrs to fix

        File HomeActivity.java has 310 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        package ch.epfl.sweng.studyup.player;

import android.Manifest;
import android.annotation.SuppressLint;
import android.app.job.JobInfo;
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 3 hrs to fix

          HomeActivity has 27 methods (exceeds 20 allowed). Consider refactoring.
          Open

          public class HomeActivity extends NavigationStudent {
    private final int MY_PERMISSION_REQUEST_FINE_LOCATION = 202;
    private ImageView image_view;

    // Text that will be displayed in the
          Severity: Minor
          Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 3 hrs to fix

            DisplayQuestionActivity has 25 methods (exceeds 20 allowed). Consider refactoring.
            Open

            public class DisplayQuestionActivity extends RefreshContext {

    @SuppressWarnings("HardCodedStringLiteral")
    private final String TAG = "DisplayQuestionActivity";
    @SuppressWarnings("HardCodedStringLiteral")
            Severity: Minor
            Found in app/src/main/java/ch/epfl/sweng/studyup/questions/DisplayQuestionActivity.java - About 2 hrs to fix

              File Firestore.java has 282 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              package ch.epfl.sweng.studyup.firebase;

import android.app.Activity;
import android.content.Context;
import android.support.annotation.NonNull;
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sweng/studyup/firebase/Firestore.java - About 2 hrs to fix

                Firestore has 24 methods (exceeds 20 allowed). Consider refactoring.
                Open

                public class Firestore {

    private static FirebaseFirestore db = FirebaseFirestore.getInstance();
    private static final String TAG = Firestore.class.getSimpleName();
    private static Firestore instance = null;
                Severity: Minor
                Found in app/src/main/java/ch/epfl/sweng/studyup/firebase/Firestore.java - About 2 hrs to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public void populateYourSpecialQuestsList() {

        final List<SpecialQuest> yourSpecialQuestsList = Player.get().getSpecialQuests();

        List<Integer> iconList = new ArrayList<>();
                  Severity: Major
                  Found in app/src/main/java/ch/epfl/sweng/studyup/specialQuest/AvailableSpecialQuestsActivity.java and 1 other location - About 2 hrs to fix
                  app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java on lines 216..246

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 166.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public void populateSpecialQuestsList() {
        final List<SpecialQuest> specialQuestsList = Player.get().getSpecialQuests();

        List<Integer> iconList = new ArrayList<>();
        for (SpecialQuest currSpecialQuest : specialQuestsList) {
                  Severity: Major
                  Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java and 1 other location - About 2 hrs to fix
                  app/src/main/java/ch/epfl/sweng/studyup/specialQuest/AvailableSpecialQuestsActivity.java on lines 40..71

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 166.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  EditQuestionActivityTest has 23 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  @SuppressWarnings("HardCodedStringLiteral")
@RunWith(AndroidJUnit4.class)
public class EditQuestionActivityTest {
    private final String questionUUID = "Temporary fake uuid";
    private Question q;
                  Severity: Minor
                  Found in app/src/androidTest/java/ch/epfl/sweng/studyup/QuestionsTest/EditQuestionActivityTest.java - About 2 hrs to fix

                    File ManageCourseActivity.java has 267 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    package ch.epfl.sweng.studyup.teacher;

import android.content.Context;
import android.content.Intent;
import android.os.Bundle;
                    Severity: Minor
                    Found in app/src/main/java/ch/epfl/sweng/studyup/teacher/ManageCourseActivity.java - About 2 hrs to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          private final DateTimeInterpreter dateTimeInterpreter = new DateTimeInterpreter() {
        @Override
        public String interpretDate(Calendar date) {
            try {
                SimpleDateFormat sdf = new SimpleDateFormat("EEE", Locale.getDefault());
                      Severity: Major
                      Found in app/src/main/java/ch/epfl/sweng/studyup/player/ScheduleActivityStudent.java and 1 other location - About 2 hrs to fix
                      app/src/main/java/ch/epfl/sweng/studyup/teacher/ScheduleActivityTeacher.java on lines 119..143

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 151.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                          private final DateTimeInterpreter dateTimeInterpreter = new DateTimeInterpreter() {
        @Override
        public String interpretDate(Calendar date) {
            try {
                SimpleDateFormat sdf = new SimpleDateFormat("EEE", Locale.getDefault());
                      Severity: Major
                      Found in app/src/main/java/ch/epfl/sweng/studyup/teacher/ScheduleActivityTeacher.java and 1 other location - About 2 hrs to fix
                      app/src/main/java/ch/epfl/sweng/studyup/player/ScheduleActivityStudent.java on lines 62..86

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 151.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      File AddOrEditQuestionActivity.java has 260 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      package ch.epfl.sweng.studyup.questions;

import android.app.Activity;
import android.app.AlertDialog;
import android.content.DialogInterface;
                      Severity: Minor
                      Found in app/src/main/java/ch/epfl/sweng/studyup/questions/AddOrEditQuestionActivity.java - About 2 hrs to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            @Test
    public void validCacheShouldRedirectTeacher() throws Exception {

        List<String> teacherCacheData = new ArrayList<>();
        teacherCacheData.add(0, INITIAL_SCIPER);
                        Severity: Major
                        Found in app/src/androidTest/java/ch/epfl/sweng/studyup/PersistLoginTest.java and 1 other location - About 1 hr to fix
                        app/src/androidTest/java/ch/epfl/sweng/studyup/PersistLoginTest.java on lines 99..116

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method addQuestion has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public void addQuestion(View current) {
        RadioGroup imageTextRadioGroup = findViewById(R.id.text_or_image_radio_group), trueFalseRadioGroup = findViewById(R.id.true_false_or_mcq_radio_group);
        if (!(imageURI != null || bitmap != null || imageTextRadioGroup.getCheckedRadioButtonId() == R.id.text_radio_button)) return;
        RadioGroup answerGroup = findViewById(R.id.question_radio_group);
        RadioButton checkedButton = findViewById(answerGroup.getCheckedRadioButtonId());
                        Severity: Minor
                        Found in app/src/main/java/ch/epfl/sweng/studyup/questions/AddOrEditQuestionActivity.java - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            @Test
    public void validCacheShouldRedirectStudent() throws Exception {

        List<String> studentCacheData = new ArrayList<>();
        studentCacheData.add(0, INITIAL_SCIPER);
                        Severity: Major
                        Found in app/src/androidTest/java/ch/epfl/sweng/studyup/PersistLoginTest.java and 1 other location - About 1 hr to fix
                        app/src/androidTest/java/ch/epfl/sweng/studyup/PersistLoginTest.java on lines 118..135

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 105.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method loadInterface has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private void loadInterface(String lang) {

        viewPager = findViewById(R.id.viewPager);
        sliderDotsLayout = findViewById(R.id.SliderDots);
                        Severity: Minor
                        Found in app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java - About 1 hr to fix

                          Method addQuestion has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public void addQuestion(View current) {
        RadioGroup imageTextRadioGroup = findViewById(R.id.text_or_image_radio_group), trueFalseRadioGroup = findViewById(R.id.true_false_or_mcq_radio_group);
        if (!(imageURI != null || bitmap != null || imageTextRadioGroup.getCheckedRadioButtonId() == R.id.text_radio_button)) return;
        RadioGroup answerGroup = findViewById(R.id.question_radio_group);
        RadioButton checkedButton = findViewById(answerGroup.getCheckedRadioButtonId());
                          Severity: Minor
                          Found in app/src/main/java/ch/epfl/sweng/studyup/questions/AddOrEditQuestionActivity.java - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language