Sign upLogin

nicb/hijack

View on GitHub
Star
lib/hijack/output_drivers/radiant/asset_type.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class AssetType has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

      class AssetType
        
        # The Asset Type encapsulates a type of attachment.
        # Conventionally this would a sensible category like 'image' or 'video'
        # that should be processed and presented in a particular way.
Severity: Minor
Found in lib/hijack/output_drivers/radiant/asset_type.rb - About 4 hrs to fix

    Cyclomatic complexity for initialize is too high. [8/6]
    Open

            def initialize(name, options = {})
          options = options.symbolize_keys
          @name = name
          @icon_name = options[:icon] || name
          @processors = options[:processors] || []
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method define_radius_tags has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

            def define_radius_tags
          type = self.name
          Page.class_eval {
            tag "asset:if_#{type}" do |tag|
              tag.expand if find_asset(tag, tag.attr.dup).send("#{type}?".to_sym)
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use delete instead of gsub.
    Open

              Radiant::config["assets.additional_thumbnails"].to_s.gsub(' ','').split(',').collect{|s| s.split('=')}.inject({}) {|ha, (k, v)| ha[k.to_sym] = v; ha}
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop identifies places where gsub can be replaced by tr or delete.

    Example:

    # bad
'abc'.gsub('b', 'd')
'abc'.gsub('a', '')
'abc'.gsub(/a/, 'd')
'abc'.gsub!('a', 'd')

# good
'abc'.gsub(/.*/, 'a')
'abc'.gsub(/a+/, 'd')
'abc'.tr('b', 'd')
'a b c'.delete(' ')

    TODO found
    Open

              # TODO: should this default to an icon set?
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by fixme

    TODO found
    Open

            #TODO: define permitted and/or expected options for the asset type and pass through that subset of the style-definition hash
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by fixme

    Redundant use of Object#to_s in interpolation.
    Open

                return "/images/admin/assets/#{icon_name}_#{style_name.to_s}.png"
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks for string conversion in string interpolation, which is redundant.

    Example:

    # bad

"result is #{something.to_s}"

    Example:

    # good

"result is #{something}"

    Redundant use of Object#to_s in interpolation.
    Open

              if File.exist?(Rails.root + "public/images/admin/assets/#{icon_name}_#{style_name.to_s}.png")
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks for string conversion in string interpolation, which is redundant.

    Example:

    # bad

"result is #{something.to_s}"

    Example:

    # good

"result is #{something}"

    Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
    Open

              @configured_styles ||= if style_definitions = Radiant.config["assets.thumbnails.#{name}"]
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks for assignments in the conditions of if/while/until.

    Example:

    # bad

if some_var = true
  do_something
end

    Example:

    # good

if some_var == true
  do_something
end

    end at 117, 10 is not aligned with if at 113, 32.
    Open

              end
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
    Open

              if style = paperclip_styles[style_name.to_sym]
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks for assignments in the conditions of if/while/until.

    Example:

    # bad

if some_var = true
  do_something
end

    Example:

    # good

if some_var == true
  do_something
end

    end at 166, 10 is not aligned with if at 159, 33.
    Open

              end
    Severity: Minor
    Found in lib/hijack/output_drivers/radiant/asset_type.rb by rubocop

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad

variable = if true
    end

# good

variable = if true
           end

    Example: EnforcedStyleAlignWith: variable

    # bad

variable = if true
    end

# good

variable = if true
end

    Example: EnforcedStyleAlignWith: startofline

    # bad

variable = if true
    end

# good

puts(if true
end)

    There are no issues that match your filters.

    Category
    Status