nicholasjackson/minke

View on GitHub
lib/minke/tasks/task.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method run_with_block has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

      def run_with_block
        success = true

        begin
          @docker_network.create
Severity: Minor
Found in lib/minke/tasks/task.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_command_in_container has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run_command_in_container(command, blocking = false, links = nil, ports = nil)
        begin
          @logger.info "Running command: #{command}"
          settings          = @generator_config.build_settings.docker_settings
          volumes           = settings.binds.clone unless settings.binds == nil
Severity: Minor
Found in lib/minke/tasks/task.rb - About 1 hr to fix

Method run_command_in_container has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def run_command_in_container(command, blocking = false, links = nil, ports = nil)
        begin
          @logger.info "Running command: #{command}"
          settings          = @generator_config.build_settings.docker_settings
          volumes           = settings.binds.clone unless settings.binds == nil
Severity: Minor
Found in lib/minke/tasks/task.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_with_block has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def run_with_block
        success = true

        begin
          @docker_network.create
Severity: Minor
Found in lib/minke/tasks/task.rb - About 1 hr to fix

There are no issues that match your filters.

Category
Status