Sign upLogin

nning/david

View on GitHub
Star
lib/david/server/respond.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method respond has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

      def respond(exchange, env = nil)
        block_enabled = @options[:Block] && exchange.get?

        if block_enabled
          # Fail if m set.
Severity: Minor
Found in lib/david/server/respond.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method respond has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def respond(exchange, env = nil)
        block_enabled = @options[:Block] && exchange.get?

        if block_enabled
          # Fail if m set.
Severity: Major
Found in lib/david/server/respond.rb - About 2 hrs to fix

    Method basic_env has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def basic_env(exchange)
        m = exchange.message

        {
          REMOTE_ADDR       => exchange.host,
    Severity: Minor
    Found in lib/david/server/respond.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return error(exchange, 4.06) if exchange.accept && exchange.accept != cf
      Severity: Major
      Found in lib/david/server/respond.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status