nnnick/Chart.js

View on GitHub
src/plugins/plugin.legend.js

Summary

Maintainability
D
2 days
Test Coverage

File plugin.legend.js has 525 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import defaults from '../core/core.defaults.js';
import Element from '../core/core.element.js';
import layouts from '../core/core.layouts.js';
import {addRoundedRectPath, drawPointLegend, renderText} from '../helpers/helpers.canvas.js';
import {
Severity: Major
Found in src/plugins/plugin.legend.js - About 1 day to fix

    Function _draw has 118 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _draw() {
        const {options: opts, columnSizes, lineWidths, ctx} = this;
        const {align, labels: labelOpts} = opts;
        const defaultColor = defaults.color;
        const rtlHelper = getRtlAdapter(opts.rtl, this.left, this.width);
    Severity: Major
    Found in src/plugins/plugin.legend.js - About 4 hrs to fix

      Function drawLegendBox has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const drawLegendBox = function(x, y, legendItem) {
            if (isNaN(boxWidth) || boxWidth <= 0 || isNaN(boxHeight) || boxHeight < 0) {
              return;
            }
      
      
      Severity: Minor
      Found in src/plugins/plugin.legend.js - About 1 hr to fix

        Function _draw has a Cognitive Complexity of 15 (exceeds 7 allowed). Consider refactoring.
        Open

          _draw() {
            const {options: opts, columnSizes, lineWidths, ctx} = this;
            const {align, labels: labelOpts} = opts;
            const defaultColor = defaults.color;
            const rtlHelper = getRtlAdapter(opts.rtl, this.left, this.width);
        Severity: Minor
        Found in src/plugins/plugin.legend.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function adjustHitBoxes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          adjustHitBoxes() {
            if (!this.options.display) {
              return;
            }
            const titleHeight = this._computeTitleHeight();
        Severity: Minor
        Found in src/plugins/plugin.legend.js - About 1 hr to fix

          Function adjustHitBoxes has a Cognitive Complexity of 13 (exceeds 7 allowed). Consider refactoring.
          Open

            adjustHitBoxes() {
              if (!this.options.display) {
                return;
              }
              const titleHeight = this._computeTitleHeight();
          Severity: Minor
          Found in src/plugins/plugin.legend.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function drawTitle has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            drawTitle() {
              const opts = this.options;
              const titleOpts = opts.title;
              const titleFont = toFont(titleOpts.font);
              const titlePadding = toPadding(titleOpts.padding);
          Severity: Minor
          Found in src/plugins/plugin.legend.js - About 1 hr to fix

            Function handleEvent has a Cognitive Complexity of 9 (exceeds 7 allowed). Consider refactoring.
            Open

              handleEvent(e) {
                const opts = this.options;
                if (!isListened(e.type, opts)) {
                  return;
                }
            Severity: Minor
            Found in src/plugins/plugin.legend.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else {
                  this.height = this.maxHeight;
                  this.top = this._margins.top;
                  this.bottom = this.height;
                }
            Severity: Minor
            Found in src/plugins/plugin.legend.js and 1 other location - About 50 mins to fix
            src/plugins/plugin.legend.js on lines 93..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (this.isHorizontal()) {
                  this.width = this.maxWidth;
                  this.left = this._margins.left;
                  this.right = this.width;
                } else {
            Severity: Minor
            Found in src/plugins/plugin.legend.js and 1 other location - About 50 mins to fix
            src/plugins/plugin.legend.js on lines 97..101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status