Showing 57 of 91 total issues
Method parse_coords
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse_coords
coords = []
x = @tokenizer_structure.get_next_token
y = @tokenizer_structure.get_next_token
Method as_georss
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def as_georss(options = {})
dialect = options[:dialect] || :simple
case (dialect)
when :simple
geom_attr = ''
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method as_georss
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def as_georss(options = {})
dialect = options[:dialect] || :simple
case (dialect)
when :simple
geom_attr = ''
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_geometry
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse_geometry
@unpack_structure.endianness = @unpack_structure.read_byte
geometry_type = @unpack_structure.read_uint
if (geometry_type & Z_MASK) != 0
Method commit_add
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
def commit_add(index)
max_x, min_x, max_y, min_y, max_z, min_z, max_m, min_m = @shp.xmax, @shp.xmin, @shp.ymax, @shp.ymin, @shp.zmax, @shp.zmin, @shp.mmax, @shp.mmin
@added.each do |record|
@dbf_io << ['20'].pack('H2')
@dbf.fields.each do |field|
Method commit_delete
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def commit_delete
@shp_r.rewind
header = @shp_r.read(100)
@shp_io << header
@shx_io << header
Method parse
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def parse(kml)
@factory.reset
@with_z = false
@parser = REXML::Parsers::PullParser.new(kml)
while @parser.has_next?
Method bounding_box
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def bounding_box
max_x, min_x, max_y, min_y = -Float::MAX, Float::MAX, -Float::MAX, Float::MAX
if with_z
max_z, min_z = -Float::MAX, Float::MAX
each do |geometry|
Method build_polygon
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
def build_polygon(geometry, str)
if geometry.is_a? GeoRuby::SimpleFeatures::Polygon
str << [geometry.length,
geometry.reduce(0) { |a, e| a + e.length }
].pack('V2')
Method commit_finalize
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
def commit_finalize(min_x, max_x, min_y, max_y, min_z, max_z, min_m, max_m)
Method set_x_y_z
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def set_x_y_z(x, y, z)
@x = x && !x.is_a?(Numeric) ? x.to_f : x
@y = y && !y.is_a?(Numeric) ? y.to_f : y
@z = z && !z.is_a?(Numeric) ? z.to_f : z
self
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
elsif gml =~ /^<\s*[^:>]*:Polygon\s*>/
if gml =~ /<\s*[^:>]*:posList\s*>([^<]*)/
xy = Regexp.last_match[1].split(' ')
@geometry = Polygon.new
linear_ring = LinearRing.new
Avoid deeply nested control flow statements. Open
if gml =~ /<\s*[^:>]*:posList\s*>([^<]*)/
xy = Regexp.last_match[1].split(' ')
@geometry = LineString.new
0.upto(xy.size / 2 - 1) do |index|
@geometry << Point.from_x_y(xy[index * 2 + 1].to_f,
Method m_range
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def m_range
if with_m
max_m, min_m = -Float::MAX, Float::MAX
each do |lr|
lrmr = lr.m_range
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method theta_rad
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def theta_rad
if @x.zero?
@y < 0 ? 3 * HALFPI : HALFPI
else
th = Math.atan(@y / @x)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_next_token
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def check_next_token
check = @scanner.check(@regex)
if check.nil?
if @scanner.eos?
nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method bounding_box
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def bounding_box
if !with_z
@rings[0].bounding_box
else
result = @rings[0].bounding_box # valid for x and y
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method m_range
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def m_range
if with_m
max_m, min_m = -Float::MAX, Float::MAX
each do |lr|
lrmr = lr.m_range
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method ==
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def ==(other)
if other.class != self.class ||
other.length != length
false
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if (e[0] == 'coordinates')
parse_coordinates(@buffer)
@buffer = '' # clear the buffer
end