# nofxx/georuby

### Showing 91 of 91 total issues

#### Method `parse_geometry` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open

``````      def parse_geometry(srid_allowed)
token = @tokenizer_structure.get_next_token
if token == 'SRID'
# SRID present
fail EWKTFormatError.new('SRID not allowed at this position') unless srid_allowed``````
Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method `ellipsoidal_distance` has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def ellipsoidal_distance(point, a = 6_378_137.0, b = 6_356_752.3142)
f = (a - b) / a
l = (point.lon - lon) * DEG2RAD

u1 = Math.atan((1 - f) * Math.tan(lat * DEG2RAD))``````
Found in lib/geo_ruby/simple_features/point.rb - About 1 hr to fix

#### Method `parse_coords` has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def parse_coords
coords = []
x = @tokenizer_structure.get_next_token
y = @tokenizer_structure.get_next_token

``````
Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 1 hr to fix

#### Method `as_georss` has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open

``````      def as_georss(options = {})
dialect = options[:dialect] || :simple
case (dialect)
when :simple
geom_attr = ''``````
Found in lib/geo_ruby/simple_features/geometry.rb - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method `as_georss` has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open

``````      def as_georss(options = {})
dialect = options[:dialect] || :simple
case (dialect)
when :simple
geom_attr = ''``````
Found in lib/geo_ruby/simple_features/envelope.rb - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method `parse_geometry` has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def parse_geometry

if (geometry_type & Z_MASK) != 0``````
Found in lib/geo_ruby/ewk/ewkb_parser.rb - About 1 hr to fix

#### Method `commit_add` has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def commit_add(index)
max_x, min_x, max_y, min_y, max_z, min_z, max_m, min_m = @shp.xmax, @shp.xmin, @shp.ymax, @shp.ymin, @shp.zmax, @shp.zmin, @shp.mmax, @shp.mmin
@dbf_io << ['20'].pack('H2')
@dbf.fields.each do |field|``````
Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

#### Method `commit_delete` has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def commit_delete
@shp_r.rewind
Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````          str << [geometry.length,
geometry.reduce(0) { |a, e| a + e.length }
].pack('V2')
# last element of the previous array is dropped
str << geometry.reduce([0]) do |a, e|``````
Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 1 hr to fix
lib/geo_ruby/shp4r/shp.rb on lines 614..620

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

``````          str << [geometry.length, geometry.reduce(0) { |a, e| a + e.length }].pack('V2')
str << geometry.reduce([0]) do |a, e|
a << (a.last + e.length) # last element of the previous array is dropped
end.pack("V#{geometry.length}")
geometry.each do |ls|``````
Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 1 hr to fix
lib/geo_ruby/shp4r/shp.rb on lines 646..655

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Method `parse` has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````    def parse(kml)
@factory.reset
@with_z = false
@parser = REXML::Parsers::PullParser.new(kml)
while @parser.has_next?``````
Found in lib/geo_ruby/kml.rb - About 1 hr to fix

#### Method `bounding_box` has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def bounding_box
max_x, min_x, max_y, min_y = -Float::MAX, Float::MAX, -Float::MAX, Float::MAX
if with_z
max_z, min_z = -Float::MAX, Float::MAX
each do |geometry|``````
Found in lib/geo_ruby/simple_features/geometry_collection.rb - About 1 hr to fix

#### Method `build_polygon` has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````      def build_polygon(geometry, str)
if geometry.is_a? GeoRuby::SimpleFeatures::Polygon
str << [geometry.length,
geometry.reduce(0) { |a, e| a + e.length }
].pack('V2')``````
Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

``````      def m_range
if with_m
max_m, min_m = -Float::MAX, Float::MAX
each do |lr|
lrmr = lr.m_range``````
Found in lib/geo_ruby/simple_features/polygon.rb and 1 other location - About 1 hr to fix
lib/geo_ruby/simple_features/geometry_collection.rb on lines 52..62

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

``````      def m_range
if with_m
max_m, min_m = -Float::MAX, Float::MAX
each do |lr|
lrmr = lr.m_range``````
Found in lib/geo_ruby/simple_features/geometry_collection.rb and 1 other location - About 1 hr to fix
lib/geo_ruby/simple_features/polygon.rb on lines 41..51

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

## Refactorings

#### Method `commit_finalize` has 8 arguments (exceeds 4 allowed). Consider refactoring. Open

``      def commit_finalize(min_x, max_x, min_y, max_y, min_z, max_z, min_m, max_m)``
Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

#### Method `==` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

``````      def ==(other)
if (other.class != self.class)
false
elsif length != other.length
false``````
Found in lib/geo_ruby/simple_features/geometry_collection.rb - About 45 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method `initialize` has 6 arguments (exceeds 4 allowed). Consider refactoring. Open

``        def initialize(name, type, length, decimal = 0, version = 1, enc = nil)``
Found in lib/geo_ruby/shp4r/dbf.rb - About 45 mins to fix

#### Avoid deeply nested control flow statements. Open

``````            if (e[0] == 'coordinates')
parse_coordinates(@buffer)
@buffer = '' # clear the buffer
end``````
Found in lib/geo_ruby/kml.rb - About 45 mins to fix

#### Method `parse_multi_point` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

``````      def parse_multi_point
if @tokenizer_structure.get_next_token != '('
fail EWKTFormatError.new('Invalid MultiPoint')
end

``````
Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 45 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"