nofxx/georuby

View on GitHub

Showing 91 of 91 total issues

Method m_range has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def m_range
        if with_m
          max_m, min_m = -Float::MAX, Float::MAX
          each do |lr|
            lrmr = lr.m_range
Severity: Minor
Found in lib/geo_ruby/simple_features/polygon.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method theta_rad has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def theta_rad
        if @x.zero?
          @y < 0 ? 3 * HALFPI : HALFPI
        else
          th = Math.atan(@y / @x)
Severity: Minor
Found in lib/geo_ruby/simple_features/point.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_x_y_z has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def set_x_y_z(x, y, z)
        @x = x && !x.is_a?(Numeric) ? x.to_f : x
        @y = y && !y.is_a?(Numeric) ? y.to_f : y
        @z = z && !z.is_a?(Numeric) ? z.to_f : z
        self
Severity: Minor
Found in lib/geo_ruby/simple_features/point.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

          if gml =~ /<\s*[^:>]*:posList\s*>([^<]*)/
            xy = Regexp.last_match[1].split(' ')
            @geometry = LineString.new
            0.upto(xy.size / 2 - 1) do |index|
              @geometry << Point.from_x_y(xy[index * 2 + 1].to_f,
Severity: Major
Found in lib/geo_ruby/georss.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

            elsif gml =~ /^<\s*[^:>]*:Polygon\s*>/
              if gml =~ /<\s*[^:>]*:posList\s*>([^<]*)/
                xy = Regexp.last_match[1].split(' ')
                @geometry = Polygon.new
                linear_ring = LinearRing.new
    Severity: Major
    Found in lib/geo_ruby/georss.rb - About 45 mins to fix

      Method m_range has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def m_range
              if with_m
                max_m, min_m = -Float::MAX, Float::MAX
                each do |point|
                  max_m = point.m if point.m.to_f > max_m
      Severity: Minor
      Found in lib/geo_ruby/simple_features/line_string.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method == has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def ==(other_polygon)
              if other_polygon.class != self.class ||
                 length != other_polygon.length
                false
              else
      Severity: Minor
      Found in lib/geo_ruby/simple_features/polygon.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method bounding_box has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def bounding_box
              if !with_z
                @rings[0].bounding_box
              else
                result = @rings[0].bounding_box # valid for x and y
      Severity: Minor
      Found in lib/geo_ruby/simple_features/polygon.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method commit_delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def commit_delete
              @shp_r.rewind
              header = @shp_r.read(100)
              @shp_io << header
              @shx_io << header
      Severity: Minor
      Found in lib/geo_ruby/shp4r/shp.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method m_range has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def m_range
              if with_m
                max_m, min_m = -Float::MAX, Float::MAX
                each do |lr|
                  lrmr = lr.m_range
      Severity: Minor
      Found in lib/geo_ruby/simple_features/geometry_collection.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method == has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def ==(other)
              if other.class != self.class ||
                 other.length != length
                false
              else
      Severity: Minor
      Found in lib/geo_ruby/simple_features/line_string.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_next_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def check_next_token
              check = @scanner.check(@regex)
              if check.nil?
                if @scanner.eos?
                  nil
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_next_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def get_next_token
              if @scanner.scan(@regex).nil?
                if @scanner.eos?
                  nil
                else
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def parse_multi_polygon
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid MultiLineString')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb and 2 other locations - About 40 mins to fix
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 114..130
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 133..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def parse_multi_line_string
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid MultiLineString')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb and 2 other locations - About 40 mins to fix
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 96..111
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 133..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def parse_polygon
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid Polygon')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb and 2 other locations - About 40 mins to fix
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 96..111
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 114..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method from_x_y_z_m has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def self.from_x_y_z_m(x, y, z, m, srid = DEFAULT_SRID)
      Severity: Minor
      Found in lib/geo_ruby/simple_features/point.rb - About 35 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                when ShpType::POLYLINEZ
                  str, bbox = create_bbox(geometry)
                  m_range = geometry.m_range
                  build_polyline(geometry, str)
                  build_polyline_zm(geometry, :@z, [bbox[0].z, bbox[1].z], str)
        Severity: Minor
        Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 35 mins to fix
        lib/geo_ruby/shp4r/shp.rb on lines 566..571
        lib/geo_ruby/shp4r/shp.rb on lines 572..577

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                when ShpType::POLYGONZ
                  str, bbox = create_bbox(geometry)
                  m_range = geometry.m_range
                  build_polygon(geometry, str)
                  build_polygon_zm(geometry, :@z, [bbox[0].z, bbox[1].z], str)
        Severity: Minor
        Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 35 mins to fix
        lib/geo_ruby/shp4r/shp.rb on lines 560..565
        lib/geo_ruby/shp4r/shp.rb on lines 572..577

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                when ShpType::MULTIPOINTZ
                  str, bbox = create_bbox(geometry)
                  m_range = geometry.m_range
                  build_multi_point(geometry, str)
                  build_multi_point_zm(geometry, :@z, [bbox[0].z, bbox[1].z], str)
        Severity: Minor
        Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 35 mins to fix
        lib/geo_ruby/shp4r/shp.rb on lines 560..565
        lib/geo_ruby/shp4r/shp.rb on lines 566..571

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language