nofxx/georuby

View on GitHub
lib/geo_ruby/ewk/ewkt_parser.rb

Summary

Maintainability
C
1 day
Test Coverage

Method parse_coords has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

      def parse_coords
        coords = []
        x = @tokenizer_structure.get_next_token
        y = @tokenizer_structure.get_next_token

Severity: Minor
Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ewkt_parser.rb has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'strscan'

module GeoRuby
  module SimpleFeatures
    # Raised when an error in the EWKT string is detected
Severity: Minor
Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 2 hrs to fix

    Method parse_geometry has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse_geometry(srid_allowed)
            token = @tokenizer_structure.get_next_token
            if token == 'SRID'
              # SRID present
              fail EWKTFormatError.new('SRID not allowed at this position') unless srid_allowed
    Severity: Minor
    Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse_coords has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def parse_coords
            coords = []
            x = @tokenizer_structure.get_next_token
            y = @tokenizer_structure.get_next_token
    
    
    Severity: Minor
    Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 1 hr to fix

      Method check_next_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def check_next_token
              check = @scanner.check(@regex)
              if check.nil?
                if @scanner.eos?
                  nil
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parse_multi_point has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse_multi_point
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid MultiPoint')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_next_token has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def get_next_token
              if @scanner.scan(@regex).nil?
                if @scanner.eos?
                  nil
                else
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def parse_polygon
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid Polygon')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb and 2 other locations - About 40 mins to fix
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 96..111
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 114..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def parse_multi_polygon
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid MultiLineString')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb and 2 other locations - About 40 mins to fix
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 114..130
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 133..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            def parse_multi_line_string
              if @tokenizer_structure.get_next_token != '('
                fail EWKTFormatError.new('Invalid MultiLineString')
              end
      
      
      Severity: Minor
      Found in lib/geo_ruby/ewk/ewkt_parser.rb and 2 other locations - About 40 mins to fix
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 96..111
      lib/geo_ruby/ewk/ewkt_parser.rb on lines 133..149

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status