nponiros/sync_client

View on GitHub

Showing 11 of 11 total issues

Function initSync has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function initSync(serverComm, isOnline) {
  return function sync(
    context,
    url,
    options,
Severity: Major
Found in src/poll_sync_protocol.js - About 2 hrs to fix

    Function sync has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      return function sync(
        context,
        url,
        options,
        baseRevision,
    Severity: Minor
    Found in src/poll_sync_protocol.js - About 1 hr to fix

      Function initConnectionStatus has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export default function initConnectionStatus(global) {
        function checkServerConnection(url) {
          return global.fetch(url, { method: 'HEAD' });
        }
      
      
      Severity: Minor
      Found in src/connection_status.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          module: {
            rules: [
              {
                test: /\.js$/,
                exclude: /node_modules/,
        Severity: Major
        Found in webpack.prod.config.js and 1 other location - About 1 hr to fix
        webpack.dev.config.js on lines 13..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          module: {
            rules: [
              {
                test: /\.js$/,
                exclude: /node_modules/,
        Severity: Major
        Found in webpack.dev.config.js and 1 other location - About 1 hr to fix
        webpack.prod.config.js on lines 13..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                          .then(() => {
                            applyRemoteChanges(data.changes, data.currentRevision, data.partial, false);
                            onChangesAccepted();
                            onSuccess({ again: options.pollInterval });
                          }).catch((e) => {
        Severity: Minor
        Found in src/poll_sync_protocol.js and 1 other location - About 40 mins to fix
        src/poll_sync_protocol.js on lines 50..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    } else {
                      applyRemoteChanges(data.changes, data.currentRevision, data.partial, false);
                      onChangesAccepted();
                      onSuccess({ again: options.pollInterval });
                    }
        Severity: Minor
        Found in src/poll_sync_protocol.js and 1 other location - About 40 mins to fix
        src/poll_sync_protocol.js on lines 39..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function initConnectionStatus has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        export default function initConnectionStatus(global) {
          function checkServerConnection(url) {
            return global.fetch(url, { method: 'HEAD' });
          }
        
        
        Severity: Minor
        Found in src/connection_status.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Import in body of module; reorder to top.
        Open

        import initSyncClient from './sync_client';
        Severity: Minor
        Found in src/index.js by eslint

        For more information visit Source: http://eslint.org/docs/rules/

        Unexpected literal in error position of callback.
        Open

              cb(false);
        Severity: Minor
        Found in src/connection_status.js by eslint

        For more information visit Source: http://eslint.org/docs/rules/

        TODO found
        Open

        ## TODO
        Severity: Minor
        Found in README.md by fixme
        Severity
        Category
        Status
        Source
        Language