nukeop/nuclear

View on GitHub
packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx

Summary

Maintainability
F
5 days
Test Coverage

File AlbumViewContainer.test.tsx has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { waitFor } from '@testing-library/react';
import { mountedComponentFactory, setupI18Next } from '../../../test/testUtils';
import { buildStoreState } from '../../../test/storeBuilders';
import PlayerBarContainer from '../PlayerBarContainer';
import userEvent from '@testing-library/user-event';

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should remove album from favorites after clicking the star if already in favorites', async () => {
        const { component, store } = mountComponent();
        let state = store.getState();
        expect(state.favorites.albums).toEqual([]);
    
    
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 200..217

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 222.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should add album to favorites after clicking the star', async () => {
        const { component, store } = mountComponent();
        let state = store.getState();
        expect(state.favorites.albums).toEqual([]);
    
    
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 184..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 157.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should add a single track to queue after clicking the button in the popup', async () => {
        const { component, store } = mountComponent();
    
        await waitFor(() => component.getAllByTestId('track-popup-trigger')[0].click());
        await waitFor(() => component.getByText(/add to queue/i).click());
    packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 155..167

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 150.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      it('should search for artist after clicking his name', async () => {
        const { component, history } = mountComponent();
        expect(history.location.pathname).toBe('/album/test-album-id');
        await waitFor(() => component.getByText(/test artist/i).click());
        expect(history.location.pathname).toBe('/artist/test-artist-id');
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 37..42
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 44..49
    packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 75..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 107.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should show that an album is still loading', () => {
        const { component } = mountComponent(
          buildStoreState()
            .withPlugins()
            .withAlbumDetails({ ['test-album-id']: { loading: true } })
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 26..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        expect(state?.queue?.queueItems).toEqual([
          expect.objectContaining({
            artist: 'test artist',
            name: 'test track 1'
          }),
    packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 152..165
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 168..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        expect(state?.queue?.queueItems).toEqual([
          expect.objectContaining({
            artist: 'test artist',
            name: 'test track 1'
          }),
    packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 175..188
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 168..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 84.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        expect(state.queue.queueItems).toEqual([
          expect.objectContaining({
            artist: 'test artist',
            name: 'test track 2'
          }),
    packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 247..256
    packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 35..44
    packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 54..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(state.downloads).toEqual([
          {
            completion: 0,
            status: 'Waiting',
            track: expect.objectContaining({
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 117..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        buildStoreState()
          .withAlbumDetails()
          .withArtistDetails()
          .withPlugins()
          .withConnectivity()
    packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 267..273

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 16 locations. Consider refactoring.
    Open

      it('should display an album', () => {
        const { component } = mountComponent();
        expect(component.asFragment()).toMatchSnapshot();
      });
    packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
    packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
    packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
    packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
    packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
    packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
    packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
    packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 25..28
    packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 39..42
    packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
    packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
    packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
    packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
    packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
    packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(firstPlaylist.tracks).toEqual([
          expect.objectContaining({ uuid: 'track-1-id' }),
          expect.objectContaining({ uuid: 'track-2-id' }),
          expect.objectContaining({ uuid: 'track-3-id' })
        ]);
    packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 276..280

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(state.playlists.localPlaylists.data[0].tracks).toEqual([
          expect.objectContaining({ uuid: 'track-1-id' }),
          expect.objectContaining({ uuid: 'track-2-id' }),
          expect.objectContaining({ uuid: 'track-3-id' })
        ]);
    packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 300..304

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status