Sign upLogin

nukeop/nuclear

View on GitHub
Star
packages/app/app/containers/PlayerBarContainer/hooks.ts

Summary

Maintainability
D
1 day
Test Coverage

Function useVolumeControlsProps has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useVolumeControlsProps = () => {
  const { t } = useTranslation('option-control');
  const dispatch = useDispatch();
  const volume: number = useSelector(playerSelectors.volume);
  const isMuted: boolean = useSelector(playerSelectors.muted);
Severity: Major
Found in packages/app/app/containers/PlayerBarContainer/hooks.ts - About 2 hrs to fix

    File hooks.ts has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { useCallback, useEffect } from 'react';
import Sound from 'react-hifi';
import { useTranslation } from 'react-i18next';
import { useDispatch, useSelector } from 'react-redux';
import { useHistory } from 'react-router-dom';
    Severity: Minor
    Found in packages/app/app/containers/PlayerBarContainer/hooks.ts - About 2 hrs to fix

      Function usePlayerControlsProps has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const usePlayerControlsProps = () => {
  const dispatch = useDispatch();
  const queue = useSelector(queueSelector);
  const settings = useSelector(settingsSelector);
  const playbackStatus = useSelector(playerSelectors.playbackStatus);
      Severity: Minor
      Found in packages/app/app/containers/PlayerBarContainer/hooks.ts - About 1 hr to fix

        Function useTrackInfoProps has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const useTrackInfoProps = () => {
  const dispatch = useDispatch();
  const history = useHistory();
  const queue = useSelector(queueSelector);
  const hasTracks = queue.queueItems.length > 0;
        Severity: Minor
        Found in packages/app/app/containers/PlayerBarContainer/hooks.ts - About 1 hr to fix

          Function usePlayerControlsProps has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          export const usePlayerControlsProps = () => {
  const dispatch = useDispatch();
  const queue = useSelector(queueSelector);
  const settings = useSelector(settingsSelector);
  const playbackStatus = useSelector(playerSelectors.playbackStatus);
          Severity: Minor
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              {
      name: t('shuffle'),
      dataTestId: 'shuffle-play-option',
      icon: 'random' as SemanticICONS,
      enabled: _.get(settings, 'shuffleQueue'),
          Severity: Major
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts and 4 other locations - About 50 mins to fix
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 188..194
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 195..201
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 209..215
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 216..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              {
      name: t('mini-player'),
      dataTestId: 'mini-player-play-option',
      icon: 'compress' as SemanticICONS,
      enabled: _.get(settings, 'miniPlayer'),
          Severity: Major
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts and 4 other locations - About 50 mins to fix
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 188..194
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 195..201
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 202..208
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 209..215

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              {
      name: t('autoradio'),
      dataTestId: 'autoradio-play-option',
      icon: 'magic' as SemanticICONS,
      enabled: _.get(settings, 'autoradio'),
          Severity: Major
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts and 4 other locations - About 50 mins to fix
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 188..194
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 195..201
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 202..208
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 216..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              {
      name: t('rate'),
      dataTestId: 'rate-play-option',
      icon: 'heartbeat' as SemanticICONS,
      enabled: _.get(settings, 'rate'),
          Severity: Major
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts and 4 other locations - About 50 mins to fix
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 195..201
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 202..208
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 209..215
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 216..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

              {
      name: t('loop'),
      dataTestId: 'loop-play-option',
      icon: 'repeat' as SemanticICONS,
      enabled: _.get(settings, 'loopAfterQueueEnd'),
          Severity: Major
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts and 4 other locations - About 50 mins to fix
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 188..194
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 202..208
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 209..215
          packages/app/app/containers/PlayerBarContainer/hooks.ts on lines 216..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            return {
    track,
    artist,
    onTrackClick,
    onArtistClick,
          Severity: Minor
          Found in packages/app/app/containers/PlayerBarContainer/hooks.ts and 1 other location - About 35 mins to fix
          packages/ui/lib/components/StreamVerification/index.tsx on lines 28..38

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status