nukeop/nuclear

View on GitHub
packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx

Summary

Maintainability
F
3 days
Test Coverage

File PlaylistViewContainer.test.tsx has 273 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable @typescript-eslint/no-var-requires */
/* eslint-disable @typescript-eslint/ban-ts-comment */
import { fireEvent, render, waitFor } from '@testing-library/react';
import React from 'react';
import { createMemoryHistory } from 'history';

    Function mountComponent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const mountComponent = (initialStore?: AnyProps, initStore = true) => {
        const initialState = initialStore ||
          buildStoreState()
            .withPlugins()
            .withPlaylists()

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const mountComponent = (initialStore?: AnyProps, initStore = true) => {
          const initialState = initialStore ||
            buildStoreState()
              .withPlugins()
              .withPlaylists()
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 228..258

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 215.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        it('should add a single track to favorites', async () => {
          const { component, store } = mountComponent();
          await waitFor(() => component.getAllByTestId('track-popup-trigger')[1].click());
          await waitFor(() => component.getByText(/add to favorites/i).click());
      
      
      packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 41..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 150.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          expect(state.queue.queueItems).toEqual([
            expect.objectContaining({
              artist: 'test artist 1',
              name: 'test track'
            }),
      packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 81..90
      packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 247..256
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 54..63

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          expect(state.queue.queueItems).toEqual([
            expect.objectContaining({
              artist: 'test artist 1',
              name: 'test track'
            }),
      packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 81..90
      packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 247..256
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 35..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data[0].tracks).toEqual([
            expect.objectContaining({
              artist: 'test artist 2',
              name: 'test track 22'
            })
      packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 138..143
      packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 160..165

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          expect(state.playlists.localPlaylists.data[0].tracks).toEqual([
            expect.objectContaining({
              uuid: 'test-track-uuid-1',
              artist: 'test artist 1',
              name: 'test track 1'
      packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 155..166

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 16 locations. Consider refactoring.
      Open

        it('should display a playlist', () => {
          const { component } = mountComponent();
          expect(component.asFragment()).toMatchSnapshot();
        });
      packages/app/app/containers/AlbumViewContainer/AlbumViewContainer.test.tsx on lines 18..21
      packages/app/app/containers/ArtistViewContainer/ArtistViewContainer.test.tsx on lines 21..24
      packages/app/app/containers/DashboardContainer/DashboardContainer.test.tsx on lines 90..93
      packages/app/app/containers/DownloadsContainer/DownloadsContainer.test.tsx on lines 25..28
      packages/app/app/containers/FavoritesContainer/FavoritesContainer.albums.test.tsx on lines 37..40
      packages/app/app/containers/FavoritesContainer/FavoritesContainer.tracks.test.tsx on lines 40..43
      packages/app/app/containers/LibraryViewContainer/LibraryViewContainer.test.tsx on lines 22..26
      packages/app/app/containers/PlayQueueContainer/PlayQueueContainer.test.tsx on lines 33..36
      packages/app/app/containers/PlaylistsContainer/PlaylistsContainer.test.tsx on lines 39..42
      packages/app/app/containers/PluginsContainer/PluginsContainer.test.tsx on lines 17..20
      packages/app/app/containers/SearchBoxContainer/SearchBoxContainer.test.tsx on lines 16..20
      packages/app/app/containers/SearchResultsContainer/SearchResultsContainer.test.tsx on lines 20..23
      packages/app/app/containers/SettingsContainer/SettingsContainer.test.tsx on lines 32..35
      packages/app/app/containers/StreamVerificationContainer/StreamVerificationContainer.test.tsx on lines 20..23
      packages/app/app/containers/UserPanelContainer/UserPanelContainer.test.tsx on lines 24..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        it('should reorder tracks correctly (3)', () => {
          reorder(0, 1);
          expect(newPlaylist).toEqual({
            tracks: [2, 1, 3, 4]
          });
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 300..305
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 307..312

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        it('should reorder tracks correctly (1)', () => {
          reorder(0, 2);
          expect(newPlaylist).toEqual({
            tracks: [2, 3, 1, 4]
          });
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 307..312
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 314..319

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        it('should reorder tracks correctly (2)', () => {
          reorder(1, 3);
          expect(newPlaylist).toEqual({
            tracks: [1, 3, 4, 2]
          });
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 300..305
      packages/app/app/containers/PlaylistViewContainer/PlaylistViewContainer.test.tsx on lines 314..319

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status