nukeop/nuclear

File discogs.ts has 267 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import _ from 'lodash';

import MetaProvider from '../metaProvider';
import * as Discogs from '../../rest/Discogs';
import LastFmApi from '../../rest/Lastfm';

Function fetchArtistDetails has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  async fetchArtistDetails(artistId: string): Promise<ArtistDetails> {
    const discogsInfo: DiscogsArtistInfo = await (await Discogs.artistInfo(artistId)).json();
    discogsInfo.name = cleanName(discogsInfo.name);

    const lastFmInfo: LastFmArtistInfo = (await (await this.lastfm.getArtistInfo(discogsInfo.name)).json()).artist;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  searchForArtists(query: string): Promise<Array<SearchResultsArtist>> {
    return Discogs.search(query, 'artist')
      .then(response => response.json())
      .then((json: DiscogsArtistSearchResponse) => json.results.map(this.discogsArtistSearchResultToGeneric));
  }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  searchForReleases(query: string): Promise<Array<SearchResultsAlbum>> {
    return Discogs.search(query, 'master')
      .then(response => response.json())
      .then((json: DiscogsReleaseSearchResponse) => json.results.map(this.discogsReleaseSearchResultToGeneric));
  }

• Read up
  Read up