oauth-xx/oauth2

View on GitHub

Showing 6 of 6 total issues

Method request has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def request(verb, url, opts = {}) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/AbcSize
      url = connection.build_url(url).to_s

      begin
        response = connection.run_request(verb, url, opts[:body], opts[:headers]) do |req|
Severity: Minor
Found in lib/oauth2/client.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def request(verb, url, opts = {}) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/AbcSize
      url = connection.build_url(url).to_s

      begin
        response = connection.run_request(verb, url, opts[:body], opts[:headers]) do |req|
Severity: Minor
Found in lib/oauth2/client.rb - About 1 hr to fix

    Method get_token has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_token(params, access_token_opts = {}, access_token_class = AccessToken) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
          # if ruby version >= 2.4
          # params.transform_keys! do |key|
          #   RESERVED_PARAM_KEYS.include?(key) ? key.to_sym : key
          # end
    Severity: Minor
    Found in lib/oauth2/client.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_token has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_token(params, access_token_opts = {}, access_token_class = AccessToken) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
          # if ruby version >= 2.4
          # params.transform_keys! do |key|
          #   RESERVED_PARAM_KEYS.include?(key) ? key.to_sym : key
          # end
    Severity: Minor
    Found in lib/oauth2/client.rb - About 1 hr to fix

      Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(client, token, opts = {}) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
            @client = client
            @token = token.to_s
            opts = opts.dup
            %i[refresh_token expires_in expires_at expires_latency].each do |arg|
      Severity: Minor
      Found in lib/oauth2/access_token.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method configure_authentication! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def configure_authentication!(opts) # rubocop:disable Metrics/AbcSize
            case options[:mode]
            when :header
              opts[:headers] ||= {}
              opts[:headers].merge!(headers)
      Severity: Minor
      Found in lib/oauth2/access_token.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language