Sign upLogin

oglimmer/citybuilder

View on GitHub
Star

Showing 75 of 157 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function BuildGroceriesSmCard(id) {
    this.Inherits(BuildGroceriesCard,id,100,3,[ {ht:[1,4], pro:100}, {ht:[5,8], pro:20}, {ht:[9,10], pro:2} ], 0);
}
Severity: Major
Found in server/cards/card_groceriescards.js and 5 other locations - About 2 hrs to fix
server/cards/card_clothingcards.js on lines 35..37
server/cards/card_clothingcards.js on lines 67..69
server/cards/card_electroniccards.js on lines 19..21
server/cards/card_groceriescards.js on lines 51..53
server/cards/card_jewelerycards.js on lines 27..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function BuildElectronicSmlCard(id) {
    this.Inherits(BuildElectronicCard,id,400,1,[ {ht:[1,5], pro:300}, {ht:[6,7], pro:170},{ht:[8,10], pro:50} ], 0);
}
Severity: Major
Found in server/cards/card_electroniccards.js and 5 other locations - About 2 hrs to fix
server/cards/card_clothingcards.js on lines 35..37
server/cards/card_clothingcards.js on lines 67..69
server/cards/card_groceriescards.js on lines 19..21
server/cards/card_groceriescards.js on lines 51..53
server/cards/card_jewelerycards.js on lines 27..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function BuildJeweleryMidCard(id) {
    this.Inherits(BuildJeweleryCard,id,301,2,[ {ht:[1,3], pro:150}, {ht:[4,6], pro:60}, {ht:[7,8], pro:20} ], 0);
}
Severity: Major
Found in server/cards/card_jewelerycards.js and 5 other locations - About 2 hrs to fix
server/cards/card_clothingcards.js on lines 35..37
server/cards/card_clothingcards.js on lines 67..69
server/cards/card_electroniccards.js on lines 19..21
server/cards/card_groceriescards.js on lines 19..21
server/cards/card_groceriescards.js on lines 51..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function BuildGroceriesSuperMartCard(id) {
    this.Inherits(BuildGroceriesCard,id,104,3,[ {ht:[1,4], pro:100}, {ht:[5,7], pro:35}, {ht:[8,10], pro:10} ], 0);
}
Severity: Major
Found in server/cards/card_groceriescards.js and 5 other locations - About 2 hrs to fix
server/cards/card_clothingcards.js on lines 35..37
server/cards/card_clothingcards.js on lines 67..69
server/cards/card_electroniccards.js on lines 19..21
server/cards/card_groceriescards.js on lines 19..21
server/cards/card_jewelerycards.js on lines 27..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function BuildClothingFatCard(id) {
    this.Inherits(BuildClothingCard,id,206,2,[ {ht:[2,3], pro:150}, {ht:[4,7], pro:45}, {ht:[8,10], pro:7} ], 0);
}
Severity: Major
Found in server/cards/card_clothingcards.js and 5 other locations - About 2 hrs to fix
server/cards/card_clothingcards.js on lines 35..37
server/cards/card_electroniccards.js on lines 19..21
server/cards/card_groceriescards.js on lines 19..21
server/cards/card_groceriescards.js on lines 51..53
server/cards/card_jewelerycards.js on lines 27..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

function BuildClothingCheapLrgCard(id) {
    this.Inherits(BuildClothingCard,id,202,3,[ {ht:[4,6], pro:30}, {ht:[7,8], pro:10}, {ht:[9,10], pro:5} ], 0);
}
Severity: Major
Found in server/cards/card_clothingcards.js and 5 other locations - About 2 hrs to fix
server/cards/card_clothingcards.js on lines 67..69
server/cards/card_electroniccards.js on lines 19..21
server/cards/card_groceriescards.js on lines 19..21
server/cards/card_groceriescards.js on lines 51..53
server/cards/card_jewelerycards.js on lines 27..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Function.prototype.Inherits = function(parent) {
    this.prototype = new parent();
    this.prototype.constructor = this;
    this.prototype.parent = parent.prototype;
};
Severity: Major
Found in client/game/global_scope.js and 1 other location - About 1 hr to fix
client/game/general.js on lines 9..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Function.prototype.Inherits = function(parent) {
    this.prototype = new parent();
    this.prototype.constructor = this;
    this.prototype.parent = parent.prototype;
};
Severity: Major
Found in client/game/general.js and 1 other location - About 1 hr to fix
client/game/global_scope.js on lines 2..6

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

AddCriminals3Card.prototype.play = function(field, player) {
    if(field.attachedCard.houseType > 4) {
        throw "error_housetype_too_low";
    }
    return this.parent.play.apply(this, arguments);
Severity: Major
Found in server/cards/card_criminalcards.js and 2 other locations - About 1 hr to fix
server/cards/card_criminalcards.js on lines 32..37
server/cards/card_criminalcards.js on lines 56..61

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

AddCriminals2Card.prototype.play = function(field, player) {
    if(field.attachedCard.houseType < 7) {
        throw "error_housetype_too_low";
    }
    return this.parent.play.apply(this, arguments);
Severity: Major
Found in server/cards/card_criminalcards.js and 2 other locations - About 1 hr to fix
server/cards/card_criminalcards.js on lines 32..37
server/cards/card_criminalcards.js on lines 80..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

AddCriminals1Card.prototype.play = function(field, player) {
    if(field.attachedCard.houseType < 9) {
        throw "error_housetype_too_low";
    }
    return this.parent.play.apply(this, arguments);
Severity: Major
Found in server/cards/card_criminalcards.js and 2 other locations - About 1 hr to fix
server/cards/card_criminalcards.js on lines 56..61
server/cards/card_criminalcards.js on lines 80..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(this.selectableType.match(/ALL_UNOCCUPIED_LOWER_/) !== null) {
            return field.type == 0 && field.attachedCard.houseType < this.selectableType.match(/[0-9].*$/);
        }
Severity: Major
Found in client/game/FieldPane.js and 1 other location - About 1 hr to fix
client/game/FieldPane.js on lines 36..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(typeof(this.range) !== 'undefined') {
            ctx.fillText("E:"+this.range, this.x+5, this.y+this.height-5);
        }
Severity: Major
Found in client/game/Card.js and 1 other location - About 1 hr to fix
client/game/Card.js on lines 188..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if(typeof(this.range) !== 'undefined') {
                ctx.fillText("E:"+this.range, this.x+5, this.y+this.height-5);
            }
Severity: Major
Found in client/game/Card.js and 1 other location - About 1 hr to fix
client/game/Card.js on lines 241..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if(this.selectableType.match(/ALL_UNOCCUPIED_ABOVE_/) !== null) {
            return field.type == 0 && field.attachedCard.houseType > this.selectableType.match(/[0-9].*$/);
        }
Severity: Major
Found in client/game/FieldPane.js and 1 other location - About 1 hr to fix
client/game/FieldPane.js on lines 39..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

function BuildRestaurantChinSmCard(id) {
    this.Inherits(BuildRestaurantCard,id,4,1,[ {ht:[3,6], pro:20}, {ht:[7,10], pro:10} ], 0);
}
Severity: Major
Found in server/cards/card_restaurantcards.js and 9 other locations - About 1 hr to fix
server/cards/card_clothingcards.js on lines 27..29
server/cards/card_clothingcards.js on lines 51..53
server/cards/card_clothingcards.js on lines 75..77
server/cards/card_groceriescards.js on lines 35..37
server/cards/card_groceriescards.js on lines 59..61
server/cards/card_jewelerycards.js on lines 19..21
server/cards/card_restaurantcards.js on lines 43..45
server/cards/card_restaurantcards.js on lines 83..85
server/cards/card_restaurantcards.js on lines 91..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

function BuildClothingCheapCard(id) {
    this.Inherits(BuildClothingCard,id,201,2,[ {ht:[5,7], pro:30}, {ht:[8,10], pro:10} ], 0);
}
Severity: Major
Found in server/cards/card_clothingcards.js and 9 other locations - About 1 hr to fix
server/cards/card_clothingcards.js on lines 51..53
server/cards/card_clothingcards.js on lines 75..77
server/cards/card_groceriescards.js on lines 35..37
server/cards/card_groceriescards.js on lines 59..61
server/cards/card_jewelerycards.js on lines 19..21
server/cards/card_restaurantcards.js on lines 43..45
server/cards/card_restaurantcards.js on lines 51..53
server/cards/card_restaurantcards.js on lines 83..85
server/cards/card_restaurantcards.js on lines 91..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

function BuildClothingRegLrgCard(id) {
    this.Inherits(BuildClothingCard,id,207,2,[ {ht:[2,4], pro:250}, {ht:[5,7], pro:30} ], 0);
}
Severity: Major
Found in server/cards/card_clothingcards.js and 9 other locations - About 1 hr to fix
server/cards/card_clothingcards.js on lines 27..29
server/cards/card_clothingcards.js on lines 51..53
server/cards/card_groceriescards.js on lines 35..37
server/cards/card_groceriescards.js on lines 59..61
server/cards/card_jewelerycards.js on lines 19..21
server/cards/card_restaurantcards.js on lines 43..45
server/cards/card_restaurantcards.js on lines 51..53
server/cards/card_restaurantcards.js on lines 83..85
server/cards/card_restaurantcards.js on lines 91..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

function BuildJeweleryCheapCard(id) {
    this.Inherits(BuildJeweleryCard,id,300,2,[ {ht:[5,8], pro:30}, {ht:[9,10], pro:10} ], 0);
}
Severity: Major
Found in server/cards/card_jewelerycards.js and 9 other locations - About 1 hr to fix
server/cards/card_clothingcards.js on lines 27..29
server/cards/card_clothingcards.js on lines 51..53
server/cards/card_clothingcards.js on lines 75..77
server/cards/card_groceriescards.js on lines 35..37
server/cards/card_groceriescards.js on lines 59..61
server/cards/card_restaurantcards.js on lines 43..45
server/cards/card_restaurantcards.js on lines 51..53
server/cards/card_restaurantcards.js on lines 83..85
server/cards/card_restaurantcards.js on lines 91..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

function BuildRestaurantGreekMidCard(id) {
    this.Inherits(BuildRestaurantCard,id,3,3,[ {ht:[1,5], pro:45}, {ht:[6,8], pro:15} ], 5);
}
Severity: Major
Found in server/cards/card_restaurantcards.js and 9 other locations - About 1 hr to fix
server/cards/card_clothingcards.js on lines 27..29
server/cards/card_clothingcards.js on lines 51..53
server/cards/card_clothingcards.js on lines 75..77
server/cards/card_groceriescards.js on lines 35..37
server/cards/card_groceriescards.js on lines 59..61
server/cards/card_jewelerycards.js on lines 19..21
server/cards/card_restaurantcards.js on lines 51..53
server/cards/card_restaurantcards.js on lines 83..85
server/cards/card_restaurantcards.js on lines 91..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language