Sign upLogin

oglimmer/citybuilder

View on GitHub
Star

Showing 157 of 157 total issues

Function onclick has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

UIElement.prototype.onclick = function(x, y) {
    if(this.atPos(x,y)) {
        if(G.fieldPane.selectTargetEnabled) {
            // this is a deploy
            if(G.fieldPane.isSelectable(this)) {
Severity: Minor
Found in client/game/UIElement.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return field.type == 0 && field.attachedCard.houseType < this.selectableType.match(/[0-9].*$/);
Severity: Major
Found in client/game/FieldPane.js - About 30 mins to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function BuildRestaurantItaMidCard(id) {
    this.Inherits(BuildRestaurantCard,id,1,2,[ {ht:[2,8], pro:30} ], 0);
}
    Severity: Major
    Found in server/cards/card_restaurantcards.js and 7 other locations - About 30 mins to fix
    server/cards/card_clothingcards.js on lines 59..61
    server/cards/card_groceriescards.js on lines 27..29
    server/cards/card_groceriescards.js on lines 43..45
    server/cards/card_restaurantcards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 59..61
    server/cards/card_restaurantcards.js on lines 67..69
    server/cards/card_restaurantcards.js on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function BuildGroceriesDisc1Card(id) {
    this.Inherits(BuildGroceriesCard,id,101,1,[ {ht:[1,10], pro:10} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 7 other locations - About 30 mins to fix
    server/cards/card_clothingcards.js on lines 59..61
    server/cards/card_groceriescards.js on lines 43..45
    server/cards/card_restaurantcards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 27..29
    server/cards/card_restaurantcards.js on lines 59..61
    server/cards/card_restaurantcards.js on lines 67..69
    server/cards/card_restaurantcards.js on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function BuildGroceriesDisc3Card(id) {
    this.Inherits(BuildGroceriesCard,id,103,1,[ {ht:[8,10], pro:15} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 7 other locations - About 30 mins to fix
    server/cards/card_clothingcards.js on lines 59..61
    server/cards/card_groceriescards.js on lines 27..29
    server/cards/card_restaurantcards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 27..29
    server/cards/card_restaurantcards.js on lines 59..61
    server/cards/card_restaurantcards.js on lines 67..69
    server/cards/card_restaurantcards.js on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return G.i18n.localLevelTextShort_4;
    Severity: Major
    Found in client/game/UIServices.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return G.i18n.localLevelText_4;
      Severity: Major
      Found in client/game/UIServices.js - About 30 mins to fix

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        function BuildClothingLux2Card(id) {
    this.Inherits(BuildClothingCard,id,205,2,[ {ht:[1,2], pro:1600} ], 10);
}
        Severity: Major
        Found in server/cards/card_clothingcards.js and 7 other locations - About 30 mins to fix
        server/cards/card_groceriescards.js on lines 27..29
        server/cards/card_groceriescards.js on lines 43..45
        server/cards/card_restaurantcards.js on lines 19..21
        server/cards/card_restaurantcards.js on lines 27..29
        server/cards/card_restaurantcards.js on lines 59..61
        server/cards/card_restaurantcards.js on lines 67..69
        server/cards/card_restaurantcards.js on lines 75..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        function BuildRestaurantItaSmCard(id) {
    this.Inherits(BuildRestaurantCard,id,0,2,[ {ht:[5,10], pro:20} ], 0);
}
        Severity: Major
        Found in server/cards/card_restaurantcards.js and 7 other locations - About 30 mins to fix
        server/cards/card_clothingcards.js on lines 59..61
        server/cards/card_groceriescards.js on lines 27..29
        server/cards/card_groceriescards.js on lines 43..45
        server/cards/card_restaurantcards.js on lines 27..29
        server/cards/card_restaurantcards.js on lines 59..61
        server/cards/card_restaurantcards.js on lines 67..69
        server/cards/card_restaurantcards.js on lines 75..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        function BuildRestaurantSteakPreCard(id) {
    this.Inherits(BuildRestaurantCard,id,6,2,[ {ht:[1,5], pro:200} ], 10);
}
        Severity: Major
        Found in server/cards/card_restaurantcards.js and 7 other locations - About 30 mins to fix
        server/cards/card_clothingcards.js on lines 59..61
        server/cards/card_groceriescards.js on lines 27..29
        server/cards/card_groceriescards.js on lines 43..45
        server/cards/card_restaurantcards.js on lines 19..21
        server/cards/card_restaurantcards.js on lines 27..29
        server/cards/card_restaurantcards.js on lines 59..61
        server/cards/card_restaurantcards.js on lines 75..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        function BuildRestaurantChinLrgCard(id) {
    this.Inherits(BuildRestaurantCard,id,5,2,[ {ht:[1,10], pro:30} ], 0);
}
        Severity: Major
        Found in server/cards/card_restaurantcards.js and 7 other locations - About 30 mins to fix
        server/cards/card_clothingcards.js on lines 59..61
        server/cards/card_groceriescards.js on lines 27..29
        server/cards/card_groceriescards.js on lines 43..45
        server/cards/card_restaurantcards.js on lines 19..21
        server/cards/card_restaurantcards.js on lines 27..29
        server/cards/card_restaurantcards.js on lines 67..69
        server/cards/card_restaurantcards.js on lines 75..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

        function BuildRestaurantFrePreCard(id) {
    this.Inherits(BuildRestaurantCard,id,7,2,[ {ht:[1,2], pro:1500} ], 30);
}
        Severity: Major
        Found in server/cards/card_restaurantcards.js and 7 other locations - About 30 mins to fix
        server/cards/card_clothingcards.js on lines 59..61
        server/cards/card_groceriescards.js on lines 27..29
        server/cards/card_groceriescards.js on lines 43..45
        server/cards/card_restaurantcards.js on lines 19..21
        server/cards/card_restaurantcards.js on lines 27..29
        server/cards/card_restaurantcards.js on lines 59..61
        server/cards/card_restaurantcards.js on lines 67..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                ctx.fillText(G.i18n[this.title]/*+" ("+this.id+")"*/, this.x+5, this.y+12);
        Severity: Minor
        Found in client/game/Card.js and 1 other location - About 30 mins to fix
        client/game/Card.js on lines 236..236

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                return false;
        Severity: Major
        Found in client/game/FieldPane.js - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  ctx.fillText(G.i18n[this.title]/*+" ("+this.id+")"*/, this.x+5, this.y+12);
          Severity: Minor
          Found in client/game/Card.js and 1 other location - About 30 mins to fix
          client/game/Card.js on lines 181..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function resetSuppliesAndCalcBuildstate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          Game.prototype.resetSuppliesAndCalcBuildstate = function(changedFields) {
    for(var k in this.gameField.fields) {
        var field = this.gameField.fields[k];            
        if(field.buildState == 1) {
            field.buildState++;
          Severity: Minor
          Found in server/rule_game.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function createBlock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          CardStack.prototype.createBlock = function(stage) {
    var id = -1;
    this.cards.forEach(function(e) {
        id = Math.max(e.id,id);
    });
          Severity: Minor
          Found in server/rule_cardstack.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language