Sign upLogin

oglimmer/citybuilder

View on GitHub
Star
server/cards/card_groceriescards.js

Summary

Maintainability
C
1 day
Test Coverage

Function BuildGroceriesCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function BuildGroceriesCard(id,no,range,profitConfig,localLevelMod) {
Severity: Minor
Found in server/cards/card_groceriescards.js - About 35 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    function BuildGroceriesSmCard(id) {
    this.Inherits(BuildGroceriesCard,id,100,3,[ {ht:[1,4], pro:100}, {ht:[5,8], pro:20}, {ht:[9,10], pro:2} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 5 other locations - About 2 hrs to fix
    server/cards/card_clothingcards.js on lines 35..37
    server/cards/card_clothingcards.js on lines 67..69
    server/cards/card_electroniccards.js on lines 19..21
    server/cards/card_groceriescards.js on lines 51..53
    server/cards/card_jewelerycards.js on lines 27..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

    function BuildGroceriesSuperMartCard(id) {
    this.Inherits(BuildGroceriesCard,id,104,3,[ {ht:[1,4], pro:100}, {ht:[5,7], pro:35}, {ht:[8,10], pro:10} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 5 other locations - About 2 hrs to fix
    server/cards/card_clothingcards.js on lines 35..37
    server/cards/card_clothingcards.js on lines 67..69
    server/cards/card_electroniccards.js on lines 19..21
    server/cards/card_groceriescards.js on lines 19..21
    server/cards/card_jewelerycards.js on lines 27..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

    function BuildGroceriesDisc2Card(id) {
    this.Inherits(BuildGroceriesCard,id,102,1,[ {ht:[4,8], pro:30}, {ht:[9,10], pro:5} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 9 other locations - About 1 hr to fix
    server/cards/card_clothingcards.js on lines 27..29
    server/cards/card_clothingcards.js on lines 51..53
    server/cards/card_clothingcards.js on lines 75..77
    server/cards/card_groceriescards.js on lines 59..61
    server/cards/card_jewelerycards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 43..45
    server/cards/card_restaurantcards.js on lines 51..53
    server/cards/card_restaurantcards.js on lines 83..85
    server/cards/card_restaurantcards.js on lines 91..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 10 locations. Consider refactoring.
    Open

    function BuildGroceriesBioSmCard(id) {
    this.Inherits(BuildGroceriesCard,id,105,2,[ {ht:[1,2], pro:300}, {ht:[3,5], pro:80} ], 10);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 9 other locations - About 1 hr to fix
    server/cards/card_clothingcards.js on lines 27..29
    server/cards/card_clothingcards.js on lines 51..53
    server/cards/card_clothingcards.js on lines 75..77
    server/cards/card_groceriescards.js on lines 35..37
    server/cards/card_jewelerycards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 43..45
    server/cards/card_restaurantcards.js on lines 51..53
    server/cards/card_restaurantcards.js on lines 83..85
    server/cards/card_restaurantcards.js on lines 91..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function BuildGroceriesBioLrgCard(id) {
    this.Inherits(BuildGroceriesCard,id,106,2,[ {ht:[1,3], pro:250}, {ht:[4,7], pro:75} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 1 other location - About 1 hr to fix
    server/cards/card_restaurantcards.js on lines 99..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function BuildGroceriesDisc3Card(id) {
    this.Inherits(BuildGroceriesCard,id,103,1,[ {ht:[8,10], pro:15} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 7 other locations - About 30 mins to fix
    server/cards/card_clothingcards.js on lines 59..61
    server/cards/card_groceriescards.js on lines 27..29
    server/cards/card_restaurantcards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 27..29
    server/cards/card_restaurantcards.js on lines 59..61
    server/cards/card_restaurantcards.js on lines 67..69
    server/cards/card_restaurantcards.js on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    function BuildGroceriesDisc1Card(id) {
    this.Inherits(BuildGroceriesCard,id,101,1,[ {ht:[1,10], pro:10} ], 0);
}
    Severity: Major
    Found in server/cards/card_groceriescards.js and 7 other locations - About 30 mins to fix
    server/cards/card_clothingcards.js on lines 59..61
    server/cards/card_groceriescards.js on lines 43..45
    server/cards/card_restaurantcards.js on lines 19..21
    server/cards/card_restaurantcards.js on lines 27..29
    server/cards/card_restaurantcards.js on lines 59..61
    server/cards/card_restaurantcards.js on lines 67..69
    server/cards/card_restaurantcards.js on lines 75..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status