oglimmer/ggo

View on GitHub
core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java

Summary

Maintainability
C
1 day
Test Coverage

Method resolveBattle has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    protected void resolveBattle(Unit u1, Unit u2, boolean crossing) {
        int for1 = isFortified(u1);
        int for2 = isFortified(u2);
        int sup1 = isSupported(u1);
        int sup2 = isSupported(u2);

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolveBattle has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected void resolveBattle(Unit u1, Unit u2, boolean crossing) {
        int for1 = isFortified(u1);
        int for2 = isFortified(u2);
        int sup1 = isSupported(u1);
        int sup2 = isSupported(u2);

    Method score has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected static void score(Unit winningUnit, CommandCenter cc) {
            CommandType ct = cc.getByUnit(winningUnit).getCommandType();
            if (!cc.isDry()) {
                int score = 0;
                if (ct == CommandType.MOVE) {
    Severity: Minor
    Found in core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected void killCrossingBoth(Unit u1, Unit u2) {
            addInfo(u1.getPlayer(), "DEFEAT: Your " + u1.getUnitType() + " on " + u1.getDeployedOn().getId()
                    + " got destroyed while crossing by " + u2.getUnitType() + " from " + u2.getDeployedOn().getId() + ".");
            addInfo(u2.getPlayer(), "DEFEAT: Your " + u2.getUnitType() + " on " + u2.getDeployedOn().getId()
                    + " got destroyed while crossing by " + u1.getUnitType() + " from " + u1.getDeployedOn().getId() + ".");
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 109..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        protected void killBoth(Unit u1, Unit u2) {
            addInfo(u1.getPlayer(), "DEFEAT: Your " + u1.getUnitType() + " on " + u1.getDeployedOn().getId()
                    + " got destroyed by " + u2.getUnitType() + " from " + u2.getDeployedOn().getId() + ".");
            addInfo(u2.getPlayer(), "DEFEAT: Your " + u2.getUnitType() + " on " + u2.getDeployedOn().getId()
                    + " got destroyed by " + u1.getUnitType() + " from " + u1.getDeployedOn().getId() + ".");
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 92..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        protected void killCrossingOne(Unit killed, Unit killer) {
            addInfo(killed.getPlayer(),
                    "DEFEAT: Your " + killed.getUnitType() + " on " + killed.getDeployedOn().getId()
                            + " got destroyed while crossing " + killer.getUnitType() + " from "
                            + killer.getDeployedOn().getId() + ".");
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 101..107
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 118..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 121.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        protected void killOne(Unit killed, Unit killer) {
            addInfo(killed.getPlayer(), "DEFEAT: Your " + killed.getUnitType() + " on " + killed.getDeployedOn().getId()
                    + " got destroyed by " + killer.getUnitType() + " from " + killer.getDeployedOn().getId() + ".");
            addInfo(killer.getPlayer(), "VICTORY: Your " + killer.getUnitType() + " on " + killer.getDeployedOn().getId()
                    + " destroyed " + killed.getUnitType() + " on " + killed.getDeployedOn().getId() + ".");
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 82..90
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 118..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 121.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        protected void killBombarb(Unit unitKilled, Unit killer) {
            addInfo(unitKilled.getPlayer(),
                    "DEFEAT: Your " + unitKilled.getUnitType() + " on " + unitKilled.getDeployedOn().getId()
                            + " got bombarded by " + killer.getUnitType() + " from " + killer.getDeployedOn().getId()
                            + ".");
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 82..90
    core/src/main/java/de/oglimmer/ggo/logic/battle/BaseBattleResolver.java on lines 101..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 121.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status