Sign upLogin

oglimmer/ggo

View on GitHub
Star
core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java

Summary

Maintainability
C
1 day
Test Coverage

Method adjacent has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public static boolean adjacent(Field a, Field b) {
        int thisX = (int) a.getPos().getX();
        int thisY = (int) a.getPos().getY();
        int fx = (int) b.getPos().getX();
        int fy = (int) b.getPos().getY();
Severity: Minor
Found in core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

            if (zero(thisX, fx) && minus(thisY, fy) || plus(thisX, fx) && minus(thisY, fy)
                    || zero(thisX, fx) && plus(thisY, fy) || plus(thisX, fx) && plus(thisY, fy)) {
                return true;
            }
Severity: Critical
Found in core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

                if (minus(thisX, fx) && minus(thisY, fy) || zero(thisX, fx) && minus(thisY, fy)
                    || minus(thisX, fx) && plus(thisY, fy) || zero(thisX, fx) && plus(thisY, fy)) {
                return true;
            }
    Severity: Critical
    Found in core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              } else {
            if (zero(thisX, fx) && minus(thisY, fy) || plus(thisX, fx) && minus(thisY, fy)
                    || zero(thisX, fx) && plus(thisY, fy) || plus(thisX, fx) && plus(thisY, fy)) {
                return true;
            }
      Severity: Major
      Found in core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java and 1 other location - About 1 hr to fix
      core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java on lines 55..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (even(thisX) && even(thisY) || odd(thisX) && even(thisY)) {
            if (minus(thisX, fx) && minus(thisY, fy) || zero(thisX, fx) && minus(thisY, fy)
                    || minus(thisX, fx) && plus(thisY, fy) || zero(thisX, fx) && plus(thisY, fy)) {
                return true;
            }
      Severity: Major
      Found in core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java and 1 other location - About 1 hr to fix
      core/src/main/java/de/oglimmer/ggo/logic/util/FieldUtil.java on lines 60..65

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status