oglimmer/ggo

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    protected void killBombarb(Unit unitKilled, Unit killer) {
        addInfo(unitKilled.getPlayer(),
                "DEFEAT: Your " + unitKilled.getUnitType() + " on " + unitKilled.getDeployedOn().getId()
                        + " got bombarded by " + killer.getUnitType() + " from " + killer.getDeployedOn().getId()
                        + ".");

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            signal: function (type, data) {
                                if (!win.closed && win.fire) {
                                    win.fire(atmosphere.util.stringifyJSON({
                                        target: "p",
                                        type: type,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                            signal: function (type, data) {
                                if (!win.closed && win.fire) {
                                    win.fire(atmosphere.util.stringifyJSON({
                                        target: "c",
                                        type: type,

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    protected void killOne(Unit killed, Unit killer) {
        addInfo(killed.getPlayer(), "DEFEAT: Your " + killed.getUnitType() + " on " + killed.getDeployedOn().getId()
                + " got destroyed by " + killer.getUnitType() + " from " + killer.getDeployedOn().getId() + ".");
        addInfo(killer.getPlayer(), "VICTORY: Your " + killer.getUnitType() + " on " + killer.getDeployedOn().getId()
                + " destroyed " + killed.getUnitType() + " on " + killed.getDeployedOn().getId() + ".");

• Read up
  Read up

Function getFieldByPos has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    /*private*/Board.prototype.getFieldByPos = function(pos) {
        // x,y base coordinate
        var hexPosY = Math.floor(pos.y / (Constants.size.height * 0.75));
        var hexPosX = Math.floor(pos.x / Constants.size.width);
        // odd or even row?

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $("#btnAi").click(function() {
            $.ajax({
                url : "./CreateAiQuery.action",
                success : function(result) {
                    document.location.href="Board.action?playerId="+result.playerId;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $("#btnTutorial").click(function() {
            $.ajax({
                url : "./CreateTutorialQuery.action",
                success : function(result) {
                    document.location.href="Board.action?playerId="+result.playerId;

• Read up
  Read up

Function _invokeCallback has 44 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            function _invokeCallback() {
                var call = function (index, func) {
                    func(_response);
                };

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        ctx.lineTo(tox-headlen*Math.cos(angle-Math.PI/7),toy-headlen*Math.sin(angle-Math.PI/7));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        ctx.lineTo(tox-headlen*Math.cos(angle-Math.PI/7),toy-headlen*Math.sin(angle-Math.PI/7));

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            case Constants.UNIT_TYPE_TANK:
                var img=document.getElementById("tank_"+this.color);
                ctx.drawImage(img,cx-img.width*.5,cy - img.height*.5);
                break;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            case Constants.UNIT_TYPE_ARTILLERY:
                var img=document.getElementById("artillery_"+this.color);
                ctx.drawImage(img,cx-img.width*.5,cy - img.height*.5);
                break;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            case Constants.UNIT_TYPE_INFANTRY:
                var img=document.getElementById("infantry_"+this.color);
                ctx.drawImage(img,cx-img.width*.5,cy - img.height*.5);
                break;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            case Constants.UNIT_TYPE_AIRBORNE:
                var img=document.getElementById("airborne_"+this.color);
                ctx.drawImage(img,cx-img.width*.5,cy - img.height*.5);
                break;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            case Constants.UNIT_TYPE_CITY:
                var img=document.getElementById("city_"+this.color);
                ctx.drawImage(img,cx-img.width*.5,cy - img.height*.5);
                break;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

            case Constants.UNIT_TYPE_HELICOPTER:
                var img=document.getElementById("helicopter_"+this.color);
                ctx.drawImage(img,cx-img.width*.5,cy - img.height*.5);
                break;

• Read up
  Read up

Function _handleProtocol has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            function _handleProtocol(request, message) {

                var nMessage = message;
                if (request.transport === 'polling') return nMessage;

Function _doRequest has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            function _doRequest(ajaxRequest, request, create) {
                // Prevent Android to cache request
                var url = request.url;
                if (request.dispatchUrl != null && request.method === 'POST') {
                    url += request.dispatchUrl;

Function draw has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    ModalDialog.prototype.draw = function(ctx) {
        
        if(!this.show) {
            return;
        }

Function str has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            return window.JSON && window.JSON.stringify ? window.JSON.stringify(value) : (function str(key, holder) {
                var i, v, len, partial, value = holder[key], type = typeof value;

                if (value && typeof value === "object" && typeof value.toJSON === "function") {
                    value = value.toJSON(key);