oklahomer/go-sarah

View on GitHub
watchers/filewatcher.go

Summary

Maintainability
C
1 day
Test Coverage

Method fileWatcher.run has a Cognitive Complexity of 65 (exceeds 20 allowed). Consider refactoring.
Open

func (w *fileWatcher) run(ctx context.Context, events <-chan fsnotify.Event, errs <-chan error) {
    subscriptions := map[string][]*subscription{}

OP:
    for {
Severity: Minor
Found in watchers/filewatcher.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fileWatcher.run has 75 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (w *fileWatcher) run(ctx context.Context, events <-chan fsnotify.Event, errs <-chan error) {
    subscriptions := map[string][]*subscription{}

OP:
    for {
Severity: Minor
Found in watchers/filewatcher.go - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                    } else if err != nil {
                        logger.Warnf("Failed to locate %s: %+v", event.Name, err)
                        continue OP
                    }
    Severity: Major
    Found in watchers/filewatcher.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status