oliverfarrell/accessible-tabs

View on GitHub

Showing 6 of 6 total issues

Function Tabs has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Tabs = (function () {

  var config = {
    selector: document.querySelectorAll('.tabs')
  };
Severity: Major
Found in src/tabs.js - About 4 hrs to fix

    Function Tabs has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    var Tabs = (function () {
    
      var config = {
        selector: document.querySelectorAll('.tabs')
      };
    Severity: Minor
    Found in src/tabs.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function init has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var init = function (options) {
    
        // overwrite the default configuration
        for (var prop in options) {
          if (options.hasOwnProperty(prop)) {
    Severity: Minor
    Found in src/tabs.js - About 1 hr to fix

      Function _makeAccessible has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var _makeAccessible = function (el) {
      
          var tabsList = el.querySelector('ul'),
              tabListItems = tabsList.querySelectorAll('li'),
              tabListLinks = tabsList.querySelectorAll('a'),
      Severity: Minor
      Found in src/tabs.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var nextElementSibling = function (el) {
        
            do { el = el.nextSibling; } while (el && el.nodeType !== 1);
            return el;
        
        
        Severity: Minor
        Found in src/tabs.js and 1 other location - About 45 mins to fix
        src/tabs.js on lines 58..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var previousElementSibling = function (el) {
        
            do { el = el.previousSibling; } while (el && el.nodeType !== 1);
            return el;
        
        
        Severity: Minor
        Found in src/tabs.js and 1 other location - About 45 mins to fix
        src/tabs.js on lines 46..51

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language