Sign upLogin

onionskin/onionskin

View on GitHub
Star

Showing 5 of 10 total issues

Function delete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

IndexedDB.prototype.delete = function (key) {
  return this._key(key).then(function (k) {
    return this.db().then(function (db) {
      var transaction = db.transaction('cache', 'readwrite');
      var store = transaction.objectStore('cache');
Severity: Minor
Found in src/onionskin/drivers/indexed_db.js - About 1 hr to fix

    Function IndexedDB has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function IndexedDB(namespace) {
  this.namespace = namespace || 'onionskin';

  this.indexedDB = window.indexedDB ||
    window.mozIndexedDB ||
    Severity: Minor
    Found in src/onionskin/drivers/indexed_db.js - About 1 hr to fix

      Function get has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Pool.prototype.get = function (key, cachePolicy, policyData, generator) {
  var item = this.getItem(key);

  if (typeof cachePolicy === 'function') {
    generator = cachePolicy;
      Severity: Minor
      Found in src/onionskin/pool.js - About 1 hr to fix

        Function get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Item.prototype.get = function (cachePolicy, policyData) {
  var that = this;
  this.cachePolicy = cachePolicy || Item.CP_NONE;
  this.policyData = policyData;
        Severity: Minor
        Found in src/onionskin/item.js - About 1 hr to fix

          Function isMiss has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          Item.prototype.isMiss = function () {
  var that = this;

  var isMissed = function (locked, resolve) {
    var miss;
          Severity: Minor
          Found in src/onionskin/item.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language