open-orchestra/open-orchestra-base-api-bundle

View on GitHub

Showing 7 of 7 total issues

Method reverseTransform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function reverseTransform(Request $request, $id, $type, $event, $eventClass)
    {
        $facadeName = Inflector::classify($type) . 'Facade';
        $typeName = Inflector::tableize($type);
        $format = $request->get('_format', 'json');
Severity: Minor
Found in BaseApiBundle/Controller/BaseController.php - About 1 hr to fix

Method provideFormatAndResponseType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function provideFormatAndResponseType()
    {
        $okCode = 200;
        $okResponse = Phake::mock('OpenOrchestra\BaseApi\Facade\FacadeInterface');
        $response = array();
Severity: Minor
Found in BaseApi/Tests/EventSubscriber/SerializerSubscriberTest.php - About 1 hr to fix

Method reverseTransform has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected function reverseTransform(Request $request, $id, $type, $event, $eventClass)
Severity: Minor
Found in BaseApiBundle/Controller/BaseController.php - About 35 mins to fix

Method testSupport has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function testSupport($support, $user, $password, $grantType, $refreshToken)
Severity: Minor
Found in BaseApi/Tests/OAuth2/Strategy/RefreshTokenStrategyTest.php - About 35 mins to fix

Method testOnKernelViewSerialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function testOnKernelViewSerialize($format, $responseContentType, $classAnnotation, $controllerResult, $expectedStatusCode)
Severity: Minor
Found in BaseApi/Tests/EventSubscriber/SerializerSubscriberTest.php - About 35 mins to fix

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        ApiClientRepositoryInterface $apiClientRepository,
        Serializer $serializer,
        ValidatorInterface $validator,
        AccessTokenManager $accessTokenManager,
        AccessTokenRepositoryInterface $accessTokenRepository
Severity: Minor
Found in BaseApi/OAuth2/Strategy/AbstractOAuth2Strategy.php - About 35 mins to fix

Method create has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function create(ContainerBuilder $container, $id, $config, $userProvider, $defaultEntryPoint)
Severity: Minor
Found in BaseApiBundle/DependencyInjection/Security/Factory/OAuth2Factory.php - About 35 mins to fix
Severity
Category
Status
Source
Language