Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
ApiBundle/Controller/RedirectionController.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration' in method 'listAction'.
Open

        $configuration = PaginateFinderConfiguration::generateFromRequest($request, $mapping);
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $repository = $this->get('open_orchestra_model.repository.redirection');
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to method get from undeclared class \Symfony\Component\HttpFoundation\Request
Open

        $format = $request->get('_format', 'json');
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::getParameter
Open

            $this->getParameter('open_orchestra_api.facade.redirection_collection.class'),
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to method __construct from undeclared class \OpenOrchestra\ModelInterface\Event\RedirectionEvent
Open

        $this->dispatchEvent(RedirectionEvents::REDIRECTION_DELETE, new RedirectionEvent($redirection));
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::dispatchEvent
Open

        $this->dispatchEvent(RedirectionEvents::REDIRECTION_DELETE, new RedirectionEvent($redirection));
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $redirection = $this->get('open_orchestra_model.repository.redirection')->find($redirectionId);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Possibly zero references to use statement for classlike/namespace Config (\Sensio\Bundle\FrameworkExtraBundle\Configuration)
Open

use Sensio\Bundle\FrameworkExtraBundle\Configuration as Config;
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Reference to constant REDIRECTION_DELETE from undeclared class \OpenOrchestra\ModelInterface\RedirectionEvents
Open

        $this->dispatchEvent(RedirectionEvents::REDIRECTION_DELETE, new RedirectionEvent($redirection));
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Return type of listAction() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function listAction(Request $request)
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Possibly zero references to use statement for classlike/namespace Api (\OpenOrchestra\BaseApiBundle\Controller\Annotation)
Open

use OpenOrchestra\BaseApiBundle\Controller\Annotation as Api;
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Class extends undeclared class \OpenOrchestra\BaseApiBundle\Controller\BaseController
Open

class RedirectionController extends BaseController
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        return $this->get('open_orchestra_api.transformer_manager')->transform('redirection_collection', $redirectionList);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Parameter $request has undeclared type \Symfony\Component\HttpFoundation\Request
Open

    public function listAction(Request $request)
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Return type of listRedirectionNodeAction() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function listRedirectionNodeAction($siteId, $nodeId, $locale)
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Reference to constant REDIRECTION_DELETE from undeclared class \OpenOrchestra\ModelInterface\RedirectionEvents
Open

                $this->dispatchEvent(RedirectionEvents::REDIRECTION_DELETE, new RedirectionEvent($redirection));
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::dispatchEvent
Open

                $this->dispatchEvent(RedirectionEvents::REDIRECTION_DELETE, new RedirectionEvent($redirection));
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Return type of deleteAction() is undeclared type \Symfony\Component\HttpFoundation\Response
Open

    public function deleteAction($redirectionId)
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::denyAccessUnlessGranted
Open

        $this->denyAccessUnlessGranted(ContributionActionInterface::READ, RedirectionInterface::ENTITY_TYPE);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::isGranted
Open

            if ($this->isGranted(ContributionActionInterface::DELETE, $redirection)) {
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $dm = $this->get('object_manager');
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\NodeInterface
Open

        if (!$node instanceof NodeInterface) {
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Parameter $request has undeclared type \Symfony\Component\HttpFoundation\Request
Open

    public function deleteRedirectionsAction(Request $request)
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $facade = $this->get('jms_serializer')->deserialize(
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to method getContent from undeclared class \Symfony\Component\HttpFoundation\Request
Open

            $request->getContent(),
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Returning type array{} but deleteRedirectionsAction() is declared to return \Symfony\Component\HttpFoundation\Response
Open

        return array();
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to method __construct from undeclared class \OpenOrchestra\DisplayBundle\Exception\NodeNotFoundException
Open

            throw new NodeNotFoundException();
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Return type of deleteRedirectionsAction() is undeclared type \Symfony\Component\HttpFoundation\Response
Open

    public function deleteRedirectionsAction(Request $request)
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $node = $this->get('open_orchestra_model.repository.node')->findOneByNodeAndSite($nodeId, $siteId);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $redirections = $this->get('open_orchestra_api.transformer_manager')->reverseTransform('redirection_collection', $facade);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to method __construct from undeclared class \OpenOrchestra\ModelInterface\Event\RedirectionEvent
Open

                $this->dispatchEvent(RedirectionEvents::REDIRECTION_DELETE, new RedirectionEvent($redirection));
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to method generateFromRequest from undeclared class \OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration
Open

        $configuration = PaginateFinderConfiguration::generateFromRequest($request, $mapping);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $redirectionRepository = $this->get('open_orchestra_model.repository.redirection');
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::denyAccessUnlessGranted
Open

        $this->denyAccessUnlessGranted(ContributionActionInterface::READ, $node);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $repository = $this->get('open_orchestra_model.repository.redirection');
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Controller\RedirectionController::get
Open

        $facade = $this->get('open_orchestra_api.transformer_manager')->transform('redirection_collection', $collection);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $this->denyAccessUnlessGranted(ContributionActionInterface::READ, RedirectionInterface::ENTITY_TYPE);
Severity: Critical
Found in ApiBundle/Controller/RedirectionController.php by phan

Returning type array{} but deleteAction() is declared to return \Symfony\Component\HttpFoundation\Response
Open

        return array();
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phan

Avoid excessively long variable names like $redirectionRepository. Keep variable name length under 20.
Open

        $redirectionRepository = $this->get('open_orchestra_model.repository.redirection');
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid variables with short names like $dm. Configured minimum length is 3.
Open

        $dm = $this->get('object_manager');
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Line exceeds 120 characters; contains 121 characters
Open

        $facade = $this->get('open_orchestra_api.transformer_manager')->transform('redirection_collection', $collection);
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phpcodesniffer

Line exceeds 120 characters; contains 123 characters
Open

        return $this->get('open_orchestra_api.transformer_manager')->transform('redirection_collection', $redirectionList);
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

        $redirections = $this->get('open_orchestra_api.transformer_manager')->reverseTransform('redirection_collection', $facade);
Severity: Minor
Found in ApiBundle/Controller/RedirectionController.php by phpcodesniffer

There are no issues that match your filters.

Category
Status