open-orchestra/open-orchestra-cms-bundle

View on GitHub
ApiBundle/Handler/ContentAttributeValueHandler.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getSubscribingMethods has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getSubscribingMethods()
    {
        return array(
            array(
                'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,
Severity: Minor
Found in ApiBundle/Handler/ContentAttributeValueHandler.php - About 1 hr to fix

Function deserializeFieldType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function deserializeFieldType(GenericDeserializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)
    {
        $facade = $visitor->getCurrentObject();
        if ($facade instanceof ContentAttributeFacade && null !== $facade->type) {
            if (isset($this->fieldTypes[$facade->type]) &&
Severity: Minor
Found in ApiBundle/Handler/ContentAttributeValueHandler.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$type'.
Open

    public function deserializeFieldType(GenericDeserializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$type'.
Open

    public function serializeFieldType(GenericSerializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Reference to constant DIRECTION_DESERIALIZATION from undeclared class \JMS\Serializer\GraphNavigator
Open

                'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,

Reference to constant DIRECTION_SERIALIZATION from undeclared class \JMS\Serializer\GraphNavigator
Open

                'direction' => GraphNavigator::DIRECTION_SERIALIZATION,

Call to method getNavigator from undeclared class \JMS\Serializer\GenericDeserializationVisitor
Open

                return $visitor->getNavigator()->accept($contentAttributeValue, array('name' => $this->fieldTypes[$facade->type]['deserialize_type'], 'params' => array()), $context);

Parameter $context has undeclared type \JMS\Serializer\Context
Open

    public function deserializeFieldType(GenericDeserializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

Class implements undeclared interface \JMS\Serializer\Handler\SubscribingHandlerInterface
Open

class ContentAttributeValueHandler implements SubscribingHandlerInterface

Call to method getNavigator from undeclared class \JMS\Serializer\GenericSerializationVisitor
Open

        return $visitor->getNavigator()->accept($contentAttributeValue, null, $context);

Call to method getCurrentObject from undeclared class \JMS\Serializer\GenericDeserializationVisitor
Open

        $facade = $visitor->getCurrentObject();

Parameter $visitor has undeclared type \JMS\Serializer\GenericDeserializationVisitor
Open

    public function deserializeFieldType(GenericDeserializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

Reference to constant DIRECTION_DESERIALIZATION from undeclared class \JMS\Serializer\GraphNavigator
Open

                'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,

Parameter $context has undeclared type \JMS\Serializer\Context
Open

    public function serializeFieldType(GenericSerializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

Parameter $visitor has undeclared type \JMS\Serializer\GenericSerializationVisitor
Open

    public function serializeFieldType(GenericSerializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

Reference to constant DIRECTION_SERIALIZATION from undeclared class \JMS\Serializer\GraphNavigator
Open

                'direction' => GraphNavigator::DIRECTION_SERIALIZATION,

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        return array(
            array(
                'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,
                'format' => 'json',
                'type' => 'ContentAttributeValue',
Severity: Major
Found in ApiBundle/Handler/ContentAttributeValueHandler.php and 1 other location - About 1 hr to fix
ApiBundle/Tests/Handler/ContentAttributeValueHandlerTest.php on lines 41..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid excessively long variable names like $contentAttributeValue. Keep variable name length under 20.
Open

    public function serializeFieldType(GenericSerializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $contentAttributeValue. Keep variable name length under 20.
Open

    public function deserializeFieldType(GenericDeserializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 131 characters
Open

    public function serializeFieldType(GenericSerializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

Line exceeds 120 characters; contains 135 characters
Open

    public function deserializeFieldType(GenericDeserializationVisitor $visitor, $contentAttributeValue, array $type, Context $context)

Line exceeds 120 characters; contains 123 characters
Open

                if ($this->fieldTypes[$facade->type]['deserialize_type'] == 'array' && is_scalar($contentAttributeValue)) {

Line exceeds 120 characters; contains 182 characters
Open

                return $visitor->getNavigator()->accept($contentAttributeValue, array('name' => $this->fieldTypes[$facade->type]['deserialize_type'], 'params' => array()), $context);

There are no issues that match your filters.

Category
Status