Method testSubscribingMethods
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function testSubscribingMethods()
{
$this->assertSame(
array(
array(
- Create a ticketCreate a ticket
Avoid using static access to class '\Phake' in method 'testSerializeFieldTypeToJson'. Open
$context = Phake::mock('JMS\Serializer\Context');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Phake' in method 'testDeserializeFieldTypeToJson'. Open
$visitor = Phake::mock('JMS\Serializer\GenericDeserializationVisitor');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Phake' in method 'testDeserializeFieldTypeToJson'. Open
$contentAttributeFacade = Phake::mock('OpenOrchestra\ApiBundle\Facade\ContentAttributeFacade');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Phake' in method 'testDeserializeFieldTypeToJson'. Open
$context = Phake::mock('JMS\Serializer\Context');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\OpenOrchestra\ApiBundle\Handler\ContentAttributeValueHandler' in method 'testSubscribingMethods'. Open
ContentAttributeValueHandler::getSubscribingMethods()
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class '\Phake' in method 'testSerializeFieldTypeToJson'. Open
$visitor = Phake::mock('JMS\Serializer\GenericSerializationVisitor');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}
Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused parameters such as '$data'. Open
public function accept($data, array $type = null, Context $context)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$type'. Open
public function accept($data, array $type = null, Context $context)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$context'. Open
public function accept($data, array $type = null, Context $context)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Call to method mock
from undeclared class \Phake
Open
$visitor = Phake::mock('JMS\Serializer\GenericDeserializationVisitor');
- Create a ticketCreate a ticket
- Exclude checks
Call to method mock
from undeclared class \Phake
Open
$context = Phake::mock('JMS\Serializer\Context');
- Create a ticketCreate a ticket
- Exclude checks
Call to undeclared method \OpenOrchestra\ApiBundle\Tests\Handler\ContentAttributeValueHandlerTest::assertSame
Open
$this->assertSame(
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant DIRECTION_DESERIALIZATION
from undeclared class \JMS\Serializer\GraphNavigator
Open
'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant DIRECTION_DESERIALIZATION
from undeclared class \JMS\Serializer\GraphNavigator
Open
'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,
- Create a ticketCreate a ticket
- Exclude checks
Call to method when
from undeclared class \Phake
Open
Phake::when($visitor)->getNavigator()->thenReturn(new FakeGraphNavigator());
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant DIRECTION_SERIALIZATION
from undeclared class \JMS\Serializer\GraphNavigator
Open
'direction' => GraphNavigator::DIRECTION_SERIALIZATION,
- Create a ticketCreate a ticket
- Exclude checks
Call to method mock
from undeclared class \Phake
Open
$context = Phake::mock('JMS\Serializer\Context');
- Create a ticketCreate a ticket
- Exclude checks
Parameter $context
has undeclared type \JMS\Serializer\Context
Open
public function accept($data, array $type = null, Context $context)
- Create a ticketCreate a ticket
- Exclude checks
Call to undeclared method \OpenOrchestra\ApiBundle\Tests\Handler\ContentAttributeValueHandlerTest::assertEquals
Open
$this->assertEquals(FakeGraphNavigator::FAKE_RETURN_ACCEPT, $this->handler->SerializeFieldType($visitor, $contentAttributeValue, array(), $context));
- Create a ticketCreate a ticket
- Exclude checks
Call to method when
from undeclared class \Phake
Open
Phake::when($visitor)->getCurrentObject()->thenReturn($contentAttributeFacade);
- Create a ticketCreate a ticket
- Exclude checks
Reference to constant DIRECTION_SERIALIZATION
from undeclared class \JMS\Serializer\GraphNavigator
Open
'direction' => GraphNavigator::DIRECTION_SERIALIZATION,
- Create a ticketCreate a ticket
- Exclude checks
Call to method mock
from undeclared class \Phake
Open
$contentAttributeFacade = Phake::mock('OpenOrchestra\ApiBundle\Facade\ContentAttributeFacade');
- Create a ticketCreate a ticket
- Exclude checks
Call to method when
from undeclared class \Phake
Open
Phake::when($visitor)->getNavigator()->thenReturn(new FakeGraphNavigator());
- Create a ticketCreate a ticket
- Exclude checks
Call to method mock
from undeclared class \Phake
Open
$visitor = Phake::mock('JMS\Serializer\GenericSerializationVisitor');
- Create a ticketCreate a ticket
- Exclude checks
Class extends undeclared class \OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractBaseTestCase
Open
class ContentAttributeValueHandlerTest extends AbstractBaseTestCase
- Create a ticketCreate a ticket
- Exclude checks
Call to undeclared method \OpenOrchestra\ApiBundle\Tests\Handler\ContentAttributeValueHandlerTest::assertEquals
Open
$this->assertEquals($expected, $this->handler->deserializeFieldType($visitor, $contentAttributeValue, array(), $context));
- Create a ticketCreate a ticket
- Exclude checks
Required argument follows optional Open
public function accept($data, array $type = null, Context $context)
- Create a ticketCreate a ticket
- Exclude checks
Identical blocks of code found in 2 locations. Consider refactoring. Open
array(
array(
'direction' => GraphNavigator::DIRECTION_DESERIALIZATION,
'format' => 'json',
'type' => 'ContentAttributeValue',
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 110.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Avoid excessively long variable names like $contentAttributeValue. Keep variable name length under 20. Open
$contentAttributeValue = 'fakeValue';
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $contentAttributeValue. Keep variable name length under 20. Open
public function testDeserializeFieldTypeToJson($type, $contentAttributeValue, $expected)
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long variable names like $contentAttributeFacade. Keep variable name length under 20. Open
$contentAttributeFacade = Phake::mock('OpenOrchestra\ApiBundle\Facade\ContentAttributeFacade');
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Each class must be in a file by itself Open
class FakeGraphNavigator
- Create a ticketCreate a ticket
- Exclude checks
Line exceeds 120 characters; contains 157 characters Open
$this->assertEquals(FakeGraphNavigator::FAKE_RETURN_ACCEPT, $this->handler->SerializeFieldType($visitor, $contentAttributeValue, array(), $context));
- Create a ticketCreate a ticket
- Exclude checks
Line exceeds 120 characters; contains 130 characters Open
$this->assertEquals($expected, $this->handler->deserializeFieldType($visitor, $contentAttributeValue, array(), $context));
- Create a ticketCreate a ticket
- Exclude checks