Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
ApiBundle/Transformer/ContentCollectionTransformer.php

Summary

Maintainability
A
3 hrs
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$params'.
Open

    public function transform($contentCollection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Parameter $contentCollection has undeclared type \Doctrine\Common\Collections\Collection
Open

    public function transform($contentCollection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Call to method getContents from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

        $contentsFacade = $facade->getContents();
Severity: Critical
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Parameter $facade has undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentCollectionTransformer::getContext
Open

            $content = $this->getContext()->reverseTransform('content', $contentFacade);
Severity: Critical
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentCollectionTransformer::getContext
Open

            $facade->addContent($this->getContext()->transform('content', $content));
Severity: Critical
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

class ContentCollectionTransformer extends AbstractSecurityCheckerAwareTransformer
Severity: Critical
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentCollectionTransformer::newFacade
Open

        $facade = $this->newFacade();
Severity: Critical
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($contentCollection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentCollectionTransformer.php by phan

Similar blocks of code found in 8 locations. Consider refactoring.
Open

<?php

namespace OpenOrchestra\ApiBundle\Transformer;

use Doctrine\Common\Collections\Collection;
Severity: Major
Found in ApiBundle/Transformer/ContentCollectionTransformer.php and 7 other locations - About 3 hrs to fix
ApiBundle/Transformer/ContentTypeCollectionTransformer.php on lines 1..60
ApiBundle/Transformer/KeywordCollectionTransformer.php on lines 1..58
ApiBundle/Transformer/NodeCollectionTransformer.php on lines 1..62
ApiBundle/Transformer/RedirectionCollectionTransformer.php on lines 1..59
ApiBundle/Transformer/TrashItemCollectionTransformer.php on lines 1..58
UserAdminBundle/Transformer/UserCollectionTransformer.php on lines 1..59
WorkflowAdminBundle/Transformer/WorkflowProfileCollectionTransformer.php on lines 1..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status