Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
ApiBundle/Transformer/ContentTypeTransformer.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method transform has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function transform($contentType, array $params = array())
    {
        if (!$contentType instanceof ContentTypeInterface) {
            throw new TransformerParameterTypeException();
        }
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php - About 1 hr to fix

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        $facadeClass,
        MultiLanguagesChoiceManagerInterface $multiLanguagesChoiceManager,
        ContentRepositoryInterface $contentRepository,
        ContentTypeRepositoryInterface $contentTypeRepository,
        AuthorizationCheckerInterface $authorizationChecker,
Severity: Major
Found in ApiBundle/Transformer/ContentTypeTransformer.php - About 50 mins to fix

Avoid unused parameters such as '$params'.
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$params'.
Open

    public function transform($contentType, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

@throws type of transform has undeclared type \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

    public function transform($contentType, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getVersion from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->version = $contentType->getVersion();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, ContentTypeInterface::ENTITY_TYPE)
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Parameter $contentRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\ContentRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method choose from undeclared class \OpenOrchestra\ModelInterface\Manager\MultiLanguagesChoiceManagerInterface
Open

        $facade->name = $this->multiLanguagesChoiceManager->choose($contentType->getNames());
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method isDefiningStatusable from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->definingStatusable = $contentType->isDefiningStatusable();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method isLinkedToSite from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                $contentType->isLinkedToSite() && $contentType->isAlwaysShared(),
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method findOneByContentTypeIdInLastVersion from undeclared class \OpenOrchestra\ModelInterface\Repository\ContentTypeRepositoryInterface
Open

            return $this->contentTypeRepository->findOneByContentTypeIdInLastVersion($facade->contentTypeId);
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer::hasGroup
Open

        if ($this->hasGroup(CMSGroupContext::AUTHORIZATIONS)) {
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Parameter $multiLanguagesChoiceManager has undeclared type \OpenOrchestra\ModelInterface\Manager\MultiLanguagesChoiceManagerInterface
Open

    public function __construct(
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Parameter $contentType has undeclared type \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

    public function transform($contentType, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer->authorizationChecker
Open

                $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, ContentTypeInterface::ENTITY_TYPE)
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Return type of reverseTransform() is undeclared type \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getId from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->id = $contentType->getId();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method isLinkedToSite from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->linkedToSite = $contentType->isLinkedToSite();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

        parent::__construct($facadeClass, $authorizationChecker);
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($contentType, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method isDefiningVersionable from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->definingVersionable = $contentType->isDefiningVersionable();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer->authorizationChecker
Open

            $facade->addRight('can_duplicate', $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, ContentTypeInterface::ENTITY_TYPE));
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer->authorizationChecker
Open

            $facade->addRight('can_delete', $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $contentType) &&
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer::hasGroup
Open

        if ($this->hasGroup(CMSGroupContext::FIELD_TYPES)) {
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer::getContext
Open

                $facade->addField($this->getContext()->transform('field_type', $field));
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Parameter $authorizationChecker has undeclared type \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
Open

    public function __construct(
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer::newFacade
Open

        $facade = $this->newFacade();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to instance property contentTypeId from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

            return $this->contentTypeRepository->findOneByContentTypeIdInLastVersion($facade->contentTypeId);
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getContentTypeId from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->contentTypeId = $contentType->getContentTypeId();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method isDefiningStatusable from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                $contentType->isDefiningStatusable()
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Parameter $facade has undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        if (!$contentType instanceof ContentTypeInterface) {
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\ContentTypeTransformer->authorizationChecker
Open

                $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, $content)
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getFields from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

            foreach ($contentType->getFields() as $field) {
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to instance property contentTypeId from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

        if (null !== $facade->contentTypeId) {
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

class ContentTypeTransformer extends AbstractSecurityCheckerAwareTransformer
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getDefaultListable from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->defaultListable = $contentType->getDefaultListable();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Reference to constant ENTITY_TYPE from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

            $facade->addRight('can_duplicate', $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, ContentTypeInterface::ENTITY_TYPE));
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method isAlwaysShared from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                $contentType->isLinkedToSite() && $contentType->isAlwaysShared(),
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method __construct from undeclared class \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

            throw new TransformerParameterTypeException();
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getNames from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

        $facade->name = $this->multiLanguagesChoiceManager->choose($contentType->getNames());
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Call to method getContentTypeId from undeclared class \OpenOrchestra\ModelInterface\Model\ContentTypeInterface
Open

                $contentType->getContentTypeId(),
Severity: Critical
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Parameter $contentTypeRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\ContentTypeRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phan

Avoid excessively long variable names like $contentTypeRepository. Keep variable name length under 20.
Open

    protected $contentTypeRepository;
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $multiLanguagesChoiceManager. Keep variable name length under 20.
Open

        MultiLanguagesChoiceManagerInterface $multiLanguagesChoiceManager,
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $multiLanguagesChoiceManager. Keep variable name length under 20.
Open

    protected $multiLanguagesChoiceManager;
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $contentTypeRepository. Keep variable name length under 20.
Open

        ContentTypeRepositoryInterface $contentTypeRepository,
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Blank line found at start of control structure
Open

        if ($this->hasGroup(CMSGroupContext::AUTHORIZATIONS)) {
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpcodesniffer

Blank line found at end of control structure
Open
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpcodesniffer

Line exceeds 120 characters; contains 159 characters
Open

            $facade->addRight('can_duplicate', $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, ContentTypeInterface::ENTITY_TYPE));
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpcodesniffer

Line exceeds 120 characters; contains 136 characters
Open

            $facade->addRight('can_delete', $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $contentType) &&
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpcodesniffer

Line exceeds 120 characters; contains 126 characters
Open

                $this->authorizationChecker->isGranted(ContributionActionInterface::CREATE, ContentTypeInterface::ENTITY_TYPE)
Severity: Minor
Found in ApiBundle/Transformer/ContentTypeTransformer.php by phpcodesniffer

There are no issues that match your filters.

Category
Status