Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
ApiBundle/Transformer/RedirectionTransformer.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$params'.
Open

    public function transform($redirection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

class RedirectionTransformer extends AbstractSecurityCheckerAwareTransformer
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

@throws type of transform has undeclared type \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

    public function transform($redirection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        if (!$redirection instanceof RedirectionInterface) {
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getNodeId from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

            $facade->redirection = $redirection->getNodeId();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getLocale from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $facade->locale = $redirection->getLocale();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getNodeId from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        if ($redirection->getNodeId()) {
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method __construct from undeclared class \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

            throw new TransformerParameterTypeException();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getSiteName from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $facade->siteName = $redirection->getSiteName();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getRoutePattern from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $facade->routePattern = $redirection->getRoutePattern();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\RedirectionTransformer->authorizationChecker
Open

        $facade->addRight('can_delete', $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $redirection));
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Parameter $facade has undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Reference to instance property id from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

            return $this->redirectionRepository->find($facade->id);
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($redirection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Reference to undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

        parent::__construct($facadeClass, $authorizationChecker);
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getUrl from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $facade->redirection = $redirection->getUrl();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Parameter $authorizationChecker has undeclared type \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
Open

    public function __construct(
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Parameter $redirection has undeclared type \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

    public function transform($redirection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method find from undeclared class \OpenOrchestra\ModelInterface\Repository\RedirectionRepositoryInterface
Open

            return $this->redirectionRepository->find($facade->id);
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method getId from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $facade->id = $redirection->getId();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to method isPermanent from undeclared class \OpenOrchestra\ModelInterface\Model\RedirectionInterface
Open

        $facade->permanent = $redirection->isPermanent();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Parameter $redirectionRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\RedirectionRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\RedirectionTransformer::newFacade
Open

        $facade = $this->newFacade();
Severity: Critical
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\RedirectionTransformer->authorizationChecker
Open

        $facade->addRight('can_edit', $this->authorizationChecker->isGranted(ContributionActionInterface::EDIT, $redirection));
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Reference to instance property id from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

        if (null !== $facade->id) {
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phan

Avoid excessively long variable names like $redirectionRepository. Keep variable name length under 20.
Open

        RedirectionRepositoryInterface $redirectionRepository
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $redirectionRepository. Keep variable name length under 20.
Open

    protected $redirectionRepository;
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 127 characters
Open

        $facade->addRight('can_edit', $this->authorizationChecker->isGranted(ContributionActionInterface::EDIT, $redirection));
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phpcodesniffer

Line exceeds 120 characters; contains 131 characters
Open

        $facade->addRight('can_delete', $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $redirection));
Severity: Minor
Found in ApiBundle/Transformer/RedirectionTransformer.php by phpcodesniffer

There are no issues that match your filters.

Category
Status