open-orchestra/open-orchestra-cms-bundle

View on GitHub
ApiBundle/Transformer/SiteAliasTransformer.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function transform($siteAlias, array $params = array())

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method getScheme from undeclared class \OpenOrchestra\ModelInterface\Model\SiteAliasInterface
Open

        $facade->scheme = $siteAlias->getScheme();

Parameter $siteAlias has undeclared type \OpenOrchestra\ModelInterface\Model\SiteAliasInterface
Open

    public function transform($siteAlias, array $params = array())

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($siteAlias, array $params = array())

@throws type of transform has undeclared type \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

    public function transform($siteAlias, array $params = array())

Call to method getDomain from undeclared class \OpenOrchestra\ModelInterface\Model\SiteAliasInterface
Open

        $facade->domain = $siteAlias->getDomain();

Call to method getPrefix from undeclared class \OpenOrchestra\ModelInterface\Model\SiteAliasInterface
Open

        $facade->prefix= $siteAlias->getPrefix();

Call to method __construct from undeclared class \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

            throw new TransformerParameterTypeException();

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\SiteAliasInterface
Open

        if (!$siteAlias instanceof SiteAliasInterface) {

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteAliasTransformer::newFacade
Open

        $facade = $this->newFacade();

Call to method getLanguage from undeclared class \OpenOrchestra\ModelInterface\Model\SiteAliasInterface
Open

        $facade->language = $siteAlias->getLanguage();

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractTransformer
Open

class SiteAliasTransformer extends AbstractTransformer

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace OpenOrchestra\ApiBundle\Transformer;

use OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException;
Severity: Major
Found in ApiBundle/Transformer/SiteAliasTransformer.php and 1 other location - About 1 hr to fix
ApiBundle/Transformer/ContentAttributeTransformer.php on lines 1..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 115.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status